Fork me on GitHub
#luminus
<
2017-08-02
>
yogthos02:08:26

@donyorm looks like there might be some conflict from +boot profile here:

(defn mount-components []
  (let [content (js/document.getElementById "app")]
    (while (.hasChildNodes content)
      (.removeChild content (.-lastChild content)))
    (.appendChild content (js/document.createTextNode "Welcome to gallery"))))

(defn init! []
  (mount-components))

yogthos02:08:34

that shows up with the lein profile

donyorm02:08:58

@yogthos sorry, what's happening? Does that snippet not appear when using the +boot profile?

yogthos02:08:05

oh wait that might be ok

yogthos02:08:26

I forgot what was happening with the cljs/reagent profiles, it's all good 🙂

donyorm02:08:19

(If you haven't already)

donyorm02:08:01

Not sure this sent, my app is being weird: >Sounds like you already know about this, but I forgot to open an issue, so I'll mention it here, tests seem to include a require from reageant even if the reagant profile isn't be used, and therefore the tests fail. I might be able to put a PR up with a fix in a bit.

yogthos13:08:40

@donyorm ah yeah I'll open an issue for that so we don't forget 🙂

yogthos13:08:05

ah I see you already got to it 🙂

yogthos13:08:26

@donyorm by the way do you want me to add you as a maintainer for luminus?

donyorm14:08:10

I guess that could be useful. In a couple of months I'll be starting my gap year so my activity is going to drop, so no promises what I will be able to do, but I'll do what I can.

yogthos00:08:59

yeah definitely no obligation there 🙂

donyorm03:08:14

Just accepted the invintation. Thanks!

donyorm05:08:12

So I haven't really done much in maintaining open source projects with others, mostly just worked on my own. Do non-owner maintainers usually do work in their own fork then pull request (and approve it themselves), or do they do work in a clone of the main repository in their own branch?

yogthos12:08:08

sorry just saw this 🙂 I'm not too picky either way

yogthos12:08:53

I usually tend to keep my own fork that I work on, and do prs

donyorm04:08:31

Ok sounds good.

d5p14:08:38

i’ve isolated my earlier uberjar compile issues a bit further, managed to fix the uberjar compile but turns out the exception is related to starting immutant via mount, i’m following essentially the same as luminus pattern , i.e mount/defstate http-server in my core ns , that starts immutant with http/run on a config sourced from cprop , with a handler function defined to return my routes

d5p14:08:52

at every stage it looks pretty much the same as luminus template , works fine in repl , fails as standalone jar

d5p14:08:08

with the same Caused by: java.nio.file.NoSuchFileException: whitespace = #'\s+'

d5p14:08:23

last component involved being clout , presume as it’s trying to build the routes

d5p14:08:55

any other thoughts on when using mount / immutant how to bind the handler? really scratching my head on this one

donyorm15:08:43

do you get the same result with a fresh luminus project?

d5p15:08:11

sigh alas no a fresh luminus template is fine , so bit by bit i’ve been going through , tbh by now about the only differences left are versions of the libs involved , i’d adapted my own more recent immutant ns for example (using latest 2.1.9)

d5p15:08:35

rolled versions back and same issue

d5p15:08:23

implemented same using integrant instead of mount , same exception , works fine with my older component based , might just have to give up at this point , no damn idea

donyorm16:08:53

That is the weirdest issue. I have no idea what to tell. Did you try just deleteing your maven repository and letting dependencies redownload? Just in case something weird got stuck in there

d5p16:08:03

yeh blew away .m2 and tried again , no luck

d5p16:08:16

got no hair left after tearing it all out with this issue ha

d5p16:08:56

i have this annoying feeling that it’s probably the dumbest little thing , but ahh well

donyorm16:08:21

it usually is, but I certainly don't see what it would be