Clojurians
#cljs-dev
<
2017-02-09
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes05:02:25

Sorted out a fix for a recent, sizeable self-hosted perf slowdown: http://dev.clojure.org/jira/browse/CLJS-1932

anmonteiro05:02:58

you can clearly see who's responsible for that perf regression :disappointed:

mfikes05:02:22

Hah! I suppose I wrote the original code in a loose way (to be fast), and what is a little odd is that the analyzer was being compiled to JS and then passed through advanced, thus leading to the need to revise the code to be more correct.

anmonteiro05:02:24

@mfikes how long does it take to require andare with that patch? what about self parity tests?

anmonteiro05:02:07

I'm not sure what you mean. I meant I caused that perf regression :stuck_out_tongue:

mfikes05:02:40

About 11 seconds. (Whereas previously it would take 42 seconds.) The self parity tests don’t seem to exhibit anything related to it.

mfikes05:02:52

Oh… what I meant is: That bit of code was ostensibly meant to only be used in self-hosted mode (being in the :cljs branch), and thus not suitable for use with :advanced. But I suppose the analyzer namespace gets pulled in when compiling Om server-side in advanced mode somehow.

mfikes05:02:53

I guess I’m saying that http://dev.clojure.org/jira/browse/CLJS-1794 is an odd ticket. But hey, it happens.