Clojurians
#cljs-dev
<
2017-02-10
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

bhauman15:02:31

Hmmm the cljs.repl :reader option appears to be a no-op with a conflicting relationship to :source-map-inline

dnolen15:02:20

@bhauman just looks like an oversight

dnolen15:02:13

cutting a bugfix release today - if there’s something you want let me know soon :slightly_smiling_face:

anmonteiro16:02:07

@dnolen: I'd love your thoughts on CLJS-1497

anmonteiro16:02:42

Or did you already leave a comment and I missed it?

bhauman16:02:24

@dnolen a (Thread/interrupted) test in the read-eval-print loop in the repl would be cool

dnolen16:02:50

@anmonteiro didn’t have a chance to look at that and I don’t think I will get to it today unfortunately

dnolen16:02:11

@bhauman come up with a patch that I can look at

bhauman16:02:20

dang :slightly_smiling_face:

dnolen16:02:27

also later this afternoon there’s going to be some new design pages

dnolen16:02:48

A) a simple way to handle singleton patterns w/ externs inference - probably won’t need much feedback

dnolen16:02:25

B) an outline for putting :node-deps into deps.cljs, and how to directly require CommonJS modules

dnolen16:02:02

feedback on the later will be especially welcome

bhauman16:02:32

@dnolen will this do for an example?

dnolen16:02:13

@bhauman I need to understand what problem this actually solving

dnolen16:02:30

unlikely that I’ll include this on my list of TODOs today though

bhauman16:02:38

thats cool

bhauman16:02:00

I'm encaspulating a repl in a thread and trying to kill it cleanly

bhauman16:02:31

closing the stream works for the most part

dnolen17:02:13

feeback welcome

dnolen17:02:30

feedback welcome ^

dnolen17:02:54

I think this won’t actually be very hard

dnolen17:02:04

feedback welcome

juhoteperi17:02:07

@dnolen I'm interested in supporting using CommonJS React as Maven dependency, so users don't need npm but can benefit from Closure optimizations for React

dnolen17:02:48

@juhoteperi yeah that’s a separate project that I’ve been thinking about too

dnolen17:02:14

it really needs to be broader then CommonJS though, any supported JS module format

dnolen17:02:28

it should be very hard though

dnolen17:02:46

copy the contents to some location, and then preprocess as usual

juhoteperi17:02:04

shouldn't be very hard? :smile:

juhoteperi17:02:31

Yeah, copying the files somewhere is what I've been thinking, if Closure won't support resolution from classpath

dnolen17:02:55

heh yeah shouldn’t be hard

dnolen17:02:20

@juhoteperi if you want to hack on that - be my guest - I’m all for it

juhoteperi17:02:48

And another problem is that if the package, includes all files from npm packages, some of them are possible meant only for Node and Closure can't read them

juhoteperi17:02:26

Maybe. Not completely sure of this though, as I have to first solve the first peroblem.

spinningtopsofdoom17:02:30

@dnolen can we use the Closure dependency_mode tooling to calculate the dependency graph?

dnolen17:02:47

@spinningtopsofdoom cannot

dnolen17:02:22

at least not directly

dnolen17:02:41

JSModuleGraph is a thing internally to Closure - we could maybe use that and replace module-deps

dnolen17:02:56

but’s it’s also not very important since it’s just switching out one thing for another

dnolen18:02:17

alright time to test master

dnolen18:02:29

heading out for lunch plan on cutting the release when I return

juhoteperi18:02:08

Works with Boot-cljs and local deps.cljs files now :slightly_smiling_face: