The best place is in that library itself

https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#exporting-and-importing-configuration

i saw that page, but on 1st skimming i missed the link to https://github.com/clj-kondo/config btw, this is the config i needed:

❯ cat ~/.config/clj-kondo/config.edn 
{:lint-as {; 
           clojure.test.check.properties/for-all clojure.core/let
           clojure.test.check.clojure-test/defspec clojure.core/def #_clj-kondo.lint-as/def-catch-all}}

Yes. I won't get my hopes up to get this config into a core library so maybe it's best to create another library with just that config which you can then add to your deps. I've been considering this for a while

Everytime i use org.httpkit client in calva i get “Unresolved var” for each function. Any idea on what i’m doing wrong?

org.httpkit.client/get
[url & [opts callback]]
[url & [callback]]
Issues an async HTTP GET request. See request for details.

Unresolved var: c/getclj-kondo(unresolved-var)

@U06GMV0B0 The issue is that these vars have been created via a custom macro. https://github.com/http-kit/http-kit/blob/cf1365167c5a2447f66ea2c0f4541a81114d2f74/src/org/httpkit/client.clj#L308 you can solve this by adding {:lint-as {org.httpkit.client/defreq clojure.core/def}} to your config and the restart your workspace

You need to re-lint your dependencies with this configuration in place

First of all, honored 🙂

I'm kind of now transitioning into the clojure ecosystem, could you explain what do you mean by re-linting?

It might also be a good idea to submit those configurations to the libraries themselves rather than just the templates. https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#exporting-and-importing-configuration See here for examples: https://github.com/clj-kondo/clj-kondo/discussions/1528

Re-linting just means: analyze the code again with clj-kondo

So on the command line for example:

clj-kondo --lint $(clojure -Spath) --dependencies

and then the garden namespace is seen again by clj-kondo, but this time with your new lint-as configuration

and then clj-kondo sees there is a var deg being defined

What also might help is blow the clj-kondo and lsp cache:

rm -rf .lsp/.cache
rm -rf .clj-kondo/.cache

and then restart your editor

Normally clojure-lsp should notice that the clj-kondo config has changed though

and re-lint the code automatically

I tried rm -rf .lsp .clj-kondo/* (except config.edn), running the clj-kondo command above, and again opening my editor

Still the same

can you check out the repo in another directory and open it there?

and is it possible to make a repro that I can download locally?

I believe it is!

Let me make you an oneliner

Back in 30 minutes

Generate a sample re-frame project using:

clojure -Tclj-new create :template re-frame :name sample.playground :output sample-playground :args '[+kondo +garden +routes "+10x"]'

{:lint-as {day8.re-frame.tracing/defn-traced clojure.core/defn
           day8.re-frame.tracing/fn-traced clojure.core/fn
           garden.def/defcssfn clojure.core/defn
           garden.def/defkeyframes clojure.core/def
           garden.def/defrule clojure.core/def
           garden.def/defstyles clojure.core/def
           garden.def/defstylesheet clojure.core/def
           spade.core/defglobal clojure.core/def
           spade.core/defclass clojure.core/def}
 :linters {:unresolved-symbol {:exclude [goog.DEBUG]}
           :unused-namespace {:exclude [cljs.repl]}
           :unused-referred-var {:exclude {cljs.repl [Error->map
                                                      apropos
                                                      dir
                                                      doc
                                                      error->str
                                                      ex-str
                                                      ex-triage
                                                      find-doc
                                                      print-doc
                                                      pst
                                                      source]}}}}

(Description for PoC practically lives in the above PR too)

Is it possible to prepare a repro which I can directly clone?

I don't have the clj-new alias readily available etc

Ofc, give me a minute

Here you go

https://github.com/agorgl/clj-kondo-poc

Thanks, I can repro now, checking into it

So if I go into the garden unit project itself and configure it, it does work correctly

Weird?

So when I add these deps:

$ cat deps.edn
{:deps {garden/garden {:mvn/version "1.3.10"}
        garden/garden-units {:mvn/version "1.0.0-RC2"}}}

and then run:

clj-kondo --lint $(clojure -Spath) --dependencies

and then run:

clj-kondo --lint src/clj_kondo/poc/styles.cljs

I see no warnings anymore

So this must be a problem with #CPABC1H61 and perhaps the shadow-cljs.edn deps / cc @UKFSJSM38

I don't see the garden-units library appear when doing this:

npx shadow-cljs classpath

could that be part of the issue?

probably, clojure-lsp just do programatically those clj-kondo calls you pasted

actually, clojure-lsp merges the classpath of both deps.edn + npx

the lsp-clojure-server-info should show the classpath

rm -rf .clj-kondo/.cache
clj-kondo --lint $(npx shadow-cljs classpath) --dependencies
clj-kondo --lint src/clj_kondo/poc/styles.cljs
src/clj_kondo/poc/styles.cljs:6:6: warning: Unsorted namespace: garden.units

(that unsorted warning comes from my home config)

So this sequence of commands seems to work

and that warning is expected, right?

yes

let me try the repro

and now I also get no warning when deleting the caches again and restarting the project

@U03PYN9FG77 Could it be that you just need to run npm install in this project first?

@U04V15CAJ what is the repro exactly on that repo?

@UKFSJSM38

src/clj_kondo/poc/styles.cljs:6:27: warning: Unresolved var: deg

but I can't repro that anymore

oh wait, maybe remove my deps.edn again

I can repro the warning. The project doesn't have any deps.edn right? so the only classpath option is from npx

Yes

and npx shadow-cljs classpath returns "~/.m2/repository/garden/garden/1.3.10/garden-1.3.10.jar , is the hook inside that version?

I can only repro it from a clean state

I tried fresh clone -> npm i -> clj-kondo --lint $(npx shadow-cljs classpath) --dependencies , opening my editor in styles.cljs and I can still repro it

I did the same without calling clj-kondo, just opening with clojure-lsp, which should end in the same

The fact that npx shadow-cljs classpath isn't showing this units library is weird right?

oh if the hook is inside that units library, that's the problem indeed.

garden itself doesn't seem to depend on that https://github.com/noprompt/garden/blob/master/project.clj

I only see garden on shadow-cljs.edn, shouldn't you include garden/garden-units as well?

Its a namespace within garden? https://github.com/noprompt/garden/blob/master/src/garden/units.cljc

I don't think it is a separate library / dependency

oh...

This is confusing since there is also a library with that namespace

but ok, that mystery is solved

so, no bugs anywhere right? :) just confusing deps/ns

Well there is still a confusing warning

AFAICS that happens because npx classpath doesn't include garden/garden-units which has the hook, only garden/garden

I also needed to add garden.units/defunit clojure.core/def to the config

What hook?

here https://github.com/agorgl/clj-kondo-poc/blob/master/.clj-kondo/config.edn

:lint-as

yeah, my bad, @U04V15CAJ is correct, adding that config is enough to solve since the problem is the defunit not being recognized as a macro that defines a var

Ah damn, I literally tried this before as I described at first message

In a clean clone works

Cache was not my friend

@U04V15CAJ any good tip to make defglobal Unused public var disappear too?

unused public var is @UKFSJSM38’s department ;)

@U03PYN9FG77 check https://clojure-lsp.io/settings/#clojure-lspunused-public-var

I just have to say

You are probably the best community I've ever encountered in my whole career

Thanks guys, you inspire me to become a Clojurist

Updated re-frame template fix PR, I hope the maintainer accepts it soon

https://github.com/day8/re-frame-template/pull/174/files

Have a nice day!

You too :)