Clojurians Log v2

Node docker image in CI: What does the directory look like of the project and are you executing it from the local directory of that project?

so I'm calling yarn nbb from the root of the project specifying the cwd in the yarn command eg: yarn --cwd test/e2e nbb run_tests.cljs . Doing this both locally and in CI

If I do this locally it works fine but only if I (load-file ...) as well as require

In CI i get could not find namespace ... regardless

all nbb script files are in test/e2e/ along with a package.json

Perhaps you could try:

( cd test/2e2 && yarn nbb run_tests.cljs )

I suspect there is something weird with yarn --cwd

even locally running from e2e directory I get could not find namespace

is this a public project so I can have a look?

or perhaps you can make a repro that is public

is nbb also installed in the package.json in the e2e directory?

https://github.com/larzeitlin/nbb-require-error-repro

you can get the error by running yarn install and then yarn nbb run_tests.cljs

thanks for having a look 🙏

It tries to load a namespace called e2econfig

which is not in the repo?

oh I see

namespace names should be called according to the directory structure you are in

oh yeah, sorry - i just pulled it out of the project. Can rename the root directory e2e and it should match up

What I mean is that when you are in directory $cwd and your namespace is called e2e.foobar , then the source should look like this: $cwd/e2e/foobar.cljs , not $cwd/foobar.cljs

But you can probably "fix" this by adding the parent directory to the classpath with nbb --classpath ..

Another issue is that load-file isn't "awaited" automatically

so you're running two things in parallel

So it's better to do this:

(ns e2e.run-tests
  (:require [nbb.core :refer [load-file await]]))

(require '[login-test])
(require '[map-test])

;; or:

(await (load-file "login_test.cljs"))
(await (load-file "map_test.cljs"))

I can make load-file auto-awaited though, please file an issue for that

Does this make sense?

Maybe nbb could support (:require ["./foo.cljs"]) as well ;) But that would be similar to load-file

makes sense. Just checking that the ns renames (and not running load-file in parallel) fixes things

all fixed! Many thanks @borkdude 🙏 will file an issue for load-file auto-await