@bozhidar do you think it's already possible to drop these legacy support statements?

(if (find-ns 'clojure.tools.nrepl)
  (do
    (require
     '[clojure.tools.nrepl.middleware.interruptible-eval :refer [*msg*]]
     '[clojure.tools.nrepl.middleware.session :as session]
     '[clojure.tools.nrepl.misc :refer [response-for]]
     '[clojure.tools.nrepl.transport :as transport])
    (import 'clojure.tools.nrepl.transport.Transport))
  (do
    (require
     '[nrepl.middleware.interruptible-eval :refer [*msg*]]
     '[nrepl.middleware.session :as session]
     '[nrepl.misc :refer [response-for]]
     '[nrepl.transport :as transport))
    (import 'nrepl.transport.Transport)))

Yeah, removing them is fine at this point.

@plexus @bozhidar could we not? I still use tools.nrepl for legacy reasons In fact I want to restore them in other places where they were dropped I know it sucks, but breaking changes suck just as much and hinder my transition from $forked_stuff to cider latest

the thing is that we are starting run into things that are now part of nrepl that aren't in clojure.tools.nrepl.

if it's too complicated I'm willing to move on ideally nrepl/nrepl would be simply a superset of tools.nrepl and would not complicate things much would undestand if that's not the case

couldn't you just use an older cider-nrepl in those projects?

it's fairly delicate, nrepl, Lein, cider, refactor-nrepl all have to play in concert I've had a frozen/forked setup for a couple years, it works well for me

there were some compat layers at some point, they were removed later

that wasn't fortunate IMO

yeah it was rough for a bit for sure. for a while i had to ensure to use lein 2.7.3 for a work project. it was not fun

ok I may not need to remove any more than were already removed previously 🙂 I somehow had managed to check out an ancient version

:) yeah honestly I thought that was removed everywhere already I have it in the radar to propose restoring it... if it doesn't break builds

I also thought I had removed it everywhere.

In general I don't think keeping it helps much, as most clients rely on some newer nREPL features are unlikely to work with tools.nrepl properly anyways.

I just saw I had deleted everything related to tools.nrepl in Jan 2019. 😄

For interested folks, we're pretty close to being able to upgrade a plain nREPL connection to cider-nrepl https://github.com/clojure-emacs/cider/issues/3037