This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-11-16
Channels
- # announcements (11)
- # beginners (184)
- # calva (91)
- # cider (68)
- # cljdoc (42)
- # cljs-dev (44)
- # clojure (228)
- # clojure-dev (1)
- # clojure-europe (3)
- # clojure-italy (4)
- # clojure-losangeles (6)
- # clojure-nl (9)
- # clojure-spec (73)
- # clojure-uk (19)
- # clojurescript (61)
- # core-async (6)
- # cursive (2)
- # datomic (11)
- # fulcro (28)
- # hyperfiddle (16)
- # leiningen (2)
- # luminus (3)
- # off-topic (19)
- # om-next (1)
- # re-frame (2)
- # reagent (12)
- # reitit (4)
- # ring-swagger (5)
- # shadow-cljs (14)
- # slack-help (6)
- # spacemacs (2)
- # tools-deps (40)
- # vim (15)
- # yada (4)
Isn't the indentation in clojure-mode a bit strange that any symbol with let
, when
or while
in it, not just in the beginning, is indented like a definition (suchas identifiers-match-when-street-name-contains-input-street-name
)
https://github.com/clojure-emacs/clojure-mode/blob/master/clojure-mode.el#L1307
I kind of would expect that they need to be in the beginning of the symbol (and their own word)
I was wondering if everyone agrees this is strange or that if there is a good reason for it
throw a PR up and see what comments you get. I haven't run into this bug but that's probably true for lots of people. this makes the code objectively more correct it would seem
>>> string-start',
bos', `bot'
matches the empty string, but only at the beginning of the
string being matched against.
I can hack myself some elisp but have to read up on the contribution guidelines and if there are any test setups
I also have some other work that I've hacked that may be useful for others, such as slightly improved font locking
hmm master fails make test
with
3 unexpected results:
FAILED clojure-find-ns-test
FAILED test-backtracking-let-when-while-forms
FAILED test-clojure-beginning-of-defun-function
I can investigate if it's not a know issue but that'll happen later, got to go for a bit
last commit is yours commit 71b32ee95e8ec99098e212cd0ec74cb4c002e8c6 Author: dan sutton <[email protected]> Date: Fri Oct 12 08:21:49 2018 -0500
Test clojure-find-ns-test condition: (ert-test-failed ((should (equal "foo-bar" (clojure-find-ns))) :form (equal "foo-bar" "^{:doc") :value nil :explanation (arrays-of-different-length 7 6 "foo-bar" "^{:doc" first-mismatch-at 0)))