Fork me on GitHub
#calva
<
2021-02-01
>
pez00:02:13

Dear Calva friends. Now I need help testing a rather central refactoring of the jack-in feature. This VSIX should work launching your projects, just like before if I haven’t messed something up. I’ve tested it on Mac and Windows on a lot of different test projects that I have. But even if I have quite a few of those, I still could have missed something. The whole reason for making the changes is for windows users with deps.edn projects to be able to jack-in more reliably. This VSIX bundles babashka, and uses it for jack-in of these projects. I’d especially appreciate @plexus’s help to see if this works better than the currently released Calva. https://10624-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.157-1000-deps-launcher-setting-d01ecb63.vsix

👍 1
pez00:02:26

Please consider testing and reporting your findings (wether good or bad) on the PR: https://github.com/BetterThanTomorrow/calva/pull/1004

clyfe07:02:36

Linux: • plain deps ok • plain lein ok • deps + fig main ok (that's all I have)

❤️ 1
clyfe07:02:16

Is there a way to avoid downloading the 69mb bb.exe binary on linux?

clyfe07:02:53

A post-install hook that downloads it off github on win only?

pez07:02:54

Maybe. I somehow doubt it.

pez12:02:16

@brandon.ringe did quite a lot of work to download the clojure-lsp jar dynamically, but had to retract because it made the setup too brittle. Or maybe I remember wrongly what that work was about.

bringe16:02:22

Well, if we move to using a graalvm compiled binary, it may be best to move back to that. It did require handling if the download fails, checking if the file exists, etc., and since everyone needed it, it seemed wise to just package it with Calva. But with graalvm binaries we need to run the appropriate one for the OS, and I think going back to that download strategy will be wise. (Discussed this with Eric. Lsp-mode downloads clojure-lsp I think). So maybe it would be wise to do with bb too :man-shrugging:

pez16:02:53

We can have that as a todo if we start bundling more bb:s. 😃

👌 1
bringe16:02:46

Incremental steps are good, indeed

pez17:02:18

Calva friends. Here’s another version of the Windows + deps.edn jack-in fixes: https://10629-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.157-1000-deps-launcher-setting-014dc881.vsix This one bundles deps.clj.jar instead of bb.exe. Trading 65 megabytes for a few seconds of startup time. Please help test it even if you are not using Windows, or not using deps.edn on Windows.

bringe18:02:15

Works fine on manjaro (arch) linux, using deps.edn

ivana17:02:50

Hello. Long time ago Calva-fmt was a separate plugin and can be installed independently from Calva. But nowadays they both are merged into one. Can you suggest me standalone formatter for Clojure in VSCode, which can format inside the current block only and by pressing customisable hotkey or Tab?

pez18:02:00

I think the easiest way here would be to compile calva-fmt to a VSIX and install that in vscode. https://github.com/BetterThanTomorrow/calva-fmt See the wiki tab for instructions on how to compile it. You’ll need vsce to package the vsix (`npm install-g vsce` will do it).

ivana18:02:20

Found out, that build version 0.0.37 (and below) works standalon. Thanks for such nice software!

❤️ 1
pez21:02:03

799 stars in two years. That is pretty amazing. https://starcharts.herokuapp.com/betterthantomorrow/calva

calva 4
hyper-clap 2
pez08:02:27

Thanks! Seems you are the only one who understood that part of the update. 😃

ericdallo21:02:10

Hey @pez and @brandon.ringe you may want to take a look on this later 🙂

clojure-lsp 1
metal 1
ericdallo21:02:26

I was talking with @brandon.ringe that if GraalVM binary really works, Calva would need to download the correct binary checking the OS

bringe21:02:16

Awesome stuff! Great work 🎉