I forgot - no it just prints the var's name: #'user/result

this has always been the case, hasn't it?

either way, it's the behavior of JVM Clojure as well:

$ clj
Clojure 1.11.0
user=> (require 'clojure.pprint)
nil
user=> (clojure.pprint/pprint (def x 10))
#'user/x

Thanks - I was quite sure that changed. Then something changed on my part.

Maybe in this release: https://github.com/babashka/babashka/blob/master/CHANGELOG.md#10169-2023-01-03

ah yes, before that, it printed: #<[email protected]: 10>

but some tools rely on what clojure JVM does, so it was changed

I guess you could make your own "spy" function for vars:

(defn spy [x]
  (clojure.pprint/pprint (if (var? x) @x x)))

(spy (def x 10))

or this hack:

user=> (defmethod pp/simple-dispatch clojure.lang.Var [v] (print "#var[") (print @v) (print "]"))
#object[clojure.lang.MultiFn 0x2ce45a7b "[email protected]"]
user=> (clojure.pprint/pprint (def x 10))
#var[10]

but I don't recommend putting that into a library, just for development

Thanks!

I would have expected

bb foo.clj -x foo/bar

bb -x foo/bar

I know I can just do

(ns foo)
(defn bar [_] (println 42))
(bar)

Just wondering if bb foo.clj -x foo/bar could be made to work as I expected, since it would lower the bar a bit for quick bash-replacement scripts.

does bb -m foo/bar the trick?

you need to add foo to the classpath, and then bb -x foo/bar

bb --classpath . -x foo/bar

you can also just do the top level side effecty thing with:

(when (= *file* (System/getProperty "babashka.file"))
  (bar ...))

Ah, makes sense 👍 So as soon as we're dealing with namespaces and such, I'll need to think in classpaths. I guess that makes sense

> top level side effecty thing Oh, that's a nice trick. Like python's if main__ or however it looks

and to install scripts that look more like projects (with multiple namespaces) use #C0400TZENE7 to install them as system-global scripts

for project-local tasks, use babashka tasks: https://book.babashka.org/#tasks

(let [original-report clojure.test/report]
        (with-redefs [clojure.test/report
                      (fn [event]
                        (if (and (= :error (:type event))
                                 (instance? Throwable (:actual event)))
                          (do
                            (println (:cause (Throwable->map (:actual event))))
                            (->> (:actual event)
                                 (sci/stacktrace)
                                 (sci/format-stacktrace)
                                 (run! println)))
                          (original-report event)))]
          (apply test/run-tests (filter contains-tests? nses))))

which gives me

Running tests in #{"test"}

Testing bblib.slack-test
Assert failed: false
bblib.slack/post            - /Users/user/pitch/pitch-app/projects/bblib/src/bblib/slack.clj:5:1
bblib.slack-test            - /Users/user/pitch/pitch-app/projects/bblib/test/bblib/slack_test.clj:15:7
clojure.core/with-redefs-fn - <built-in>
bblib.slack-test            - /Users/user/pitch/pitch-app/projects/bblib/test/bblib/slack_test.clj:14:5

Ran 1 tests containing 0 assertions.
0 failures, 0 errors.

Any more elegant ideas about how to do this?

(cc: @U054AT6KT)

I would say that is currently the most important thing to improve, but I think what you did there is how I'd solve it too in the short term

At the moment I have a vendored copy of cognitect-test-runner for this. If you can think of a way how I can share this better with other folks who might be looking for this, I'm curious

publish it as a library?

if the cognitect test runner is using clojure.stacktrace - perhaps we can tweak bb's builtin clojure.stacktrace to do what you're doing in the patch. this was something I wanted to try, but haven't yet

cognitect-test-runner is literally just 130 lines of wrapper for selecting individual tests from the CLI: https://github.com/cognitect-labs/test-runner/blob/master/src/cognitect/test_runner.clj

yep

It doesn't have any code for printing stacktraces, so it just does what clojure.test does - which does indeed involve clojure.stacktrace https://github.com/clojure/clojure/blob/master/src/clj/clojure/test.clj#L384-L395

https://clojurians.slack.com/archives/CLX41ASCS/p1677056819537969?thread_ts=1677053949.836649&cid=CLX41ASCS

feel like we have the same conversation ;)

If I read that correctly, you could also rebind stack/print-cause-trace to customize printing

hmm, maybe but not sure if that's possible since those pre-compiled function won't see the SCI var re-binding

Yeah, I brought it up again because this time I made some minor progress towards getting better output

I think just improving the built-in clojure.test is the best approach

Yeah that seems sensible

and possible also the stack/print-cause-trace

Out of curiosity, how would you patch clojure.test - do you bundle your own copy of the file?

yes, take a look at the babashka repo, it's in src/babashka/impl/clojure/test.clj

also there is one for clojure.stacktrace

if you want to run / develop babashka locally, I recommend doing that with a JVM as to not have to compile it to test every little change

clone the repo with --recursive, it's something people often forget

I have a dev alias so I can run dev bb from anywhere with: clj -M:babashka/dev

You're right btw - while I can rebind clojure.test/report, this doesn't work

(with-redefs [clojure.stacktrace/print-cause-trace (fn [& args] (prn :BOOM))]
          (apply test/run-tests (filter contains-tests? nses)))

Gently dipping my toe into implementing this If that's ok I'll dump my thoughts here stream-of-consciousness style (don't hesitate to skip this or tell me to shut up)

So there's already nice stack trace printing https://github.com/babashka/babashka/blob/master/src/babashka/impl/error_handler.clj#L99

bb -e "(defn f [] (assert false)) (f)"
----- Error --------------------------------------------------------------------
Type:     java.lang.AssertionError
Message:  Assert failed: false
Location: <expr>:1:28

----- Context ------------------------------------------------------------------
1: (defn f [] (assert false)) (f)
                              ^--- Assert failed: false

----- Stack trace --------------------------------------------------------------
user/f - <expr>:1:1
user   - <expr>:1:28

What I understand from the above discussion is this: There's already babashka.impl.clojure.stacktrace, which at the moment simply defers to clojure.stacktrace. So the most natural place to implement sci-aware stacktrace printing would be providing a customized print-stack-trace

exactly

As a result, clojure.test would pick up better stack traces, but you'd also get better (pst) from the repl

user=> (defn f [] (assert false))
#'user/f
user=> (f)
java.lang.AssertionError: Assert failed: false [at <repl>:2:1]
user=> (pst)
AssertionError Assert failed: false
	java.lang.reflect.Constructor.newInstance (Constructor.java:490)
	sci.impl.Reflector.invokeConstructor (Reflector.java:310)
	sci.impl.interop/invoke-constructor (interop.cljc:78)
	sci.impl.analyzer/analyze-new/reify--4282 (analyzer.cljc:1084)
	sci.impl.analyzer/analyze-throw/reify--4242 (analyzer.cljc:968)
	sci.impl.analyzer/return-if/reify--4197 (analyzer.cljc:850)
	sci.impl.fns/fun/arity-0--1153 (fns.cljc:106)
	sci.lang.Var (lang.cljc:198)
	sci.impl.analyzer/return-call/reify--4474 (analyzer.cljc:1402)
	sci.impl.interpreter/eval-form (interpreter.cljc:40)
	babashka.impl.repl/repl/fn--27449 (repl.clj:81)
	babashka.impl.clojure.main/repl/read-eval-print--12639 (main.clj:103)

should be yes

So how about this as a plan: • Figure out how to customize functions in babashka.impl.clojure.stacktrace • Write a new print-stack-trace to behave like babashka.impl.error-handler/print-stacktrace • Write a unit test for the new function • Write an integration test similar to https://github.com/babashka/babashka/blob/master/test/babashka/test_test.clj#L16 • Optionally, make babashka.impl.error-handler use the new print-stacktrace function to reduce code duplication

sounds like a plan :) one challenge is how to unify the JVM stackstrace stuff with SCI's

Right. Do you want to see ONLY the sci stacktrace or both?

the SCI stackstrace shows both I think already

Maybe the sci-error print-stacktrace should be a separate function

or maybe that's only the bb error handler, not sure

I'd say first make a prototype and don't worry about the details

with the goal of making clojure.test behave better

👍

Can't promise anything but will try

of course, no pressure

@UDXEK491P This is already possible today, but the interceptor namespace isn't available in bb itself. you can load it from source though when you include the http client library

you can provide :request options to the client when making one: https://github.com/babashka/http-client/blob/f6903b38abc30efe19dceb27d42b6fec196f73f5/src/babashka/http_client.clj#L15

and :interceptors is one of those options

it doesn't seem like they get used: https://github.com/babashka/http-client/blob/main/src/babashka/http_client/internal.clj#L200 i tried doing this in a client but didn't have luck

{:request {:interceptors [,,,]}

aha, hmm, let me check

would this work?

(or (:interceptors request-defaults)
    (:interceptors req)
    interceptors/default-interceptors)

ah I see, the request defaults are merged too late

this line should be moved one up: https://github.com/babashka/http-client/blob/f6903b38abc30efe19dceb27d42b6fec196f73f5/src/babashka/http_client/internal.clj#LL202-L202C57

ahhh yep, makes sense

are you using it from bb or from jvm?

jvm currently, but this library will be used for both bb scripts and jvm stuff

deps.edn or lein?

i use lein for most things except bb tasks

ok, let me look into fixing it and then release a fix

ty! no rush on cutting a release right away

@UDXEK491P published as v0.1.6

Try rlwrap bb

Ok, that works. Should I just create an alias for bb='rlwrap bb' then?

you're running the butlast release btw, 1.2.174 is the latest which has the newer http-client built-in

I don't recommend replacing bb with rlwrap bb as this may cause issues, but use a different alias like bbr or so

Ahh. But the cli app works! Lol

But I will upgrade

yeah, it works, just some minor improvements which may be nice to have, just in case :)

bbin is recommended for this

https://github.com/babashka/bbin

or you can distribute it as a normal deps.edn library, depends on the use case

deps.edn libraries can be used in bb in bb.edn

I'm running bbin install but am getting this error:

----- Error --------------------------------------------------------------------
Type:     clojure.lang.ExceptionInfo
Message:  Invalid script coordinates.
If you're trying to install from the filesystem, make sure the path actually exists.
Data:     {:script/lib "", :procurer :http, :artifact :unknown-artifact}
Location: /home/chase/.babashka/bbin/bin/bbin:629:11

----- Context ------------------------------------------------------------------
625:           [:local :dir] (install-deps-git-or-local cli-opts' summary)
626:           [:local :file] (install-local-script cli-opts')
627:           [:local :jar] (install-local-jar cli-opts')
628:           [:maven :jar] (install-deps-maven cli-opts')
629:           (throw (ex-info "Invalid script coordinates.\nIf you're trying to install from the filesystem, make sure the path actually exists."
               ^--- Invalid script coordinates.
If you're trying to install from the filesystem, make sure the path actually exists.
630:                           {:script/lib (:script/lib cli-opts')
631:                            :procurer procurer
632:                            :artifact artifact})))))))
633:
634: (defn uninstall [cli-opts]

----- Stack trace --------------------------------------------------------------
babashka.bbin.scripts  - /home/chase/.babashka/bbin/bin/bbin:629:11
babashka.bbin.cli/run  - /home/chase/.babashka/bbin/bin/bbin:657:5
babashka.bbin.cli/run  - /home/chase/.babashka/bbin/bin/bbin:654:1
babashka.bbin.cli      - /home/chase/.babashka/bbin/bin/bbin:671:10
babashka.bbin.cli/bbin - /home/chase/.babashka/bbin/bin/bbin:706:5
babashka.bbin.cli/bbin - /home/chase/.babashka/bbin/bin/bbin:703:1
babashka.bbin.cli      - /home/chase/.babashka/bbin/bin/bbin:709:3
clojure.core/apply     - <built-in>
babashka.bbin.cli      - /home/chase/.babashka/bbin/bin/bbin:713:3
babashka.bbin.cli      - /home/chase/.babashka/bbin/bin/bbin:711:1

Try: https://gist.githubusercontent.com/chase-lambert/c5533d8e8fbb71268a25e83ecf8e3cc6/raw/9cc7b4208f9bed2609f4736c4f469e1828273af5/chatgpt-cli.clj

@U0CLCL6T0 Perhaps we can support the non-raw link

@U9J50BY4C can you post an issue about that?

Sure.

So I tried the raw and got this:

{:coords
 #:bbin{:url
        ""}}

Did the raw link work for you?

did it work?

yes, you should now be able to execute chatgpt-cli if you added the bin dir to the path

It works!

see bbin install instructions

cool :)

you can also change the name with --as mychatgpt

so I'll throw this up in @announcements Any suggestions on how I should describe using this? Have them install bbin? Alternatively, they can just take the file from the gist and run it with bb?

yep, many bb users already know bbin, but just downloading it also works

you can also put some install instructions in the gist

oof, I forgot about this rlwrap issue. and it doesn't act quite like using bb to run this in the sense that I followed some other advice I got in another thread here to change my inputrc https://clojurians.slack.com/archives/C053AK3F9/p1677870509616049?thread_ts=1677868851.028919&cid=C053AK3F9

you can remove that if it doesn't work for you

I think rlwrap has gone through some changes, it may no longer be necessary

no it does work for me. but only when running clojure and bb. But I think if I wanted it to work for this new bbin install I would have to put

$if chatgpt-cli
    set enable-bracketed-paste off
$endif

And without using rlwrap my up key doesn't work

You can also do this:

(when (= *file* (System/getProperty "babashka.file"))
  (when-not (babashka.fs/windows?)
    (when-not (str/includes? (.get (.command (.info (java.lang.ProcessHandle/current)))) "rlwrap")
      (println "Relaunching with rlwrap for better readline support")
      (babashka.process/exec "rlwrap bb" (str *file*)))))

haven't tested it, but something like this

ahh, cool. I will bookmark that comment. For now just throwing in alias chat="rlwrap chatgpt-cli" works super fast. lol

that may be better ;)

If I start installing a ton of bb scripts I'll look into a better fix

thanks, this is awesome btw. Super quick and painless to convert over from my .clj file

Some more ideas for reading input from the console: https://rattlin.blog/bbgum.html gum is very cool, yet you will have a dependency that people have to install. There is also a library for bb for it, but shelling out to it should be easy as well. https://github.com/lispyclouds/bblgum

I'll check it out.

I filed that issue: https://github.com/babashka/bbin/issues/56

btw the rlwrap hack from above didn't work, this is a better version:

(require '[babashka.fs]
         '[babashka.process])

(defn read-loop []
  (while true
    (prn (read-line))))

(when (= *file* (System/getProperty "babashka.file"))
  (if-not (babashka.fs/windows?)
    (if-not (System/getenv "BB_RLWRAP")
      (do (println "Relaunching with rlwrap for better readline support")
          (babashka.process/shell {:extra-env {"BB_RLWRAP" "true"}}
                                  "rlwrap" "bb" (str *file*)))
      (read-loop))
    (read-loop)))

bookmarked, thanks again

Do these instructions look correct? https://gist.github.com/chase-lambert/c5533d8e8fbb71268a25e83ecf8e3cc6

yep!

sorry to borry you again @U04V15CAJ but I think adding those comments in messes up the script somehow. How should I put those comments? I get this error now if trying to just run it like ./chatgpt-cli

----- Error --------------------------------------------------------------------
Type:     java.lang.Exception
Message:  No reader function for tag You

Also, if I alter the gist and then run the bbin install ... again it fetches the new info right or is it a one install from the gist only?

it always fetches the new one

well it depends on what sha you give it of course

in clojure you write comments with:

;;

oh you use clojure comments, not bash comments!

of course, it's clojure :)

lol! Yeah I feel silly. It was the shebang at the top of the file that got me all discombobulated

:)