If I just do something like

(def my-query "fields @timestamp
  | filter foo=bar")

(sh (format "aws logs start-query --query-string %s" my-query))

you have the " " around $my_query in the bash code. that makes it a single arg

try (format "aws logs start-query --query-string '%s'" my-query)

Ah, (format "... --query-string \"%s\"" my-query) seems to do it. I have single-quotes in the "real" query. Thanks @U7ERLH6JX 🙏

another way to deal with this which is possibly safer is to use a vec: (sh ["aws" "logs" ... my-query])

I see now that the " doesn't really fix the issue with the quotes in the query.

I'll try the vector 👍

Yes! The vector works, no escaping needed! And it also makes the command easier to read, as I can spare the format, and do line breaks as I please 🙂

been bitten by these things way to often that i almost always use a vec here. youre also making life easier for the shell parser on the other side 😛

hehe, and we do want our scripts to go fast 😉

it is a fun little code we dont run when sending vecs: https://github.com/babashka/process/blob/master/src/babashka/process.cljc#L15-L62

That does look scary. And it didn't seem to do what I wanted 😄

it was doing it as expected i think. the bash code shouldve been equally confused

Just pass the args straight into sh without the vector

ah, the vector is even optional?

it's getting better and better.

its varargs

Btw I knew that Paulus would jump into the convo at some point when it was related to bash and escaping 😄

(sh foo bar baz)

Only the first arg is split on spaces

yeah the usecase for the vector is when programmatically building the cmd. something i do often

The vector is old (deprecated?) syntax AFAIK

Be free, skip the vec!

yep, its (apply sh args) now

I'm off vectors in a moment

First arg can optionally be a map with extra goodies

Btw can you call process/tokenize on the formatted string you had earlier? It should work and if not I’d like to have a bug report. Be sure to upgrade to the newest bb before trying

I'll try that @U04V15CAJ and report back here

Should work with the single quotes around the query that is

Pretty sure it'll work, just didn't know what I was looking for 🙂

Unless the query contains single quotes. In that case you need to wrap the query in escaped double quotes. It should work like in bash.

Right 👍 The query does contain single-quotes.

I think this is a bug:

(prn
 (babashka.process/tokenize "bb -e \"(require '[clojure.set])\""))

["bb" "-e" "(require [clojure.set])\""]

Might not be the same bug as yours but I discovered this while investigating

Hm, upgraded bb to latest, tried

(sh (format "aws logs ... --query-string \"%s\"" "query-with-single-quotes 'foo'"))

ah ok

yes, there has been a fix around this recently

https://github.com/babashka/process/commit/987a5fa1adb1695c5c65252e11404afe24968b8b

Oh, nice! I have no idea how to see what version I upgraded from in Arch Linux, but it does sound like it's related.

Looks like I was also hitting an old version:

user=> (require '[babashka.process :as p])
nil
user=> (p/tokenize "bb -e \"(require '[clojure.set])\"")
["bb" "-e" "(require '[clojure.set])"]

ah yes, I'm on an old laptop and this fixed it:

==> Upgrading borkdude/brew/babashka
  1.1.172 -> 1.1.173

I quite surely did have something that was relatively old. It printed the last expr to std-out, which I remember changed a while ago.

this changed in 1.1.171

A patch version with a breaking change 😱 😉

yes, I should have released 2.1.171 :P

well we dont really believe in major versions do we? 😛

I didn't want to create a python 2.7 controversy

rather major versions = expect upheaval

since python is brought up, the changes that are considered breaking there is almost equal to a bb rewrite. everything else is non-breaking

This was easier back in the MSDOS days. You'd just call getch()

... in Borland C

yes, in gnu c this also works. but Java isn't C

Maybe there is a cross platform way to shell out to a program which reads one character

Bash isn't usually available on windows but bash -c 'read -n1'

yeah, the bash case would be covered by the above, but Windows is the remaining problem

I think rebel readline accomplishes it using jLine. Bruce says it's the only way to do cross platform terminal manipulation

well, not the only way, since lanterna does it too, but one of the few things that seem to work in JVM world :)

I noticed the "single character" thing in lanterna relies on the above trick, but in Windows it relies on native hack stuff

@U11EL3P9U You can add the http dependncy and use require + :reload

ta 🙂

works a treat 🙂

You can do so using (System/getProperty "babashka.version")

(def where-am-i? #?(:bb :bb :clj :clj :cljs :cljs))