Fork me on GitHub
#babashka-sci-dev
<
2023-03-18
>
borkdude13:03:19

@rahul080327 I'm releasing 1.3.175 with a bunch of upgrades. It seemed good to do a release now to test the new docker stuff. In case anything goes wrong, we have some time to fix

lispyclouds13:03:16

Cool, I’m afk for the next 2 hours or so but should be okay I think

👍 2
lispyclouds13:03:15

Maybe I missed something like in kondo?

borkdude13:03:14

probably. yesterday I fixed this by logging into an ssh session of the same build and manually executing those things

borkdude13:03:49

but with this buildx stuff it's more complicated. I'll fix the docker script and we will do another release soon

borkdude13:03:45

pushed the fix (hopefully).

borkdude13:03:06

yes and 107

lispyclouds13:03:14

Yeah that’s it

lispyclouds13:03:34

Quite the thing to find on the phone 😅

borkdude14:03:18

Seems to be fixed now

borkdude14:03:08

Crap tar: Error opening archive: Unrecognized archive format Error: Failure while executing; /usr/bin/env tar --extract --no-same-owner --file /Users/borkdude/Library/Caches/Homebrew/downloads/f4e490c4d3421449aee3592f4fac5e527e979300cec0d22c3047fc80569207fe--babashka-1.3.175-macos-aarch64.tar.gz --directory /private/tmp/d20230318-44121-kbuktd exited with 1. Here's the output: tar: Error opening archive: Unrecognized archive format

borkdude14:03:23

something went wrong with the gzip upload or something

borkdude14:03:28

fucking hell :/

lispyclouds14:03:49

What changed there now?

borkdude14:03:03

maybe because I ran the same build twice

borkdude14:03:11

but this should not be a problem in theory

lispyclouds14:03:29

Maybe worth to download that and see what’s in it

borkdude14:03:00

normally around 20mb or so, unzipped 80mb or so

borkdude14:03:58

$ fileinfo babashka-1.3.175-linux-amd64-static.tar.gz
Error in pixReadHeader: unknown format in file babashka-1.3.175-linux-amd64-static.tar.gz
Error in writeImageFileInfo: failure to read header of babashka-1.3.175-linux-amd64-static.tar.gz

lispyclouds14:03:57

I can reach back by 45 mins or so. Something in the release script?

borkdude14:03:34

Maybe something in babashka.release-artifact

borkdude14:03:02

I'll just do another release for now

borkdude14:03:03

fucking hell

lispyclouds14:03:24

Yeah feels like it

lispyclouds14:03:05

Hopefully another release catches it. Good that we are seeing it soon

borkdude14:03:29

I reverted homebrew, and resources/BABASHKA_RELEASED_VERSION

borkdude14:03:40

also I unflagged the release as "latest" in github

borkdude14:03:30

crap, we got a case of "image bloat" again too

borkdude14:03:39

which explains the bloated zips

lispyclouds14:03:57

ah. back now. did the bad tars get resolved?

lispyclouds14:03:12

can check the release script

borkdude14:03:20

no they didn't get resolved, but the release is still there

lispyclouds14:03:29

taking a look

lispyclouds15:03:28

its a bad tar since the 1.2.175-SNAPSHOT

borkdude15:03:08

I changed to bb http client from bb curl

lispyclouds15:03:13

yeah trying to narrow down

lispyclouds15:03:24

also these default mime types

borkdude15:03:58

"tar"      "application/x-tar"

borkdude15:03:25

seems correct I'd say

borkdude15:03:38

I'll try locally uploading tar file and then download it again

borkdude15:03:44

to a fake release

lispyclouds15:03:50

yeah something seems weird

borkdude15:03:16

maybe a bug in bb http-client of some sort

borkdude15:03:22

I can repro the problem when uploading an image, it seems to be corrupted on download

lispyclouds15:03:30

and this is a manual upload and not via the release script right?

borkdude15:03:51

no, via gh-release-artifact

lispyclouds15:03:24

where is the tarring happening?

borkdude15:03:51

I don't think the tarring is the problem after discovering this

borkdude15:03:59

it's just a bug in http client somewhere, likely

borkdude15:03:33

I spotted it:

(instance? java.io.File body)
    (HttpRequest$BodyPublishers/ofString (slurp body))

lispyclouds15:03:36

maybe the content-type is off?

borkdude15:03:37

slurp on the file, this is bad ;)

lispyclouds15:03:53

esh, nice find

lispyclouds15:03:51

as for the ordered thing, we stick to the older one?

borkdude15:03:09

yes, see #CE1A21MPF

borkdude15:03:27

I already have something locally, this will be alright

lispyclouds15:03:54

yeah im just happy we are catching these things immediately 😅

borkdude15:03:32

yeah, rather now than during a more busy day

lispyclouds16:03:02

release looks good on linux amd64

borkdude16:03:31

yep here too, it was http-client

borkdude16:03:39

all good now