babashka-sci-dev

borkdude 2023-03-18T13:13:19.901069Z

@rahul080327 I'm releasing 1.3.175 with a bunch of upgrades. It seemed good to do a release now to test the new docker stuff. In case anything goes wrong, we have some time to fix

lispyclouds 2023-03-18T13:14:16.685639Z

Cool, I’m afk for the next 2 hours or so but should be okay I think

👍 1
borkdude 2023-03-18T13:28:40.580719Z

It seems the alpine images aren't there https://github.com/babashka/babashka/pkgs/container/babashka/versions

lispyclouds 2023-03-18T13:30:15.550709Z

Maybe I missed something like in kondo?

borkdude 2023-03-18T13:31:14.728809Z

probably. yesterday I fixed this by logging into an ssh session of the same build and manually executing those things

borkdude 2023-03-18T13:32:49.060719Z

but with this buildx stuff it's more complicated. I'll fix the docker script and we will do another release soon

borkdude 2023-03-18T13:33:45.817959Z

pushed the fix (hopefully).

lispyclouds 2023-03-18T13:33:51.021439Z

Ah line 109

borkdude 2023-03-18T13:34:06.206639Z

yes and 107

lispyclouds 2023-03-18T13:34:14.951559Z

Yeah that’s it

lispyclouds 2023-03-18T13:34:34.204869Z

Quite the thing to find on the phone 😅

borkdude 2023-03-18T14:13:18.364089Z

Seems to be fixed now

borkdude 2023-03-18T14:17:08.226209Z

Crap tar: Error opening archive: Unrecognized archive format Error: Failure while executing; /usr/bin/env tar --extract --no-same-owner --file /Users/borkdude/Library/Caches/Homebrew/downloads/f4e490c4d3421449aee3592f4fac5e527e979300cec0d22c3047fc80569207fe--babashka-1.3.175-macos-aarch64.tar.gz --directory /private/tmp/d20230318-44121-kbuktd exited with 1. Here's the output: tar: Error opening archive: Unrecognized archive format

borkdude 2023-03-18T14:17:23.543689Z

something went wrong with the gzip upload or something

borkdude 2023-03-18T14:17:28.070899Z

fucking hell :/

lispyclouds 2023-03-18T14:17:49.278549Z

What changed there now?

borkdude 2023-03-18T14:18:03.574649Z

maybe because I ran the same build twice

borkdude 2023-03-18T14:18:11.091969Z

but this should not be a problem in theory

lispyclouds 2023-03-18T14:18:29.165089Z

Maybe worth to download that and see what’s in it

borkdude 2023-03-18T14:18:46.513649Z

The sizes are very weird here: https://github.com/babashka/babashka/releases/tag/v1.3.175

borkdude 2023-03-18T14:19:00.384749Z

normally around 20mb or so, unzipped 80mb or so

borkdude 2023-03-18T14:19:58.466329Z

$ fileinfo babashka-1.3.175-linux-amd64-static.tar.gz
Error in pixReadHeader: unknown format in file babashka-1.3.175-linux-amd64-static.tar.gz
Error in writeImageFileInfo: failure to read header of babashka-1.3.175-linux-amd64-static.tar.gz

lispyclouds 2023-03-18T14:20:57.230219Z

I can reach back by 45 mins or so. Something in the release script?

borkdude 2023-03-18T14:21:34.023129Z

Maybe something in babashka.release-artifact

borkdude 2023-03-18T14:22:02.175829Z

I'll just do another release for now

borkdude 2023-03-18T14:22:03.937289Z

fucking hell

lispyclouds 2023-03-18T14:22:24.230309Z

Yeah feels like it

lispyclouds 2023-03-18T14:23:05.539929Z

Hopefully another release catches it. Good that we are seeing it soon

borkdude 2023-03-18T14:26:29.915359Z

I reverted homebrew, and resources/BABASHKA_RELEASED_VERSION

borkdude 2023-03-18T14:26:40.716989Z

also I unflagged the release as "latest" in github

borkdude 2023-03-18T14:32:30.765449Z

crap, we got a case of "image bloat" again too

borkdude 2023-03-18T14:32:35.222799Z

135773064

borkdude 2023-03-18T14:32:39.503269Z

which explains the bloated zips

borkdude 2023-03-18T14:35:16.207049Z

probably caused by "https://github.com/babashka/babashka/commit/e2f2e9ae4eb95fbca48bacd5bc48f57259ee7aeb"

borkdude 2023-03-18T14:35:19.803719Z

facepalm

lispyclouds 2023-03-18T14:54:57.896709Z

ah. back now. did the bad tars get resolved?

lispyclouds 2023-03-18T14:55:12.417229Z

can check the release script

borkdude 2023-03-18T14:57:20.717109Z

no they didn't get resolved, but the release is still there

lispyclouds 2023-03-18T14:58:29.267959Z

taking a look

lispyclouds 2023-03-18T15:05:28.555359Z

its a bad tar since the 1.2.175-SNAPSHOT

borkdude 2023-03-18T15:05:36.155379Z

bar tar?

borkdude 2023-03-18T15:05:39.417809Z

ah

borkdude 2023-03-18T15:06:57.637329Z

maybe related to https://github.com/borkdude/gh-release-artifact/commits/main

borkdude 2023-03-18T15:07:08.783459Z

I changed to bb http client from bb curl

lispyclouds 2023-03-18T15:07:13.199259Z

yeah trying to narrow down

lispyclouds 2023-03-18T15:07:24.842849Z

also these default mime types

borkdude 2023-03-18T15:08:58.036179Z

"tar"      "application/x-tar"

borkdude 2023-03-18T15:09:25.945299Z

seems correct I'd say

borkdude 2023-03-18T15:09:38.268679Z

I'll try locally uploading tar file and then download it again

borkdude 2023-03-18T15:09:44.072149Z

to a fake release

lispyclouds 2023-03-18T15:09:50.199889Z

yeah something seems weird

borkdude 2023-03-18T15:10:16.857299Z

maybe a bug in bb http-client of some sort

borkdude 2023-03-18T15:13:22.119189Z

I can repro the problem when uploading an image, it seems to be corrupted on download

lispyclouds 2023-03-18T15:13:29.025679Z

ah

lispyclouds 2023-03-18T15:14:30.654259Z

and this is a manual upload and not via the release script right?

borkdude 2023-03-18T15:14:51.437989Z

no, via gh-release-artifact

borkdude 2023-03-18T15:14:58.787409Z

in a REPL

lispyclouds 2023-03-18T15:15:24.186029Z

where is the tarring happening?

borkdude 2023-03-18T15:15:51.926169Z

I don't think the tarring is the problem after discovering this

borkdude 2023-03-18T15:15:59.930949Z

it's just a bug in http client somewhere, likely

borkdude 2023-03-18T15:16:33.593049Z

I spotted it:

(instance? java.io.File body)
    (HttpRequest$BodyPublishers/ofString (slurp body))

lispyclouds 2023-03-18T15:16:36.320299Z

maybe the content-type is off?

borkdude 2023-03-18T15:16:37.209349Z

slurp on the file, this is bad ;)

lispyclouds 2023-03-18T15:16:53.530529Z

esh, nice find

lispyclouds 2023-03-18T15:19:51.619019Z

as for the ordered thing, we stick to the older one?

borkdude 2023-03-18T15:20:09.312969Z

yes, see #clj-commons

borkdude 2023-03-18T15:20:27.073399Z

I already have something locally, this will be alright

lispyclouds 2023-03-18T15:20:54.878209Z

yeah im just happy we are catching these things immediately 😅

borkdude 2023-03-18T15:21:32.531159Z

yeah, rather now than during a more busy day

lispyclouds 2023-03-18T16:02:02.067219Z

release looks good on linux amd64

borkdude 2023-03-18T16:03:31.761749Z

yep here too, it was http-client

borkdude 2023-03-18T16:03:39.393179Z

all good now