babashka-sci-dev 2023-03-18

@rahul080327 I'm releasing 1.3.175 with a bunch of upgrades. It seemed good to do a release now to test the new docker stuff. In case anything goes wrong, we have some time to fix

Cool, I’m afk for the next 2 hours or so but should be okay I think

👍 1

Maybe I missed something like in kondo?

probably. yesterday I fixed this by logging into an ssh session of the same build and manually executing those things

but with this buildx stuff it's more complicated. I'll fix the docker script and we will do another release soon

pushed the fix (hopefully).

Ah line 109

yes and 107

Yeah that’s it

Quite the thing to find on the phone 😅

Seems to be fixed now

Crap tar: Error opening archive: Unrecognized archive format Error: Failure while executing; /usr/bin/env tar --extract --no-same-owner --file /Users/borkdude/Library/Caches/Homebrew/downloads/f4e490c4d3421449aee3592f4fac5e527e979300cec0d22c3047fc80569207fe--babashka-1.3.175-macos-aarch64.tar.gz --directory /private/tmp/d20230318-44121-kbuktd exited with 1. Here's the output: tar: Error opening archive: Unrecognized archive format

something went wrong with the gzip upload or something

fucking hell :/

What changed there now?

maybe because I ran the same build twice

but this should not be a problem in theory

Maybe worth to download that and see what’s in it

normally around 20mb or so, unzipped 80mb or so

$ fileinfo babashka-1.3.175-linux-amd64-static.tar.gz
Error in pixReadHeader: unknown format in file babashka-1.3.175-linux-amd64-static.tar.gz
Error in writeImageFileInfo: failure to read header of babashka-1.3.175-linux-amd64-static.tar.gz

I can reach back by 45 mins or so. Something in the release script?

Maybe something in babashka.release-artifact

I'll just do another release for now

fucking hell

Yeah feels like it

Hopefully another release catches it. Good that we are seeing it soon

I reverted homebrew, and resources/BABASHKA_RELEASED_VERSION

also I unflagged the release as "latest" in github

crap, we got a case of "image bloat" again too

which explains the bloated zips

ah. back now. did the bad tars get resolved?

can check the release script

no they didn't get resolved, but the release is still there

taking a look

its a bad tar since the 1.2.175-SNAPSHOT

I changed to bb http client from bb curl

yeah trying to narrow down

also these default mime types

"tar"      "application/x-tar"

seems correct I'd say

I'll try locally uploading tar file and then download it again

to a fake release

yeah something seems weird

maybe a bug in bb http-client of some sort

I can repro the problem when uploading an image, it seems to be corrupted on download

and this is a manual upload and not via the release script right?

no, via gh-release-artifact

where is the tarring happening?

I don't think the tarring is the problem after discovering this

it's just a bug in http client somewhere, likely

I spotted it:

(instance? java.io.File body)
    (HttpRequest$BodyPublishers/ofString (slurp body))

maybe the content-type is off?

slurp on the file, this is bad ;)

esh, nice find

as for the ordered thing, we stick to the older one?

yes, see #clj-commons

I already have something locally, this will be alright

yeah im just happy we are catching these things immediately 😅

yeah, rather now than during a more busy day

release looks good on linux amd64

yep here too, it was http-client

all good now