Fork me on GitHub
#untangled
<
2017-04-04
>
jonystorm00:04:19

I’m on master branch

jonystorm00:04:13

but I keep getting that error with the Id from server console

jonystorm00:04:52

I’m working with another person and he has the same issue

adambrosio00:04:24

maybe look at the network request payload to see what the server is sending the client?

adambrosio00:04:01

make sure you’ve cleared any browser cache

adambrosio00:04:13

not that this sounds like that kind of problem

tony.kay00:04:41

develop branch does look broken in general

tony.kay00:04:54

with advanced opt...prob a new client prob with optimizations

tony.kay00:04:04

works for me on develop with dev build

tony.kay00:04:15

but not production

jonystorm00:04:38

Ok, I’ll switch to develop and try that branch

tony.kay00:04:50

make sure you clean, and make sure you clean browser cache.

tony.kay00:04:56

using chrome?

tony.kay00:04:05

open console. click options

tony.kay00:04:12

find "disable cache while js console open"

tony.kay00:04:18

turn that on, and leave console open

tony.kay00:04:32

master should be working better than develop

tony.kay00:04:21

I gotta head out though. But I have verified that develop dev build worked for me. I build the support and dev build, then loaded it from the server port (which the server says when it starts). Nothing works right if you don't do that, though 😉

jonystorm00:04:49

Ok great, thank you very much for your prompt reply! I’ll try all that

tony.kay15:04:26

@jonystorm did you get it working?

jonystorm15:04:29

Nope, I thought it might be datomic edition, since I have pro, but I keep getting the same error message

tony.kay15:04:00

did you modify something? It should be using datomic free

jonystorm15:04:20

I added

:repositories {"" {:url ""
                                   :creds :gpg}}
so it finds it, and it does but when I run the app it’s the same result

tony.kay15:04:02

try running it stock. shouldn't matter, but it does work for me.

jonystorm15:04:37

I’ve just tried with develop branch and it’s the same result

tony.kay15:04:25

hm. That's really odd.

tony.kay15:04:52

so, your usage sequence is: 1. Start the regular app 2. Play with it...you see server accepting remote changes 3. Submit a support request via Help with a message 4. Copy the ID from the server log 5. Start the support viewer with that ID right? No pauses or restarts in the middle anywhere

tony.kay15:04:14

and you're building the support and dev targets via figwheel or something

mitchelkuijpers15:04:05

I see stuff like this in my app-state:

[:sale.issue/by-id 17592186045605] {:ui/fetch-state
Which is wrong I think this is fixed in 0.8.1 but this one is not released yet

jonystorm15:04:14

1. I run JVM_OPTS="-Ddev -Dtest -Dsupport" lein run -m clojure.main script/figwheel.clj` 2. once it finishes I run (on another console) lein run and when ready (go) 3. go to play with it, all changes ok 4. submit support request via help with message 5. copy the id from server log 6. open new browser tab on and get that error, no restarts no pauses

tony.kay15:04:41

@mitchelkuijpers try snapshot and let me know

mitchelkuijpers15:04:28

@tony.kay totally fixes it awesome

tony.kay15:04:03

@jonystorm Did you actually play with the app between 3 & 4

tony.kay15:04:24

If not, there are no steps saved...the iseq message is basically saying there is nothing to play back

tony.kay15:04:13

just did your exact steps and it works

jonystorm15:04:25

I added a couple of elements to the list and marked them as done

tony.kay15:04:36

At the figwheel prompt, maybe try (reset-autobuild) and make sure you've got a good build?

tony.kay15:04:00

Also, try a different browser. Could be a chrome plugin hosing you?

tony.kay15:04:23

I've seen ppl get screwed by certain dev cljs plugins

jonystorm15:04:25

I’ll try disabling all chrome plugins and also will try on a different browser

tony.kay16:04:59

Also, if you can show me (via the network tab) what is coming over the network when you try the support viewer, it would be potentially enlightening

tony.kay16:04:18

e.g. what is the response...it is transit+json, so it isn't pretty

mitchelkuijpers16:04:26

The snapshot seems to break something else related to loading markers

tony.kay16:04:02

Hm. bummer. let me know what you're seeing. The merge for ident-based remotes was wrong (and still has a problem). Could be related. If you can quantify that more, it would help

mitchelkuijpers16:04:22

Sure I am going home now but I will check it out tommorow

mitchelkuijpers16:04:38

It seems something todo with lazily-loaded

mitchelkuijpers16:04:04

But the other bug is fixed ^^

jonystorm16:04:46

I tried firefox and safari, disabling chrome plugins and it’s the same result.. regarding the response, on the support view I’m not getting any transit+json response, no requests to the api, the response to the support.html request is the html that loads the support.js

tony.kay16:04:09

you should see an /api request

tony.kay16:04:05

I cannot even guess what is going wrong for you. If you're not seeing an API request, then it means it isn't even figuring out the URI...that makes no sense

jonystorm16:04:14

my guess is that the error breaks execution so it doesn’t even try to send those api requests

tony.kay16:04:21

I'd like to see the tail of your network requests for support

jonystorm16:04:48

the requests in between are all js files

tony.kay16:04:04

Internal redirect???

tony.kay16:04:09

you have a proxy on your network?

tony.kay16:04:18

or some other network magic going on?

tony.kay16:04:42

you're getting a 307 from your localhost, which almost always means you've got some screwy OSX thing installed that is messing with localhost connections

tony.kay16:04:02

the 307 is not coming from your untangled server

jonystorm16:04:19

but I’ve just checked on firefox (where I’m getting the same error) and shows no internal redirect

jonystorm16:04:40

no proxies, nor network magic

jonystorm16:04:48

Testing on 2 other pc’s.. both same error, one of them has the 307 redirect, the other doesn’t. We will keep testing and share if we get it to run correctly. Thanks for the concern

tony.kay17:04:05

correct server port?

tony.kay17:04:44

PCs, not mac?

tony.kay17:04:26

the 307 should not be there...um, figwheel does try to connect on the generated js. I assume figwheel is still running

jonystorm17:04:30

right.. it is, no server errors, nor repl nor figwheel

jonystorm17:04:15

is there a way to check the databse on ram? to see if it is actually saved ?

jonystorm17:04:12

I imagine that if I get the “new support request id” it is because it’s returned by datomic and it is saved..

tony.kay17:04:59

the problem isn't with your server if you never ask the server

tony.kay17:04:07

according to your js console, you never get to that pt

tony.kay17:04:16

so debugging datomic is a waste of time at the moment

jonystorm17:04:42

right.. so the error is because of the missing api request, there’s something preventing it, and it’s not the error

tony.kay17:04:21

could you use quicktime to screen record, doing the following: 1. Do everything up to the support.html?id=1001 bit 2. Make sure network dev tool is open 3. scroll slowly through the list of resources loaded (so I can pause and look)

tony.kay17:04:56

then maybe use handbrake to drop the video to mp4 and 5fps (so it is small) and send it to me?

tony.kay17:04:20

or, we could spin up hangouts and look via screen sharing

tony.kay17:04:32

I have no more time to fiddle via text messages 🙂

tony.kay17:04:09

looks like a bug in 0.8.1-SNAPSHOT (load markers are messed up). Using an older version of client fixes it (todo mvc)

mitchelkuijpers17:04:42

Something goes wrong with the replacement of tempid's with follow-on reads after mutations

tony.kay17:04:57

which version?

mitchelkuijpers17:04:10

And I seem to have to add a extra key to refresh 0.8.1 to make sure a certain key is re-read after a load finishes

mitchelkuijpers17:04:32

But fixed it by adding a extra refresh key (so maybe a user erro)

mitchelkuijpers17:04:45

Ow lol this is not hipchat lol

tony.kay17:04:48

the latter might actually be due to us removing the forced root re-render

mitchelkuijpers17:04:01

Ah but it worked on 0.8.0

mitchelkuijpers17:04:10

I thought that was removed on 0.7.0

tony.kay17:04:11

which I thought we had already affected

tony.kay17:04:18

don't know about that one

tony.kay17:04:24

we didn't change more about refresh

mitchelkuijpers17:04:16

I'll see if I run into that some more

mitchelkuijpers17:04:47

I am looking into where the follow on read tempid-replacement might go wrong

mitchelkuijpers18:04:33

Hmm I am doing a mutation and then a separate df/load in one function maybe that is problem

tony.kay18:04:00

it's ok to have multiple mutations on a single thread execution

tony.kay18:04:08

but the mutations will be ordered before the loads

tony.kay18:04:10

in the net queue

tony.kay18:04:17

(assuming they are remote)

mitchelkuijpers18:04:17

Yeah that is what I thought

mitchelkuijpers18:04:56

This seems correct:

[2609.067s] [om.next] transacted '[(sale/link-issue {:issue-id "10103", :sale-id 17592186045629, :issue-link-id <#C06DT2YSY|om>/id["3fe6d980-7792-40a6-a6ea-796a13608702"], :funnel-id 17592186045568}) [:sale/by-id 17592186045629]], #uuid "a6f5904c-ccf2-40c0-a4f6-6019788c591d"
console.js:203  [2609.073s] [om.next] transacted '[(untangled/load {:remote :remote, :refresh [], :parallel false, :fallback nil, :marker true, :post-mutation nil, :without #{}, :post-mutation-params nil, :target nil, :query [{[:sale.issue/by-id <#C06DT2YSY|om>/id["3fe6d980-7792-40a6-a6ea-796a13608702"]] [:db/id :ui/fetch-state :sale.issue/issue-id {:sale.issue/funnel [:db/id]} :sale.issue/issue [:key {:fields [:issuetype :project :assignee :status :summary :priority]}]]}]}) :ui/loading-data], #uuid "b6ff70e3-b94d-416f-b5d3-a20bc812535f"
but the #om/id["3fe6d980-7792-40a6-a6ea-796a13608702"] never get's replaced while the remote sale/link-issue returns the correct response:
["^ ","~$sale/link-issue",["^ ","~:tempids",["~#cmap",[["~#om/id","~u3fe6d980-7792-40a6-a6ea-796a13608702"],17592186045645]]]]
So I think is a regression

tony.kay18:04:07

weird, but it worked in 0.8.0?

tony.kay18:04:28

cause that would be the networking upgrade not remapping over the network queue, and that was an earlier release I thought

mitchelkuijpers18:04:17

Yes it works in 0.8.0

mitchelkuijpers18:04:00

I'll try it once more just to be sure

tony.kay18:04:31

one of the patches was to add support for more custom options when creating client. I suspect something is broken there, and some plumbing isn't in place

mitchelkuijpers18:04:11

Yeah the sequential option might be related

mitchelkuijpers18:04:19

Almost restarted the app so I can be sure

mitchelkuijpers18:04:52

Yes it works on 0.8.0

tony.kay18:04:29

frustrating...I cannot reproduce the errors in todomvc no matter what I try, but they work on older version as well.

tony.kay18:04:43

I wonder if I've not released a SNAPSHOT to clojars and it is using my local update

tony.kay18:04:52

@jonystorm Any chance you could re-try with 0.8.1-SNAPSHOT. I suspect perhaps I didn't push an update to clojars? Same with @mitchelkuijpers

tony.kay18:04:00

I just pushed an update to be sure

tony.kay18:04:13

untangled-client-0.8.1-20170404.183406-8.jar

jonystorm18:04:03

Sure.. I’ll try right now

tony.kay18:04:01

do you customize migrate at all?

mitchelkuijpers18:04:35

:reconciler-options {:migrate nil
                               :pathopt false
                               :shared {;; Take absolute positioned elements in account for resizing
                                        :resizing/abs-pos-elems resizing/absolute-positioned-els-on-screen}}

jonystorm18:04:04

@tony.kay genius!!! it works, I’m on develop branch with 0.8.1-snapshot

jonystorm18:04:15

with the latest jar

jonystorm18:04:43

I owe you a couple of beers at least

tony.kay18:04:45

😕 I didn't do anything except re-push it

jonystorm18:04:36

still a good reason to drink 🍺

tony.kay18:04:25

seems that 0.8.1-SNAPSHOT still has some issues, though

tony.kay18:04:58

explains why I could not make it fail at least

tony.kay18:04:38

@mitchelkuijpers I'll dig into the other bits...the parts that seem broken are: 1. tempid rewrite on net queue (or possibly ordering?) 2. some kind of load marker thing

mitchelkuijpers18:04:55

The load marker thing seems to work (for my case)

mitchelkuijpers18:04:10

The ordering seems correct because the calls go in the right order

mitchelkuijpers18:04:23

The tempid rewrite seems to be my only issue

tony.kay18:04:23

oh, so only the tempid rewrite?

piotrek20:04:48

Hello! I am just getting started with untangled 🙂 Is https://github.com/untangled-web/untangled-template meant to be cloned to get started or is it somehow available as a lein template?

tony.kay20:04:49

we have a few too many resources to maintain, and lein templates are kind of pain with little gain

piotrek20:04:42

Thank you - it wasn’t clear to me

piotrek20:04:16

I also noticed there is bin/rename-project.sh. Is it intended to be run just after cloning?

tony.kay20:04:37

yes, though it required a weird version of sed...I think that has been fixed. Try it..worst case you have to use git to undo 🙂

tony.kay20:04:30

@mitchelkuijpers just out of curiosity: Do you have a custom network handler?

tony.kay20:04:10

We added an extra protocol, that if not implemented, caused network requests to go in parallel. I'm fixing the default back to sequential.

tony.kay20:04:21

I suspect that was the problem

tony.kay21:04:30

fixed and pushed to clojars as a new snapshot. see if that helps

tony.kay23:04:04

@gardnervickers @jasonjckn I think one of you were asking about load overwriting UI attributes. Found that problem and fixed in 0.8.1-SNAPSHOT