Clojurians
#lumo
<
2017-04-04
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

hlolli20:04:44

Probably a bad idea to build the non releases but it fails

SyntaxError: /home/hlolli/lumo/src/js/repl.js: Unexpected token, expected ) (301:15)

anmonteiro20:04:20

@hlolli shouldn’t fail

anmonteiro20:04:24

how are you building it?

hlolli20:04:21

With boot release command. Has been enough so far for me.

anmonteiro20:04:52

weird, did you run yarn?

anmonteiro20:04:59

I update dependencies now and then

hlolli20:04:08

Nope I try that...

anmonteiro20:04:24

next thing to try is upgrading your Node version maybe

anmonteiro20:04:25

all I can tell you is CI can build it, and so can I

hlolli20:04:54

Yarn did updated some deps, so five it few mintutes in the compilation and I can confirm it works...

hlolli20:04:38

A sorry many typeos, writing from my phone as slack is teasing me on my fedora....

hlolli20:04:33

now it stops here

WARN: Dropping unused variable exports [target/jszip.js:1,350]
/home/hlolli/lumo/node_modules/nexe/lib/exe.js:628
    const = Array.isArray(patchFns) ? patchFns : [patchFns]
          ^
SyntaxError: Unexpected token =
    at createScript (vm.js:53:10)
    at Object.runInThisContext (vm.js:95:10)
    at Module._compile (module.js:543:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/hlolli/lumo/node_modules/nexe/lib/index.js:1:80)
hmmm, only difference from my last compilation of lumo is actually that I updated from Node7.0 to Node7.8. But there's nothing wrong with lumo as of last successful compilation.

anmonteiro20:04:21

@hlolli yes, that’s expected now

anmonteiro20:04:25

working on fixing it right now!

hlolli20:04:52

Cool no stress :)

anmonteiro20:04:58

dumb yarn registry doesn’t know my latest commit

anmonteiro20:04:01

@hlolli pull again, and make sure to run:

rm -rf node_modules
yarn cache clean
yarn

anmonteiro20:04:32

@hlolli just built Lumo with current master and it worked again

anmonteiro20:04:42

waiting on CI to confirm it

anmonteiro21:04:19

also Lumo should be faster to startup on current master than 1.2.0 and 1.3.0 :tada:

hlolli21:04:35

Yes it looks to be going trough this time. More minutes passed so far.

anmonteiro21:04:39

there was a little perf regression caused by the inclusion of Google Closure Compiler JS

hlolli21:04:50

Nice nice :)

anmonteiro21:04:12

still not as fast as the first releases though. I bet I can make it a little faster :slightly_smiling_face:

anmonteiro21:04:44

happy to guide you through it if you are!

hlolli21:04:18

I'll have a go at it this week, good fruit to pick!