Has anyone made a spec for deps files that I could use to check validity?

It’s probably not hard to put together, but I wasn’t sure if anything already existed.

I think there are some in tools.deps

but I don't actually use them atm, so they might not be totally up to date (but I'd be happy to fix that)

Ok, I’ll check them out, thanks.

https://github.com/clojure/tools.deps.alpha/blob/master/src/main/clojure/clojure/tools/deps/alpha/specs.clj

I’d like to make at least a basic check that the file looks good before automatically trying to resolve it on file modification.

::deps-map in particular

You think ::deps-map might not be up to date?

just eyeballing it, it can't be too far off

I’m mostly interested validating the input, i.e. the deps file itself, not what t.d.a returns.

yeah that ::deps-map is a deps.edn file contents

Ah, ok.

I'm pretty sure I'm not using those specs in the mainline code right now so it's probably as good as any code you aren't using

Ok. I might have a go at converting this to my internal validator, which means I could show errors in the editor too.

As well as checking before trying to resolve automatically.

I don't see anything wrong in those specs. it's missing :sha and maybe one or two other things

Ok, if I see any obvious errors I’ll make a PR

Or a patch, rather.

or just tell me and I'll fix it :)

These days, when supplying a patch, does it have to be attached to a JIRA? Or can it be attached to http://ask.clojure.org?

Or that, yes 🙂

as someone that's supposed to be writing a talk right now, I'm in the market for sources of procrastination :)

Meh, you still have two weeks, what’s the issue?

This is probably more of a question for #spec, but I’m curious about this:

(s/def :local/coord (s/keys :req-un [:local/root] :opt-un [::path]))

Does that mean that :req-un can be used for namespaced keywords as long as the ns is explicitly specified?

Ah, no, ignore me - never mind.

Actually, no - the doc says: > These variants specify namespaced keys used to find their specification, but the map only checks for the unqualified version of the keys.

Does that mean that the spec would accept :root as well as :local/root?

ha, I was off checking many things and independently discovered this - it's a bug

I ran it on all the deps.edn in my system and that barfed at me in a few places

fixed and pushed

also added the required :sha attr for git coords

released as tda 0.7.549 if you need it

Great, thank you!

What is :resource-paths (leiningen) counterpart in Tools Deps?

Is it :paths?

@ahmed1hsn Yes - Deps doesn’t make a distinction.

to be more accurate, the jvm doesn't make a distinction, and thus neither does deps

I stopped making the distinction in my programs too. I realised it was rather arbitrary.

@ahmed1hsn You may find this blog post helpful https://corfield.org/blog/2018/04/18/all-the-paths/ since it talks about the terminology used by lein (and boot) and how that maps onto t.d.a.'s world.