Fork me on GitHub
#calva
<
2019-09-18
>
manas_marthi08:09:43

Hi all, today, I am getting 'calv.jackIn' command not found error. I uninstalled and reinstalled..

manas_marthi08:09:44

I think this happened after some java plugin installation.. I am still on VScode 1.30.. any idea how to look into the exact error stack?

manas_marthi08:09:13

I downloaded VSCODE 1.38.0 and it is launching repl fine.. I would like to dig into the issue though and see if I can uncover any issue

pez09:09:25

Maybe we have introduced a requirement on newer vscode... I know I did it at some point, but then I updated the manifest, and that was requiring 1.30.0, which is where you started there. Hmmm...

pez09:09:25

If you find the time to investigate, @manas.marthi, that would be great. This seems pretty serious, I would say.

Sasho10:09:16

Hello. Today, something interesting started to happen - when I start Jack-in, the moment I close the Repl window, the nREPL connect gets closed :thinking_face: Is there a way for me to prevent this?

Sasho10:09:42

Jacking in...
Hooking up nREPL sessions...
Connected session: clj
cljc files will use the clj REPL.
Jack-in done.
nREPL Connection was closed

Sasho11:09:23

It’s not the end of the world, but it’d be nice to be able to opt to the old behavior of being able to close the REPL window.

Sasho11:09:40

Hm, let me have a look.

Sasho11:09:39

Yep, I think that’s definitely it. As I said, it’s not a big deal for me. I don’t use the repl window, so: 1) until now - first thing to do, after jack-in is finished - close the repl window 2) now - move the repl window to the left group and simply leave it open I mean, in both cases, it’s not ideal, it’d be good to be able to opt-out of the window completely and not need to do any unnecessary actions every time the Jack-in starts, but this is a minor inconvenience, I can live with it. 🙂

pez11:09:53

I read the description a bit too fast there. I don't think we should close the the session because the repl window closes. Please file an issue about it.

Sasho11:09:24

O.K., will do… should I maybe try to do a PR for this 😳

pez11:09:00

That would be extra super cool.

Sasho11:09:27

O.K., will try, but not sure of the result… 🙂

pez11:09:08

Have a chat with the author of that PR 316, I think he can point you in the right direction.

Sasho12:09:17

I tagged him in the PR, maybe he can review it as well.

pez11:09:39

We merged that and released just a few days ago.

bringe18:09:17

@pez I think it would be nice if either A) Evaluations sent to the REPL window were pretty printed by default OR B) There were a setting that would allow pretty print when evaluating Using ctrl+enter in the repl window works, but I want evaluations sent to the REPL from my code file to also be pretty printed (without sending to the output/Calva says window, I know this works). I believe the Ultra plugin and also Cider pretty print by default in the REPL. Should I create a feature request?

Sasho06:09:42

Yep, that’d be nice!

pez08:09:33

Pretty printing by default makes total sense to me.

👍 1
bringe15:09:02

I'm going to take a stab at this soon if no one else does first. I've been working extra lately so my mind has been needing a break from coding after work, but I may be able to hit it in the next week

pez16:09:42

It is important to rest. I am speaking out of experience.

pez16:09:46

That said. If you pick this up, I think it should be solved such that there is an easy toggle of pretty printing. In the status bar and as a keyboard shortcut. Then evaluation read that toggle, regardless if it is inline or in the REPL window. And we then remove all pretty print commands.

👍 1
pez19:09:56

Create a feature request and a PR, i would say. 😀

✔️ 1
gerred23:09:25

issue coming in, it'd be awesome to be able to add nrebl.middlware in: https://github.com/RickMoynihan/nrebl.middleware