Fork me on GitHub
#sql
<
2020-06-29
>
antonmos16:06:00

@seancorfield it’s working!!

3
seancorfield16:06:53

Thank you for testing that @antonmos

seancorfield16:06:06

I'll cut 1.1.x later today!

πŸ‘ 3
❀️ 3
antonmos19:06:01

@seancorfield question about :auto-commit false in https://github.com/seancorfield/next-jdbc/blob/develop/doc/tips-and-tricks.md#streaming-result-sets-1 you say that it is required to stream results sets. We just tried it without that and it still seems to be working. Are there edge cases that are not apparent?

seancorfield19:06:24

Streaming results is inherently database-specific @antonmos but also hasn't changed recently.

seancorfield19:06:04

Mostly I wanted to check that the "final" version of fold-over-plan is still working for you.

seancorfield19:06:27

Some DBs require auto-commit false, some don't. Some require fetch-size set to a negative value, some to a positive value. Some require specific concurrency and/or cursor settings, some don't. JDBC is a giant mess in terms of implementation, even tho' it's great as an API in theory.

seancorfield19:06:50

(you should see all of the DB-specific conditionals scattered throughout the next.jdbc test suite!)

antonmos19:06:31

we are on postgres and it seems to be working without auto-commit

antonmos19:06:52

will let you know if it keeps working or blows up later πŸ™‚ Β―\(ツ)/Β―

seancorfield19:06:02

Interesting. Are you certain that you are indeed seeing streaming behavior?

seancorfield19:06:51

Also, which version of PG are you using? Perhaps they've improved how PG does streaming (or how the JDBC driver does streaming) in more recent versions that than recommendation was required for? As I've said a few times, I don't use PG (except in a very limited way for testing c.j.j and next.jdbc) so I have to rely on what PG users tell me has been needed for them to achieve the behavior they want...

seancorfield23:06:15

seancorfield/next.jdbc {:mvn/version "1.1.547"} -- the first 1.1 release! Supports multiple result sets, (parallel) foldable plan results, nested transaction control, find-by-keys enhancements (column selection, basic pagination), etc https://github.com/seancorfield/next-jdbc/releases/tag/v1.1.547 (not news to anyone here -- just making it official).

πŸŽ‰ 24
πŸ‘ 3
πŸ’― 3