Fork me on GitHub
#sql
<
2020-06-28
>
dharrigan06:06:11

I'm sure I can give it a spin today/tomorrow.

dharrigan13:06:28

Seems to work okay for me, my application is working as expected.

3
seancorfield18:06:29

I wouldn't expect any of the changes to break existing code but good to have it confirmed. I think @fabrao is the only person to try the multiple result sets feature so far and maybe @somedude314 could try the changes to find-by-keys...

seancorfield18:06:58

Maybe @antonmos could test the foldable stuff?

adam18:06:13

Will do

3
antonmos18:06:09

Yup, first thing tomorrow!

3
adam19:06:43

@seancorfield Worked flawlessly during manual testing:

user=> (sql/find-by-keys ds :user {:email ""} {:table-fn ansi :column-fn ansi :columns [:email]})
[#:user{:email ""}]
user=> (sql/find-by-keys ds :user {:email ""} {:table-fn ansi :column-fn ansi :columns [:email :role]})
[#:user{:email "", :role "parent"}]
user=> (sql/get-by-id ds :user #uuid"a6980a75-842f-4e4b-8328-fcf1166d69be" {:table-fn ansi :column-fn ansi :columns [:email :role]})
#:user{:email "", :role "parent"}
user=> (sql/get-by-id ds :user #uuid"a6980a75-842f-4e4b-8328-fcf1166d69be" {:table-fn ansi :column-fn ansi :columns [[:email :whaaat] :role]})
#:user{:whaaat "", :role "parent"}
user=> (sql/find-by-keys ds :user {:email ""} {:table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "", :role "parent"}]
user=> (sql/find-by-keys ds :user :all {:table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "", :role "teacher"} #:user{:cool "", :role "parent"}]
user=> (sql/find-by-keys ds :user :all {:fetch 1 :table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "", :role "teacher"}]
user=> (sql/find-by-keys ds :user :all {:offset 1 :fetch 1 :table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "", :role "parent"}]

adam19:06:15

You bet. Thanks for the amazing work.