Fork me on GitHub
#spacemacs
<
2020-01-21
>
kirill.salykin09:01:55

morning so some reason swoop is not working for me anymore - it does filter out rows (swoop-helm) anyone else also sees it? (dev branch)

practicalli-john11:01:38

Swoop is working okay for me (develop - last updated 31st December 2019) I call it from Symbol highlight transient state

kirill.salykin12:01:13

i just update today both spacemacs and packages

practicalli-john15:01:44

I can test on another laptop later tonight, I'll do a spacemacs and package update. Suspect its the package that has the bug. You can always roll back the packages if its stopping you being productive.

kirill.salykin15:01:39

not that urgent, just was currious if it may be my setup

kirill.salykin15:01:58

true, I can rollback, thanks

practicalli-john14:01:18

I updated Spacemacs to the latest develop , spacemacs template (no change in a while) and the latest packages. The way I use swoop seems fine. I tried it from symbol hightlight transient state and SPC s s and didnt notice any issues.

kirill.salykin14:01:45

It was fixed yesterday with helm-swoop package update

practicalli-john21:01:49

Those package maintainers are good at fixing things quickly, many thanks to them all.

kirill.salykin09:01:40

thanks for trying!

practicalli-john12:01:57

Based on your feedback, here and on GitHub, I have refactored the proposed keybinding changes to something I believe will be acceptable. I dont believe it affects more than a few keybindings in anyones workflow, whilst adding all the sesman tools. It also creates a nice separation between managing CIDER repls in , s (`s` is a defacto standard in Spacemacs across languages) and using the repl to evaluate , e I have dropped the , R menu and moved the send-to-repl functions to the , e evaluation menu, as after all these functions are sending code to the repl buffer to be evaluated. I have changed clearing the repl buffer to , s l which aligns with the keybinding for clearing terminal windows in general, so it should help with muscle memory. I appreciate your feedback on the GitHub repo and if acceptable, I will add the documentation and changelog entries and as the maintainers to merge the change. https://github.com/syl20bnr/spacemacs/pull/13140

👍 8
flefik14:01:56

Thanks for your hard work

didibus17:01:06

These do look better then initially proposed

didibus17:01:59

Will need to readjust my muscle memory, as I used most of the , s bindings, but I'm behind having more logical organization of the bindings in general

didibus17:01:19

The only binding I find weird is cider-refresh-nsx seems thats an evaluation to me

didibus17:01:27

I would have had it with , e

didibus17:01:44

Though I admit its a trickier one, cause it can be seen as a soft restart as well

didibus17:01:55

Overall looks good!

practicalli-john21:01:55

@U0K064KQV I guess if you use SPC p a to switch between source and test code in your projects, it should help move to , s a to toggle between REPL and source code. And of course a and s are next door, but I appreciate muscle memory takes time to adapt. I did think about adding something to the top level to switch, as there are a lot of free keys, so doing something like , s z but as I dont use the REPL buffer its hard to test. I agree with you about cider-refresh-ns I think this should also be in the evaluation menu. I would be happy to move this too if there is concensus, so probably , e x as the new cider-refresh-ns. Any more for or against?

👍 4
practicalli-john21:01:40

In the next few weeks I will have a look to see if there are any other missing keybindings.