Hello, does anybody have a good example of a GitHub action that runs tests in a shadow-cljs project? I have a :target like this:

{:target :node-test
 :output-to "tests.js"
 :ns-regexp "sitefox.*$"
 :autorun true}

shadow-cljs compile test && node tests.js

is there a macro-accessible variable or anything to know from the macro-expand-time/runtime whether the build was produced by "compile" vs "release"?

@zimablue (:shadow.build/mode &env) in the macro. :release for release builds, otherwise :dev

Thanks

Hi Thomas, just notifying you, that Closure seems to also not support ResizeObserver API. Added a couple more externs manually. Which leads me to think, what other APIs aren’t supported.

there is like 3 functions in that API? what would be missing?

https://github.com/google/closure-compiler/blob/master/externs/browser/wicg_resizeobserver.js

(included by default)

Hmmm, should I somehow notify Closure that I’m using this API in my JS file?

nope, should just work out of the box

This is my js file head

be careful with type info, if its incorrect that may lead to bugs

It’s part of the library. Then I lein install this lib, and use it in a different project. The latter project only started to work properly after I supplied borderBoxSize, inlineSize, blockSize to its externs/app.txt

maybe an old shadow-cljs / clojurescript version?

you tell me? 😛 the resizeobserver externs are fairly new

shadow version 2.15.3

2.15.3 - 2021-08-08

no idea when the externs where added

ok, thanks! will check hmm, but the same thing was with SVG

maybe I should try removing all type annotations

well, does it work with the newer version?

hmm, yes, seems to