you don't need them there for shadow-cljs

but Cursive does not read shadow-cljs.edn so it doesn't know about your dependencies

so if you want cursive to understand your code and not complain about code it cannot find then you need to copy the dependencies

just use pom.xml. you don't lose anything and it much easier to keep updated

ok, how can I go from pom to project.clj?

can I reference it somehow? cause copying is very tedious

I dont understand that question

you call shadow-cljs pom

and use the generated pom.xml in cursive to create your project

no project.clj at all

new project from existing sources -> pom.xml

if that doesn't do anything you may need to enable the maven plugin in cursive

Thanks, I tried and it seems to work. I guess it's ok to reimport the project everytime

you don't need to reimport

cursive will ask you to update if pom.xml changes, which you do by just calling shadow-cljs pom again

great! it seems to be importing now. not that I see much difference from the previous situation ) it was not complaining either. That's why I thought I only need to specify dependencies in the shadow edn and package json, not in project.clj

and it is not in some alias?

you can just use shadow-cljs run shadow.nrepl-debug 5000 5001 too of course. just used clj as an example

I get this:

$ shadow-cljs run shadow.nrepl-debug 5000 59546
shadow-cljs - config: /Users/pez/Projects/calva/shadow-cljs.edn  cli version: 2.8.64  node: v12.8.1
shadow-cljs - connected to server
[:server-ready 5000 59546]
[:client-accepted #object[java.net.Socket 0x196e2f92 "Socket[addr=/127.0.0.1,port=59714,localport=5000]"]]
[:msg :client 36]
[:msg :client 23]
[:msg :client 90]
[:msg :client 72]
[:msg :client 72]
[:msg :client 87]
[:msg :client 160]
[:msg :client 72]
[:msg :client 87]

$ npx shadow-cljs -d cider/piggieback:0.4.1 -d cider/cider-nrepl:0.22.1 watch :calva-lib :test
shadow-cljs - config: /Users/pez/Projects/calva/shadow-cljs.edn  cli version: 2.8.64  node: v12.8.1
shadow-cljs - server version: 2.8.64 running at 
shadow-cljs - nREPL server started on port 59546
shadow-cljs - watching build :calva-lib
shadow-cljs - watching build :test
[:calva-lib] Configuring build.
[:test] Configuring build.
[:test] Compiling ...
[:calva-lib] Compiling ...
[:calva-lib] Build completed. (83 files, 2 compiled, 0 warnings, 3,14s)
========= Running Tests =======================

Testing calva.fmt.editor-test

Testing calva.js-utils

Testing calva.fmt.formatter-test

Testing calva.fmt.util-test

Ran 21 tests containing 88 assertions.
0 failures, 0 errors.
===============================================
[:test] Build completed. (78 files, 1 compiled, 0 warnings, 4,10s)
[:msg :target 115]
[:msg :target 79]
[:msg :target 133]
[:msg :target 180897]
[:msg :target 133]
[:msg :target 133]
[:msg :target 1953]
[:msg :target 88]
[:msg :target 79]
[:msg :target 180897]
[:msg :target 97]
[:msg :target 112]
[:msg :target 79]
[:msg :target 269351]
[:msg :target 133]
[:msg :target 79]

Then when evaluating something in the CLJ session: this:

[:msg :client 129]
[:msg :client 237]

[:msg :target 98]
[:msg :target 197]
[:msg :target 80]

That was before starting the app. Starting that and evaluating *ns*, I get this:

[:msg :client 129]
[:msg :client 101]
[:msg :client 130]
[:msg :client 131]
[:msg :client 104]
[:msg :client 118]
[:msg :client 132]
[:msg :client 104]
[:msg :client 240]

[:msg :target 2530]
[:msg :target 530]
[:msg :target 150]
[:msg :target 299]
[:msg :target 350]
[:msg :target 391]
[:msg :target 150]
[:msg :target 350]
[:msg :target 113]
[:msg :target 80]

Evaluating the same thing in the CLJS session, I get this:

[:msg :client 129]
[:msg :client 130]
[:msg :client 131]
[:msg :client 132]
[:msg :client 240]

[:msg :target 57121]
[:msg :target 57121]
[:msg :target 57121]
[:msg :target 57121]
[:msg :target 113]
[:msg :target 80]

Let me know if I can do something more/else.

oh right. the output is written to target/nrepl-debug/*.log.edn

the stdout output is just about the size of the messages that were written

I thought it might be some codes that made sense to you. 😃

hmm why does it send so many clone requests?

cider-nrepl sure sends a lot of stuff over the wire

The clone requests are from Calva, though. There are three, right?

looks like it yes

So, one is to get a fresh clone to start from, then one clone for CLJ and one for CLJS.

;; ----------------------------------------
;; -- FROM  :client
;; ----------------------------------------
{:op "eval",
 :session "8f0aa4a2-fb9e-4419-b032-45736496c675",
 :code "nil",
 :id "9"}

why you eval'ing nil? was that for the test?

Not intentionally. Not sure what that is.

Which line?

nvm, found it.

I think that is something pretty recent. To get a message back with current namespace. (I could be wrong, haven’t checked yet.)

wonder why it is sending ns-list so much although nothing changed

doesn't matter regarding out problem though

but I think I know what happens

I don’t recall what ns.list is right now.

If you see more funny stuff there, that you think Calva is initiating, let me know.

can't find anything problematic your client is sending. other than that it may be sending too much

but I've seen nrepl stuff being rather "chatty" before so thats not uncommon

yeah, very chatty

There is traffic on hover and stuff, that I might have been spawning off, b/c I didn’t think of avoiding that when doing the test.

yeah. I think I just misunderstood how the nrepl middleware works

But whatever happens, visavi the problem, happens somewhere in the very start.

I thought if I tell it https://github.com/thheller/shadow-cljs/blob/92bb8076f6d1774bdbcf32dc8b0e14ce949c769a/src/main/shadow/cljs/devtools/server/nrepl.clj#L49

so which messages it should handle that it also only gets those

but I guess everything passes through it instead

so I just need to filter out the clone stuff so make sure shadow re-inits the session

(I think)

Makes some sense to me, even if not completely following. I have yet to sit down with nrepl and really try to grok it.

nrepl is seriously frustrating ... I fixed your problem but now cursive breaks ...

if you get a chance try 2.8.65. I think your issue should be fixed.

Now tried it. It is better, but not yet quite right. Now the first cljs clone is behaving, but the second one I clone from that clone is not a cljs session. In this log I did the following: 1. Connected Calva. This should: 1. Make a fresh clone, A 2. Clone the first CLJ session, B-CLJ, from A (used for backing the editors for .clj files) 3. Clone the second CLJ session, C-CLJ, from B-CLJ (used for the CLJ REPL prompt). 4. Clone the first CLJS session, D-CLJS, from B-CLJ (used for backing the editors for .cljs files) 5. Promote D-CLJS to a CLJS session. 6. Clone the second the second CLJS session, E-CLJS, from D-CLJS (used for the CLJS REPL prompt) Note that Calva does not promote E-CLJS, since it relies on it being cloned from the already promoted D-CLJS. What happens with 2.8.65 is that D-CLJS works as expected. But E-CLJS is still a CLJ session. So in the log file I continue to show this by: 1. Start the node-js app. 2. Evaluate a cljs/js thing in the editor (D-CLJS), this works as expected 3. Evaluate a clj think in the editor (D-CLJS), this also works as expected: bigdec does not exist. 4. Evaluate a cljs/js thing at the CLJS REPL prompt (E-CLJS), this does not work as expected. 5. Evaluate a clj thing at the CLJ REPL prompt (E-CLJS), this does not work as expected: bigdec exists. 6. For good measure I evaluate some clj things at the CLJ REPL prompt (B-CLJ), and they work as expected I hope I got all this right now…

And the log…

Didn’t want to upload as edn, trying zipped.

hmm yeah I didn't expect that someone would clone a CLJS session

since technically that makes no difference to not cloning it

since bindings don't really work in an async context the cloning can't actually create a session that is truly independent of the other one

but that should still work on the nrepl side of things. I'll think about it. Shouldn't be that hard to figure out

I think I do it that way because that is what I do with the CLJ sessions. I have never realized that it doesn’t really matter in the CLJS case. I can check for that and skip cloning for CLJS, in case it gets hairy for you to untangle it.

maybe I'm wrong but I don't think that it will work. you can maybe try by eval'ing 1 in one session and then 2 in the cloned one

then check *1 in the original and see what you get

if you get the correct 1 I'd be surprised

in shadow-cljs you wouldn't get 1 but maybe figwheel/piggieback does some magic I'm not aware of

I tested that immediately when you told me it would work like that. 😎 Mind blown.

and did it work like that? 😛

Yeah. Also in figwheel it works like that.

good to know

but yeah sessions aren't really possible in CLJS given the async nature (and lack of proper binding support)

Naturally, I’d like to keep as much of the semantics of cloning as I can, but this could be dealt with client side now that I have been enlightened. Just let me know what you decide to do with the issue, and I’ll adapt.

well clone should in effect to absolutely nothing

Yeah, and in .65 it does something. 😃

all state will be shared between the clones so there is really no point in cloning in the first place

I will need to think about how to actually allow cloning without going back to the previous behavior

Fair enough. It can actually be a bit confusing in the client code if it looks like it is a separate clone, when it isn’t.

I’ll fix that. So .65 will then be OK from a Calva perspective.

don't change too much ... I'm still in the great REPL internals overhaul ... there may be changes upcoming that'll actually make this work

Cool. Question. If I clone a new CLJ session for the second CLJS session, will that be a separate session? I’m guessing not, but as I’m not at the keyboard and can test it, you probably know without having to try 😃

I think CIDER also clones the cljs session: https://clojurians.slack.com/archives/C0617A8PQ/p1571620670136300