Fork me on GitHub
#shadow-cljs
<
2018-06-04
>
thheller21:06:08

same as whitespace as far as shadow is concerned

richiardiandrea21:06:26

@thheller maybe I am not familiar with shadow enough, but in vanilla Cljs bundling is never done, so deps are read from node_modules even in whitespace mode

richiardiandrea21:06:40

(talking about nodejs target)

richiardiandrea21:06:12

is shadow-cljs doing that instead?

thheller21:06:17

you can bundle node_modules files just fine with shadow

thheller21:06:40

BUT since node does not have the concept of an uberjar I do not recommend doing that

richiardiandrea21:06:03

well but that is the point of bundling, you produce one single .js file

thheller21:06:25

bundle isn't aware of npm either so it changes nothing in that regard

thheller21:06:45

just set :js-options {:js-provider :shadow} for your node build and it will bundle everything

richiardiandrea21:06:57

oh, I thought the GCC BUNDLE was for that

thheller21:06:57

it just fails immediately when you try to include native packages

richiardiandrea21:06:19

so you are saying that in any case it is a tool on top of GCC that needs to do that bundling

thheller21:06:33

is there no "bundle everything" solution in the node world?

thheller21:06:38

feels weird if there isn't

richiardiandrea21:06:47

yes there is, I use this, one sec

richiardiandrea21:06:17

browserify + uglify

richiardiandrea21:06:33

but I hoped to have everything in one tool 😄

thheller21:06:35

well like I said it WILL fail for any package with native code

thheller21:06:48

any other can technically work. just isn't built for it yet.

richiardiandrea21:06:01

kk no problem just inquiring 😉

thheller21:06:09

BUNDLE will do nothing as its just a lighter-weight version of WHITESPACE

👍 4
thheller21:06:17

ie. no transpile

thheller21:06:37

bit busy this week but open a ticket if you want a one-file option for node targets (similar to :browser)

thheller21:06:48

should be quite easy to add

richiardiandrea21:06:24

ok let me open an issue

wilkerlucio23:06:55

@thheller do you think it's possible to have REPL on karma ci builds?