Maybe the props are still =

logging (:tab @tab-content) showed it change

I could actually see the props data structure change in React DevTools. but React did not re-render the component

I can’t think of how two CLJS structures could be different but referentially the same

Check the compiled JS

I’m not sure if reagent implements it’s own shouldComponentUpdate and that might be at fault?

Is it an ratom or a reaction? In really complex apps I have seen amazing spooky action at a distance caused by a missing doall in completely unrelated parts of the application impacting reactions

just a ratom with a map {:tab "resources"}. gets swap!’d when a button is pressed

I’ll see if I can create a minimal repro

ooooooooo I have a hunch

(defn fragment
  [{:keys [id]}]
  (let [content-data (data/pull! :styx
                                 {:from "fragmentEdition" :id id}
                                 {:contentful/raw true})]
    (fn []
      (if-not (:loading @content-data)
        (render {:id id :content-data (:data @content-data)})
        [:div "Loading..."]))))

form-2 components strike again!

I think we've had a bug pop up a couple times a quarter related to form-2 components since we started using reagent

specifically, a dev doesn't repeat the props in the fn arguments. or doesn't remember to use a form-2 component

@lilactown yeah, your form-2 will bite you there

they are risky ones, have to be careful anytime you write one

and just for completeness to this question: > I’m not sure if reagent implements it’s own shouldComponentUpdate and that might be at fault? Reagent does implement shouldComponentUpdate for you, if you don’t (via a form-3 component). You can see it here: https://github.com/reagent-project/reagent/blob/v0.8.1/src/reagent/impl/component.cljs#L160 In a form-1 or 2 component, you wouldn’t have your own shouldComponentUpdate, so it’d be the (nil? f) branch of the cond.

@lilactown Ohhh I thought about form-2 components when you first said this but thought it the obvious thing so I never said anything 😞 I was using reagent/with-let instead of form-2 components, since it avoids this situation entirely…

haha. never underestimate the importance of saying the obvious in programming 😛

it’s hard too because this is someone else’s code on my team, so I’m playing the game of telephone with ya’ll

Hello, anyone know how I can make this work: <Sidebar.Pushable as={Segment}> What I have is:

(:require  [reagent.core :as r]
             [soda-ash.core :as sa])
...
  [sa/SidebarPushable {:as (r/as-element [sa/Segment])}]

Getting rid of the :as seems to work [sa/SidebarPushable (r/as-element [sa/Segment])]

@urbanslug Take a look at my comment in this issue: https://github.com/gadfly361/soda-ash/issues/10

Thanks @gadfly361

np!