hi, wonder if there is some examples of simulating multi-part form submission in testing pedestal application? eg. for testing file uploading. using pedestal's response-for macro.

Hi, is it possible to use function to build routes? I am trying this:

::http/routes (build-routes)

(defn build-routes
  (route/expand-routes #{[…]})) 

You're trying to use something as an interceptor
that isn't supported by the protocol; Perhaps you need to extend it? {:t nil, :type nil}

Is it good approach to build routes this way?

(def route-table
  #{["/"        :get  ['pages/root]]
    ["/sign-up" :get  ['pages/show-sign-up]]
    ["/sign-up" :post ['pages/sign-up]]
    ["/sign-in" :get  ['pages/show-sign-in]]
    ["/sign-in" :post ['pages/sign-in]]})


(def common-interceptors
  [http/html-body
   (using-component :db)
   (session {:store (cookie/cookie-store {:key "some-key12345678"})})])

(defn build-interceptors [verb interceptors]
  (let [interceptors (apply conj common-interceptors interceptors)]
    (if (= verb :get)
      interceptors
      (into [(body-params) keyword-params] interceptors))))

(defn browser-stack [[path verb interceptors]]
  [path verb (build-interceptors verb interceptors)])

(def routes
  (route/expand-routes (into #{} (map browser-stack route-table))))

@kirill.salykin there's nothing wrong with building your routes programmatically, although given your example, I'd build the route-table explicitly. IMO it would be easier to reason about

@kirill.salykin re: the error you're seeing, it may be due to how you refer to your handlers in the route table. Try using back-ticks instead of single quotes

the symbols need to be fully qualified

@ddeaguiar thanks for response Thought it makes no sens to repeat (body-params) etc

I see this error only when I am trying to implemet routes as function defn routes []

you can capture the common get interceptors in a var if you like

but that's a matter of taste

again, nothing wrong with programmatically building the routes

thanks!

@kirill.salykin also, you don't need to call route/expand-routes

pedestal will do it for me because set used?

yeah

so I suspect what's happening is that the verbose route map produced by expand routes is trying to be expanded again by Pedestal's internals

https://github.com/pedestal/pedestal/blob/master/route/src/io/pedestal/http/route.clj#L355

@kirill.salykin The message you're getting includes the value and type that Pedestal is trying to convert to an interceptor. The value is nil, so I suspect that your interceptor vector after browser-stack may have some issues. Can you print the value of the set after (into #{} (map browser-stack route-table))?

@mtnygard everything works I am facing issue if I am trying to use this:

(def routes
  (route/expand-routes (into #{} (map browser-stack route-table))))

(defn routes []
  (route/expand-routes (into #{} (map browser-stack route-table))))

Gotcha. Can you show me your service-map declaration?

(defn build-routes []
  (fn []
    (doseq [ns-sym (modified-namespaces)]
      (require ns-sym :reload))
    routes))

(def pedestal-config
  {::http/host "0.0.0.0"
   ::http/port 8080
   ::http/type :jetty
   ::http/join? true
   ::http/resource-path "/public"
   ::http/routes (build-routes)})

routes defined above

OK, so you're using build-routes to do auto refresh. When you use (defn routes ...), did you change the last expression in build-routes to be a call to the routes function?

yes I used this version

(defn build-routes []
  (fn []
    (doseq [ns-sym (modified-namespaces)]
      (require ns-sym :reload))
    (routes)))

It never hurts to check to obvious stuff. 🙂

Can you paste in the output of (build-routes) ?

of course

give me couple minutes

#object[blog$build_routes$fn__16210 0x4aa430d9 "[email protected]"]

Well that's not terribly helpful...

sorry 😞

How about the output of ((build-routes))?

clojure.lang.ExceptionInfo: You're trying to use something as an interceptor that isn't supported by the protocol; Perhaps you need to extend it?

ah.

So then the problem is definitely with the data structure being passed to expand-routes. Can you show me the output of (into #{} (map browser-stack route-table))

?

all route related declared in blog.web.routes when I calling (route) being in blog.web.routes this is returned:

({:path "/sign-in", :method :get, :path-re #"/\Qsign-in\E", :path-parts ["sign-in"], :interceptors [#Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/show-sign-in, :path-params []} {:path "/sign-in", :method :post, :path-re #"/\Qsign-in\E", :path-parts ["sign-in"], :interceptors [#Interceptor{:name :io.pedestal.http.body-params/body-params} #Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/sign-in, :path-params []} {:path "/sign-up", :method :post, :path-re #"/\Qsign-up\E", :path-parts ["sign-up"], :interceptors [#Interceptor{:name :io.pedestal.http.body-params/body-params} #Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/sign-up, :path-params []} {:path "/sign-up", :method :get, :path-re #"/\Qsign-up\E", :path-parts ["sign-up"], :interceptors [#Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/show-sign-up, :path-params []} {:path "/", :method :get, :path-re #"/\Q\E", :path-parts [""], :interceptors [#Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/root, :path-params []})

but, when invoking ((build-routes) being in blog namespace having this declaration [blog.web.routes :refer [routes] everything breaks

can it be some name overlap?

Maybe ... I'd need to see more of the code to know if that's the case.

There is something odd about those routes though.

I’ll push it to github a bit later

The last interceptor in each vector just says #Interceptor {:name}.

In your original table, were you using symbols or syntax-quoted names?

syntax quoted

With backticks?

let me recheck, i have a feeling that i’ve used just ‘ symbol

everything works

thanks

A backtick would make Pedestal pick up the interceptor name from the var name.

Oh, that fixed it?

Wow.

I am so sorry for this stupid error 😞

thanks a lot!

Kudos to @ddeaguiar. He spotted that a while ago.

but last-interceptor still has empty name

((build-routes))
({:path "/sign-up", :method :get, :path-re #"/\Qsign-up\E", :path-parts ["sign-up"], :interceptors [#Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/show-sign-up, :path-params []} {:path "/sign-up", :method :post, :path-re #"/\Qsign-up\E", :path-parts ["sign-up"], :interceptors [#Interceptor{:name :io.pedestal.http.body-params/body-params} #Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/sign-up, :path-params []} {:path "/sign-in", :method :post, :path-re #"/\Qsign-in\E", :path-parts ["sign-in"], :interceptors [#Interceptor{:name :io.pedestal.http.body-params/body-params} #Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/sign-in, :path-params []} {:path "/sign-in", :method :get, :path-re #"/\Qsign-in\E", :path-parts ["sign-in"], :interceptors [#Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/show-sign-in, :path-params []} {:path "/", :method :get, :path-re #"/\Q\E", :path-parts [""], :interceptors [#Interceptor{:name :io.pedestal.http/html-body} #Interceptor{:name :io.pedestal.http.ring-middlewares/session} #Interceptor{:name :blog.system.pedestal/using-component} #Interceptor{:name :io.pedestal.http.params/keyword-params} #Interceptor{:name }], :route-name :blog.web.pages/root, :path-params []})

hmm no they don't

oh wait

yes

that's the handler, though

yes

Ah, I see what's happening. `pages/root gets turned into the fully-qualified symbol. If you had that directly in your route table it would still be a symbol when Pedestal turned it into an interceptor.

Hrm, nevermind... I was on the wrong track there.

I'm glad it's working. I'd be happy to take a closer look at the interceptor name thing later on when you've posted the code.

sure, thanks a lot @ddeaguiar and @mtnygard

np 🙂