This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-08-04
Channels
- # beginners (90)
- # boot (5)
- # cider (89)
- # cljsrn (27)
- # clojure (33)
- # clojure-dev (2)
- # clojure-italy (3)
- # clojure-spec (35)
- # clojure-uk (17)
- # clojurescript (93)
- # code-reviews (1)
- # datascript (2)
- # datomic (14)
- # defnpodcast (6)
- # emacs (11)
- # figwheel (8)
- # figwheel-main (6)
- # hyperfiddle (14)
- # jobs-rus (1)
- # nrepl (3)
- # off-topic (13)
- # onyx (6)
- # reagent (6)
- # reitit (4)
- # shadow-cljs (110)
- # spacemacs (1)
- # tools-deps (10)
- # vim (17)
For the metrics
endpoint. onyx-peer-http-query currently sets the Content-Type
header to be the name of the serializer, defaulting to application/edn
. But as described in the link, I think it should be text/plain
. I was trying to send the metrics to Datadog, and it expected text/plain
. It's a one line change, and I can make a PR if you'd like. https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md
PR would be good. Definitely shouldn’t be edn. I only tested against prometheus and it worked OK so I didn’t realise.
I still owe you the :reduce
description. I’m a bit sick atm but I will get to it.
No hurry. I'm about to move, so going to be spotty for the next several days. Should I make the version 0.13.2.1?
Don’t touch the version, that’ll all be automated
As long as it’s off master, and still has a snapshot version, it’ll be fine.