Fork me on GitHub
#onyx
<
2018-08-04
>
sparkofreason23:08:14

For the metrics endpoint. onyx-peer-http-query currently sets the Content-Type header to be the name of the serializer, defaulting to application/edn. But as described in the link, I think it should be text/plain. I was trying to send the metrics to Datadog, and it expected text/plain. It's a one line change, and I can make a PR if you'd like. https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md

lucasbradstreet23:08:50

PR would be good. Definitely shouldn’t be edn. I only tested against prometheus and it worked OK so I didn’t realise.

lucasbradstreet23:08:32

I still owe you the :reduce description. I’m a bit sick atm but I will get to it.

sparkofreason23:08:12

No hurry. I'm about to move, so going to be spotty for the next several days. Should I make the version 0.13.2.1?

lucasbradstreet23:08:21

Don’t touch the version, that’ll all be automated

lucasbradstreet23:08:47

As long as it’s off master, and still has a snapshot version, it’ll be fine.