Will do

@dnolen: the parser impl cljc file needs a jvm exception case on this line: https://github.com/omcljs/om/blob/master/src/main/om/next/impl/parser.cljc#L87 This prevents one from requiring om.next.server currently with master.

Is there a way to force an entire page refresh/redraw on demand (e.g., on [debounced] resize event])?

I'm rendering a table and there are two unwelcome artifacts on resize (which currently merely incs a counter in app-state to force a render): a) if the vertical size is diminished, then the table remains its previously max height even though I'm rendering a [correct] fewer amount of rows in my render and b) if the vertical size is increased, then the newly added row(s) fall outside the existing 'tbody' presumably because React is trying to be smart/efficient and re-use what existing stuff it can. [This causes React to complain about the orphaned rows in the JS console].

I think calling om/add-root! with the same arguments you used to mount the app originally will force a render. I have figwheel remount the app on reload so that I see any UI changes immediately.

Yep, that did it! Thx!

@noonian: ^

@johanatan: keep an eye out because there'll soon be a way to do it explicitly (https://github.com/omcljs/om/issues/485 )

My read function is called two times with nil target and :remote one. I’m not using any remotes, should I somehow disable :remote target?

is there any performance implications because of this?

I don't think there's a way to disable that

it's just how Om works

if you don't have any remotes it won't do anything

not sure about performance implications but I'd say they're negligible

OK, thanks

@noonian: fixed

@artemyarulin: there will never be any way to control how many times read or mutate gets called

ack, thanks

Trying to understand how to work with remotes. As I understood my send functions has to call cb arguments with new data. And this cb then forwards this data to my merge function? Is it so?

Sorry for the dumb questions

@artemyarulin: Pretty much. merge goes on to call merge-tree, merge-idents and migrate

merge-tree adds the new data to your app state and migrate updates tempids

you probably don't have to provide a custom implementation for merge, just :merge-tree and maybe :migrate

Hm, :merge and :merge-tree are different?

I guess I need :merge-tree in order to merge the new data into the right place in state

hi, I need to use SVG's pattern, but Om doesn't have it (thought React supports it) -- how can I tweak Om to support it for my code ?

(btw, I know about Sablono, but since I need to compose pattern with existing Om code, I can't see a way to use it)

(because Sablono takes vectors but my Om code returns (svg #js {} (rect #js {} etc

@octo221: Try to call js/React.createElement directly

@artemyarulin: implementing :merge means you want to take complete control over how merging happens

it exists for custom storage users i.e. DataScript or something else

if all you want to do is control how the data gets merged using the default db, :merge-tree is enough

oh, cool, thanks. When do I need to use :merge-idents?

only if you think you need more control over that

in general you don’t need to do any of this if you’re using the default db

:merge-tree is probably the only one people will normally supply themselves

Cool, it’s clear for me. Thank you!

@octo221: https://github.com/omcljs/om/pull/522

@anmonteiro: thankyou so much!

How does the :keyfn of factory work? The examples have this line (def person (om/factory Person {:keyfn :name})), Do I basically give it a keyword in my map ?

@chedgren: any function works

it will be passed props

And it really helps if you add it to the right component. confusion lessened.

@dnolen: I may have found a bug in normalization, where recursive joins break other joins. I find it hard to describe. Here's input data, UI (root component omitted) and query result data: https://gist.github.com/Jannis/e16dac5628ca7a0ef229 - note how in the query result, :parent is broken (a list of idents instead of the actual parent data) in one place but not in the other. It may be intentional and perhaps I'm doing something wrong?

@jannis: it’s intentional we don’t follow recursions

Is there a way to make this kind of thing work (e.g. by making the read function smarter, which currently simply does {:value (om/db->tree query (get st key) st)})?

@jannis looking at your gist you obviously have a loop there

you don’t want stack overflow

so the question is … what is the behavior you want?

Yep, the data is a graph with cycles.

I guess I could treat it as a tree, drop :parent and instead pass the parent down to children in render.

That way they could refer to the parent but there would be no cycles in the data itself.

@jannis I could imagine adding support for using a number instead of ’… a la Datomic

to control the amount of recursion you get

I don’t know if that’s good enough for your usecase

There's no fixed limit for the depth in my case but in reality the data won't be deeper than 3-5 levels.

So yeah, that could help.

@jannis yes that’s what I mean

it’s not like you’re going to crawl the graph inside of a component

you just need to get far enough for it solve your problem

https://github.com/omcljs/om/issues/523

@jannis ^

not sure when I will get to it, recursion support pervades the code base

so not a simple change

I can imagine

I'll see if I can find ways to avoid the data loop short-term; there are a few other places where loops exist as well and it might not be as easy there

I’ll probably take a look at it after error support and routing support

The recusion limit support would solve all of those instantly though

Ok, sure

Am I correct in understanding that IDidUpdate does not get called after the initial render, only after subsequent renders?

correct

https://facebook.github.io/react/docs/component-specs.html#updating-componentdidupdate

Are there any 'events' that fire after every render, including the initial one?

I have read this document and so my suspicions are that there aren't

I was just wondering (hoping) I'd misinterpretted or something

componentDidMount for the initial render

componentDidUpdate for subsequent ones

Ok, thanks

is there any docs/examples about server streaming/server push?

@artemyarulin: not yet

just a placeholder in the wiki for now

😛

Yeah, I found it already

But is there API for that, does om support it already?

so is om.next going to be moving off of react entirely?

@tmtwd: can you rephrase?

is om.next going to be removing react from the framework?

O_o

not that I know of

I'm pretty sure Om will continue to be "A ClojureScript interface to Facebook's React."

@artemyarulin: I believe the API supports it already

personally, I haven't tried it yet, but I imagine it's not difficult

@tmtwd: no

but the coupling may be made loose enough to enable server side rendering

@anmonteiro: OK, I’ll check the source code

I don't think you'll find anything particular to that use case in Om's source

@artemyarulin: streaming isn’t any different from writing send minus the send part

you just merge! in stuff

As David keeps saying, Om doesn't do anything, it's up to us to make it do what we want

😛

So, just to clarify - my external code can change atom state and om-next will handle it?

@artemyarulin: no

I just said use merge!

it’s what Om Next uses itself

ahh, merge! function from om

so no you don’t want to do stuff like arbitrary swap! unless you’re prepared to handle all the boilerplate yourself

I’ve tried to consistently dog food Om Next’s API so that people can re-use this tuff

Got it, cool. It should be quite easy to implement

Nice, thanks!

Is there explanation about how om/tempid is supposed to be used with a datomic-based remote? So far, I've been trying to read om's source code to figure that out. But I am a slow and inept at source code reading.

@paxan: om/tempid doesn’t really have anything to do with Datomic it’s just a generic thing

is it meant to be playing well with mutation fns that on server side have :tempids { ... } produced by datomic?

nope

it’s just a generic thing like everything else

you will need to do the mapping automation bits yourself

but of course that doesn’t require much effort

so i need to implement mapping between tempids generated by om on client and resolved tempids produced by datomic, right?

yes

sorry, but I am not yet well versed in this system to grok this. I need some guidance

like om-datomic-tempids mapping for dummies

walk the transact entity data using a state atom wrapping a map, everytime you encounter an om tempid replace with a datomic tempid add this mapping to the state atom

transact

when you’re about to return the result back to the client, compute :tempids for each mutation using :result of each mutation

I think I understand now, @dnolen. something like that?

(let [conn ...
      state ...
      tid->otid (atom {})
      tx (clojure.walk/postwalk
          (pseudo-fn "when you see om/tempid x, replace with datomic/tempid y, and assoc! y->x to tid->otid map")
          state)]
  (let [datomic-result @(transact conn tx)]
    {;; ... result to be returned to client, and:
     :tempids (into {} (for [[tid id] (:tempids datomic-result)
                             :let [otid (@tid->otid tid)]
                             :when (some? otid)]
                         [otid id]))}))

@paxan: bingo

it is simple once it was explained well. Thank you!

@dnolen: can you send me a CA please?

@noonian: DM your email

Seeking some help with normalization. I tried adding very basic routing to the Components, Identity, and Normalization tutorial. I split :list/one and :list/two into two separate routes, and the root component only includes in its query the query for the current route. So, assuming we start with the route :route-1, the first query looks like [:session/route {:list/one [:name :points :age]}]. This renders the initial page just fine. But when you try to nav to :route-2, the :list/two data isn't normalized. This is because the data is only normalized when we first call add-root!, and at that time, Om doesn't know anything about the :list/two query. I do not know how to either 1) normalize all the data upfront while preventing over-fetching or 2) normalize the data again every time the root query changes. Here's a gist with the differences from the tutorial marked: https://gist.github.com/tomconnors/c1cceaae84fd059e37a3

@tomc: remember that everything in Om Next is presented a la carte

if you have a bunch client side information normalize this stuff yourself if the default behavior can’t take care of it for you

as much as possible Om Next exposes it’s own machinery as official API

use the lego blocks!

@dnolen: So in this situation I would just want to normalize the data myself before add-root!ing?

yep

Awesome, thank you.

if you supply an atom for :state Om Next won’t touch it

auto-normalization only occurs if you use plain data

or if you explicitly request :normalize true

ah, I see, I can just use tree->db along with a query that unionizes the queries of every possible route. cool!

yep

hey david have you poked around with how react native mounted components behave?

@johannjohann: if that’s directed at me, no I haven’t looked at React Native at all

and I don’t really have time for it to be honest

totes understand

but PRs are welcome to make it work, whatever the issues are I can’t imagine they are very significant

Om Next is already decoupled from React DOM more or less

there is a channel #C0E1SN0NM and people there discuss RN + Om-next sometimes

ouu very nice

here the example https://github.com/mfikes/auto-completion

@dnolen: I was able to get routing + normalization working based on your earlier advice, but now full-query is not working for any components other than the RootView. Looking at the indexer's :class-path->query map, the expected path (om-tutorial.core/RootView om-tutorial.core/RouteTwo om-tutorial.core/Person) is missing, but (om-tutorial.core/RootView om-tutorial.core/Person) is present. Why would the in-between component be missing?

indexing only considers components that actually have queries

if RouteTwo actually has a query and it wasn’t indexed correctly it’s because you’re doing something that’s not supported

i.e. stealing queries from another component or something like this

I am using a subquery that references another component's query like in the RootView of the tutorial. I basically just took the tutorial's RootView's query and divided it between two subcomponents.

will need more information

no idea what you are doing or how you are trying to do it

should be minimal and I can take a look