Clojurians
#lumo
<
2017-07-23
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro18:07:16

@moxaj just merged your Closure libs PR

anmonteiro18:07:43

the CLJS compiler also allows directory entries in :libs though, so I’m not going to close the issue just now

anmonteiro18:07:55

happy to take a patch for that as well

moxaj18:07:11

@anmonteiro wasn't aware of that, i'll take a look! Only files directly in that directory should be indexed, right?

anmonteiro18:07:35

@moxaj any file, even in deeply nested directories

anmonteiro18:07:49

goog.require declarations don’t need to match directory structure

anmonteiro18:07:18

goog.string is in goog/string/string.js

anmonteiro18:07:35

and it also provides goog.string.Unicode

anmonteiro18:07:45

even though there’s no Unicode folder or file :slightly_smiling_face:

anmonteiro19:07:44

@moxaj will review later, but you can’t js/require in src/cljs/snapshot/lumo/...

anmonteiro19:07:16

because of the snapshot, V8 doesn’t know what require is at that point

anmonteiro19:07:38

we probably have js/$$LUMO_GLOBALS.fs or something

anmonteiro19:07:42

check it out

moxaj19:07:02

oh, we have both fs and path

anmonteiro19:07:06

yeah, use that

anmonteiro19:07:16

I’ll take a more thorough look later