This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-07-23
Channels
- # beginners (20)
- # boot (7)
- # cider (115)
- # cljsrn (13)
- # clojars (1)
- # clojure (122)
- # clojure-italy (23)
- # clojure-spec (60)
- # clojurescript (74)
- # data-science (7)
- # datomic (26)
- # emacs (8)
- # graphql (1)
- # lumo (26)
- # music (1)
- # off-topic (1)
- # re-frame (9)
- # ring (3)
- # rum (1)
- # spacemacs (4)
- # uncomplicate (6)
- # vim (7)
@moxaj just merged your Closure libs PR
the CLJS compiler also allows directory entries in :libs
though, so I’m not going to close the issue just now
left a comment: https://github.com/anmonteiro/lumo/issues/210#issuecomment-317272589
happy to take a patch for that as well
@anmonteiro wasn't aware of that, i'll take a look! Only files directly in that directory should be indexed, right?
@moxaj any file, even in deeply nested directories
goog.require
declarations don’t need to match directory structure
e.g. https://github.com/google/closure-library/blob/master/closure/goog/string/string.js
goog.string
is in goog/string/string.js
and it also provides goog.string.Unicode
even though there’s no Unicode
folder or file 🙂
@moxaj if it helps: https://github.com/clojure/clojurescript/commit/df1351362e8456d5242793d20c56321392f07917
@moxaj will review later, but you can’t js/require
in src/cljs/snapshot/lumo/...
because of the snapshot, V8 doesn’t know what require
is at that point
we probably have js/$$LUMO_GLOBALS.fs
or something
check it out
yeah, use that
I’ll take a more thorough look later
thanks!