@moxaj just merged your Closure libs PR

the CLJS compiler also allows directory entries in :libs though, so I’m not going to close the issue just now

left a comment: https://github.com/anmonteiro/lumo/issues/210#issuecomment-317272589

happy to take a patch for that as well

@anmonteiro wasn't aware of that, i'll take a look! Only files directly in that directory should be indexed, right?

@moxaj any file, even in deeply nested directories

goog.require declarations don’t need to match directory structure

I see

e.g. https://github.com/google/closure-library/blob/master/closure/goog/string/string.js

goog.string is in goog/string/string.js

and it also provides goog.string.Unicode

even though there’s no Unicode folder or file 🙂

@moxaj if it helps: https://github.com/clojure/clojurescript/commit/df1351362e8456d5242793d20c56321392f07917

@anmonteiro https://github.com/anmonteiro/lumo/pull/215

@moxaj will review later, but you can’t js/require in src/cljs/snapshot/lumo/...

whoops

because of the snapshot, V8 doesn’t know what require is at that point

we probably have js/$$LUMO_GLOBALS.fs or something

check it out

https://github.com/anmonteiro/lumo/blob/master/src/js/cljs.js#L131-L132

oh, we have both fs and path

updating

yeah, use that

👍

I’ll take a more thorough look later

thanks!