Clojurians
#lumo
<
2017-07-01
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

futuro04:07:28

:arrow_up: context for any who'd like it

futuro04:07:31

I like the lightbulbg idea, though I'd probably pick a brighter color to present a lit lightbulb

futuro04:07:48

@anmonteiro are you looking for suggestions/feedback?

anmonteiro04:07:36

I think it's pretty much settled

anmonteiro04:07:00

I have a brighter yellow and a green option that I'm happy to share

futuro04:07:14

They'd be cool to see, for sure.

futuro04:07:52

If I mocked up some spins on the current version would that interest you?

futuro04:07:00

f.e., the CLJS green for the lightbulb, and the CLJS blue as the LUMO text color, with a white background

anmonteiro04:07:36

I don't think Lumo should necessarily have the ClojureScript colors

futuro04:07:56

Would you prefer an original color theme?

anmonteiro04:07:30

Yeah. I kinda like the current yellow but I'm open to see more options

futuro04:07:29

Is there anything you're hoping to impart with the logo, or mostly trying to find a design you find aesthetically appealing?

anmonteiro04:07:11

@futuro what do you think could be made better?

anmonteiro04:07:43

I really like the current logo & font, not really interested in much bikeshedding

futuro04:07:59

I think the solid black is kind of harsh, and making that white would be easier on the eyes and possibly make the yellow seem slightly brighter

futuro04:07:35

then a dark gray for the text so its readable, but matching the luminosity of the yellow

futuro04:07:33

I hear you on the bikeshedding, for sure

futuro04:07:48

that's a super rough mock, but gets close to what I'm talking about

futuro04:07:17

that has a background, whereas the first one has no bg (the file is misnamed)

richiardiandrea05:07:42

I like the bright version better, it is light after all

priornix16:07:58

Hi, just getting started on lumo. Any code examples that shows how to get node.js modules imported and working? I have tried looking at: https://anmonteiro.com/2017/03/requiring-node-js-modules-from-clojurescript-namespaces/ but lumo hangs upon running

lumo -c src build.cljs

anmonteiro16:07:29

@priornix that blogpost describes a functionality that is only available in regular ClojureScript, (not self-hosted or Lumo)

anmonteiro17:07:49

You can require Node.js modules in Lumo like this:

$ npm install my-module
$ lumo
cljs.user=> (js/require "my-module")

priornix17:07:58

I see, the best example I've seen is this: https://gist.github.com/yogthos/d9d2324016f62d151c9843bdac3c0f23#file-gallery-cljs but the example from @yogthos doesn't use any external nodejs libraries

anmonteiro17:07:45

Because Lumo is basically Node with a thin CLJS layer, NPM modules work out of the box :upside_down_face:

priornix17:07:17

Hmm, so how do I require the module from inside a lumo script?

priornix17:07:32

I'm trying this now

(ns foobar.bar
  (:require [cljs.nodejs :as node]))

(defonce lp (js/require "left-pad"))
(defonce lp2 (node/require "left-pad"))

priornix17:07:50

I've installed the left-pad library using npm install left-pad

anmonteiro17:07:17

Yeah so that should work

priornix17:07:01

Ah right, got it now, thanks. Guess it was a bug in my reference

moxaj17:07:47

@anmonteiro re my data readers patch, some tests fail with TypeError: $$LUMO_GLOBALS.loadUpstreamDataReaders is not a function. But as far as I can tell, I've exposed it the same way as $$LUMO_GLOBALS.loadUpstreamForeignLibs

moxaj17:07:41

so i'm kind of lost :confused:

anmonteiro17:07:53

@moxaj I'll have a look later

priornix17:07:26

Just a quick question, so as of now, we can't require the node.js modules using (:require) but instead it has to be either (js/require) or (node/require), right?

anmonteiro17:07:52

Some failures are a bit intriguing though

moxaj17:07:57

with the fixed text fixtures, i'm passing tests now, so those were connected

moxaj17:07:58

also, may I use (constantly {}) in the fixture as my loadUpstreamDataReaders? Or should I use the real one?

priornix17:07:56

@anmonteiro Am I right? ie: the (:require) syntax isn't supported in lumo now for node.js modules

anmonteiro17:07:23

@moxaj you can’t use the JS version because that won’t be present when we run CLJS tests. (constantly {}) looks OK to me

anmonteiro17:07:30

@priornix that’s right