https://github.com/anmonteiro/lumo/pull/43

https://github.com/anmonteiro/lumo/pull/43

⬆️ context for any who'd like it

I like the lightbulbg idea, though I'd probably pick a brighter color to present a lit lightbulb

@anmonteiro are you looking for suggestions/feedback?

I think it's pretty much settled

I have a brighter yellow and a green option that I'm happy to share

They'd be cool to see, for sure.

If I mocked up some spins on the current version would that interest you?

f.e., the CLJS green for the lightbulb, and the CLJS blue as the LUMO text color, with a white background

I don't think Lumo should necessarily have the ClojureScript colors

Would you prefer an original color theme?

Yeah. I kinda like the current yellow but I'm open to see more options

Is there anything you're hoping to impart with the logo, or mostly trying to find a design you find aesthetically appealing?

@futuro what do you think could be made better?

I really like the current logo & font, not really interested in much bikeshedding

I think the solid black is kind of harsh, and making that white would be easier on the eyes and possibly make the yellow seem slightly brighter

then a dark gray for the text so its readable, but matching the luminosity of the yellow

I hear you on the bikeshedding, for sure

that's a super rough mock, but gets close to what I'm talking about

that has a background, whereas the first one has no bg (the file is misnamed)

I like the bright version better, it is light after all

Hi, just getting started on lumo. Any code examples that shows how to get node.js modules imported and working? I have tried looking at: https://anmonteiro.com/2017/03/requiring-node-js-modules-from-clojurescript-namespaces/ but lumo hangs upon running

lumo -c src build.cljs

@priornix that blogpost describes a functionality that is only available in regular ClojureScript, (not self-hosted or Lumo)

You can require Node.js modules in Lumo like this:

$ npm install my-module
$ lumo
cljs.user=> (js/require "my-module")

I see, the best example I've seen is this: https://gist.github.com/yogthos/d9d2324016f62d151c9843bdac3c0f23#file-gallery-cljs but the example from @yogthos doesn't use any external nodejs libraries

Because Lumo is basically Node with a thin CLJS layer, NPM modules work out of the box 🙃

Hmm, so how do I require the module from inside a lumo script?

I'm trying this now

(ns foobar.bar
  (:require [cljs.nodejs :as node]))

(defonce lp (js/require "left-pad"))
(defonce lp2 (node/require "left-pad"))

I've installed the left-pad library using npm install left-pad

Yeah so that should work

Ah right, got it now, thanks. Guess it was a bug in my reference

@anmonteiro re my data readers patch, some tests fail with TypeError: $$LUMO_GLOBALS.loadUpstreamDataReaders is not a function. But as far as I can tell, I've exposed it the same way as $$LUMO_GLOBALS.loadUpstreamForeignLibs

so i'm kind of lost 😕

@moxaj I'll have a look later

thanks!

Just a quick question, so as of now, we can't require the node.js modules using (:require) but instead it has to be either (js/require) or (node/require), right?

@moxaj you may have to tweak test fixtures here https://github.com/anmonteiro/lumo/blob/master/test/lumo/test_util.cljs#L9

Some failures are a bit intriguing though

with the fixed text fixtures, i'm passing tests now, so those were connected

also, may I use (constantly {}) in the fixture as my loadUpstreamDataReaders? Or should I use the real one?

@anmonteiro Am I right? ie: the (:require) syntax isn't supported in lumo now for node.js modules

@moxaj you can’t use the JS version because that won’t be present when we run CLJS tests. (constantly {}) looks OK to me

@priornix that’s right