Clojurians
#lumo
<
2017-07-02
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro03:07:20

@moxaj merged your PR. if you’re up for it, the next step is adding this support in lumo.closure

anmonteiro03:07:39

I think you had something like that working already if I’m not mistaken

anmonteiro03:07:48

or it might just be the case that it works out of the box

anmonteiro04:07:04

:slightly_smiling_face:

futuro04:07:59

I'm so glad to finally get that merged; it's been a fair number of months in the making!

anmonteiro04:07:21

yeah, I’m excited. It’s a significant feature

anmonteiro04:07:52

if you’re on a mac you can probably get a build of the master checkout if you run brew install --HEAD lumo

anmonteiro04:07:18

not like you don’t know what it does :wink:

futuro04:07:31

ooo, neat; I'm gonna do that tomorrow at work (where I've got a mac. it's all Linux at home :))

moxaj11:07:39

trying to use lumo to build some source files, but I get EINVAL: invalid argument, utime '<...>\out\cljs\core.cljs'

moxaj11:07:42

stacktrace is

Object.fs.utimesSync (fs.cljs:1235:11)
         (Object.lumo$util$set_last_modified)
         Function.lumo.closure.jar_file_to_disk.cljs$core$IFn$_invoke$arity$3 (evalmachine.<anonymous>:1589:11)
         (Object.lumo$closure$compile_from_jar)
         lumo.closure._compile.object (evalmachine.<anonymous>:1675:21)
         (Object.lumo$closure$_compile)
         (evalmachine.<anonymous>:2297:21)
         Function.lumo.closure.map_async.cljs$core$IFn$_invoke$arity$4 (evalmachine.<anonymous>:2118:105)
         Function.lumo.closure.map_async.cljs$core$IFn$_invoke$arity$3 (evalmachine.<anonymous>:2107:31)
         Function.lumo.closure.compile_sources.cljs$core$IFn$_invoke$arity$4 (evalmachine.<anonymous>:2276:35)
might be a windows specific issue

moxaj12:07:21

^ simple fix, opened a PR

moxaj14:07:07

turns out it's not fixed yet! :white_frowning_face:

moxaj15:07:32

it seems like the timestamp aquired by Date.getTime is to be interpreted as milliseconds, but fs.utimes(Sync) expects seconds

moxaj15:07:32

and windows isn't particularly happy when I try to set the last modified date on a file to 08/07/49471 @ 11:07am (UTC) :smile:

moxaj20:07:27

@anmonteiro with those prs, I can build, but with :source-maps true I need the cljs uberjar on the classpath, and that doesn't sound right to me

moxaj20:07:11

otherwise cljs/core.aot.js.map is missing

anmonteiro20:07:26

hrm I think we remove it from the classpath manually

moxaj20:07:36

I mean, build using lumo.build.api

moxaj20:07:03

might be, the issue says It's not always this exact message, but it seems to always be something that's not defined.

moxaj20:07:27

however I'm getting omg it happened :slightly_smiling_face:

moxaj20:07:50

(io/resource "cljs/core.aot.js.map") returns nil, in lumo.compiler/emit-cached-core

moxaj21:07:20

I have verified that it works with 1.4.1, but not with 1.5.0

anmonteiro22:07:19

you’re probably right