the answer seems to be yes given i get the lsp auto complete when i include the deps directly.

hmm

i can figure this out, i feel like i ask this same question in a different way ever 3 months...

i need to set the source path

I use :source-aliases to tell Clojure LSP to include specific project and user level aliases. Aliases I use for every Clojure project go in my user level configuration for Clojure LSP, e.g :env/dev and :env/test https://github.com/practicalli/clojure-lsp-config#clojure-lsp-configuration

clojure-lsp will just delegate the classpath finding to lein or clj , and derive the source-paths from that, if you want more source-aliases to be included on lein's with-profiles or deps -A: you should add to source-aliases ☝️

by default clojure-lsp consider dev and test aliases only.

Ty @U05254DQM and @ericdallo

Which language is this, CLJ or CLJS?

and what do you expect lsp to do with this?

(I just tested and this seems to work in CLJ)

CLJ. I would expect it to be marked as a comment, so editor can apply comment syntax highlighting like any other comment.

so just for highlighting

Yep

I imagine it's not at the top of anybody's priorities, though. I'm probably just dreaming.

Wow, didn't know that worked

We would need clj-kondo work, also, not sure editors already know that like clojure-mode for emacs and vscode internals

In the end is just a string as usual right? Not sure if we should hightlight that

yeah, I don't think editors support this

I see other syntax highlighting inside regex literals already.

Oh,, nevermind. That's just highlighting escapes. So I guess interpreted as a string like you say.

See also: https://github.com/lambdaisland/regal

I added a shim in our development folder so ws.lsp/clean-ns! becomes the -T function and it in turn calls clojure-lsp.api/clean-ns! and passes :project-root (io/file "..") and that seems to have resolved the problem. If :project-root could be a string, I wouldn't need to do this.

I'm a bit surprised it seems to recompute the classpath and re-analyze the project each time -- I would have expected that to be cached?

Yes but that won't work since your deps.edn is in another folder different than your .LSP folder you mentioned which is odd

Why you would like to have clojure tools configs like clj-kondo and lsp not in the same folder of your clojure folder like deps.edn

The API works similar to the editor, if you open your project in your editor in the clojure folder, that's the project root you should pass for example

wsmain is where the editor opens. That's the project root.

(I've already had to go through this dance with VS Code/Calva and the way it invokes LSP etc)

And how clojure-lsp knows that the deps.edn is the clojure folder? Do you customize the classpath somehow?

Yes. Like I say, I already spent a lot of time configuring this for Calva 😐

if works for calva it should work the same, clojure-lsp.api just calls what the editor code calls

wsmain/.lsp/config.edn:

{:project-specs [{:project-path "clojure/deps.edn"
                  :classpath-cmd ["build/bin/classpath.sh"]}]
 :source-aliases #{:build :dev :everything :runner :test}}

#!/bin/sh

cd /Developer/workspace/wsmain/clojure

../build/clojure/bin/clojure -A:build:dev:everything:runner:test -Spath

Without :project-root, it does not seem to look up the directory tree to find wsmain/.lsp/config.edn and then work with the .lsp and .clj-kondo folders at that level.

So:

;; copyright (c) 2022 world singles networks llc

(ns ws.lsp
  (:require [ :as io]))

(defn clean-ns! [opts]
  ((requiring-resolve 'clojure-lsp.api/clean-ns!)
   (assoc opts :project-root (io/file ".."))))

And in wsmain/clojure/deps.edn:

:sort-ns
  {:replace-paths ["development/src"]
   :replace-deps {com.github.clojure-lsp/clojure-lsp {:mvn/version "RELEASE"}}
   :exec-fn ws.lsp/clean-ns!
   :exec-args {:dry? true
               :settings
               {:clean
                {:ns-inner-blocks-indentation :same-line
                 :ns-import-classes-indentation :same-line
                 :sort {:refer {:max-line-length 1}}}}}}

What I've learned from this exercise is that we are not very consistent with our :import clauses! 😆

yeah receive as a file https://github.com/clojure-lsp/clojure-lsp/pull/455#discussion_r659250513. > Without :project-root, it does not seem to look up the directory tree to find wsmain/.lsp/config.edn and then work with the .lsp and .clj-kondo folders at that level. without project-root will use the root as where the command was run, so we need to checks from where you are running that. > What I've learned from this exercise is that we are not very consistent with our :import clauses! 😆 Yeah, that's one good thing about not having custom scripts, you never know if your script is really doing that other tools do

all of that headache is probably because your deps.edn is in a place different than the project root (where you have your lsp configs), I suggest in the future you move everything related to clojure to the clojure folder indeed

The diff output from the above is about 1,600 lines... so this is going to be a big, one-off PR to reformat our code and then keep it this way. Which is fine. Now I just need to integrate this into our build.clj file (and then I can remove the ws.lsp shim now I have it working.

No, the deps.edn must be in the Polylith workspace -- which is wsmain/clojure

got that, but why .lsp and .clj-kondo are outside that clojure folder?

why don't have everything related with clojure, in the clojure folder 😅 ?

Because Calva runs LSP in the project root -- where the editor opens -- as I said above.

so, sounds like a Calva issue, you can open a project in /foo/bar in emacs for example and have lsp start in /foo/bar/baz

You can search back in the discussions here but I went round and round with this when I switched to Calva -- and you and @U0ETXRFEW were in that discussion 🙂

I tried a lot of combinations of file placements and configuration and what I've shown in this thread was pretty much the only configuration that actually works properly.

I suggest opening a issue on calva, where you could specify the project root

I don't care, to be honest, now that I have it working. And I really don't want to move stuff around in the repo again at this point (otherwise I'd have moved everything in clojure up to the top-level ages ago -- even tho' that means having a build tree full of scripts and config files and a documentation tree full of markdown files mixed in with our Clojure code which... ugh!).

Sure, glad it's working

Re: issue 455 -- I should have known that it would be vemv who suggested not accepting a string :rolling_on_the_floor_laughing:

Thank you for your help/input! I have the PR in at work to switch the tooling from our custom sort script to LSP's clean-ns! and I'm now working on the actual PR for all of the reformatting changes 🙂

Awesome! Happy to see it's working! Happy refactor :p

Iirc we found this to be a limitation in vscode. Calva can’t set the project root unless we find another way to do it, non-standard. The only way to do it in VS Code is to use workspace folders and have the one you want as project root be the topmost way folder.