This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-10-07
Channels
- # announcements (2)
- # babashka (34)
- # beginners (114)
- # biff (7)
- # calva (16)
- # cider (2)
- # clj-kondo (46)
- # clj-on-windows (14)
- # clojars (13)
- # clojure (33)
- # clojure-europe (17)
- # clojure-nl (2)
- # clojure-norway (8)
- # clojure-spec (3)
- # clojure-uk (3)
- # clojurescript (25)
- # community-development (1)
- # datalevin (1)
- # emacs (53)
- # fulcro (31)
- # gratitude (2)
- # jobs (1)
- # lambdaisland (12)
- # lsp (57)
- # malli (3)
- # nbb (1)
- # off-topic (92)
- # pathom (2)
- # pedestal (2)
- # releases (5)
- # shadow-cljs (25)
- # sql (3)
- # squint (1)
- # testing (6)
- # vim (11)
@plexus Are you open to a minor change in lambdaisland/uri_test.clj
so I can add this library to bb's CI tests?
$ bb -cp $(clojure -Spath -A:test) -e "(require 'lambdaisland.uri-test) (clojure.test/run-tests 'lambdaisland.uri-test)"
Testing lambdaisland.uri-test
{:result true, :num-tests 100, :seed 1665147300408, :time-elapsed-ms 1533, :test-var "query-string-round-trips"}
Ran 8 tests containing 86 assertions.
0 failures, 0 errors.
{:test 8, :pass 86, :fail 0, :error 0, :type :summary}
Alternatively or additionally I could also add a CI step uri in which bb tests are run, so any problems will be detected sooner than later
https://github.com/lambdaisland/uri/pull/31 It seems CircleCI isn't configured to run PR tests
@plexus I noticed the PR contained a small error. Maybe you could enable PR runs for CircleCI? This is an option which is not enable by default. After doing so I could submit another PR which fixes (at least) the bb test runner