@plexus Are you open to a minor change in lambdaisland/uri_test.clj so I can add this library to bb's CI tests?
$ bb -cp $(clojure -Spath -A:test) -e "(require 'lambdaisland.uri-test) (clojure.test/run-tests 'lambdaisland.uri-test)"
Testing lambdaisland.uri-test
{:result true, :num-tests 100, :seed 1665147300408, :time-elapsed-ms 1533, :test-var "query-string-round-trips"}
Ran 8 tests containing 86 assertions.
0 failures, 0 errors.
{:test 8, :pass 86, :fail 0, :error 0, :type :summary}
Yes, PR welcome!
Alternatively or additionally I could also add a CI step uri in which bb tests are run, so any problems will be detected sooner than later
Sure
Will do!
https://github.com/lambdaisland/uri/pull/31 It seems CircleCI isn't configured to run PR tests
@plexus I noticed the PR contained a small error. Maybe you could enable PR runs for CircleCI? This is an option which is not enable by default. After doing so I could submit another PR which fixes (at least) the bb test runner
I don't have time for this right now, but I've added it to our project board.
@plexus Thanks :)
FYI, if you allow PR builds in circle, this isn't leaking secrets by default: that's another setting
I left another comment in the issue. Have a nice day!