That'd help a lot! I use dracula on https://github.com/ericdallo/dotfiles

Also I use "peek" to record my gifs

Well, that’s a very thorough answer! Thanks! I’ve been thinking about trying out NixOS… /goes down a rabbit hole

Yeah, NixOS is awesome, but I already spent a lot of time indeed with that 😅

Here’s the re-recorded gif. The MacOS tools for optimizing aren’t great, so it’s still pretty large (463K vs the original which was shorter but only 137K). @ericdallo would you like me to add it to the https://github.com/clojure-lsp/clojure-lsp/pull/716 or do you want to record it on your machine?

Sure! Feel free to add tot he PR

@U07M2C8TT I intend to do a release this week, do you think we should wait to include your PR?

Up to you. I’ve been using it regularly and it’s been fine, but I know you wanted to do a bit more testing on it. There’s no rush.

Point outside of the form:

point inside the form:

Is there a way to prevent this highlighting until we can correct the analysis?

oh that's quite odd, seems like some lsp-mode/emacs configuration

is this project open so I can test that?

this is because defendpoint is linted using a config macro and all warnings appear on the opening paren, but perhaps this doesn't work nicely with the public var linter

[email protected]:metabase/metabase.git

I think this could happen if you didn't configure the hook for that macro to use the proper row/col/end-row/end-col right @U04V15CAJ?

this just uses the :macroexpand :hook which is a simplified way of writing hooks with the trade-off that you lose your locations for warnings and all of them are propagated to the top

makes sense

hum, I see, that's bad, I was not aware that could cause those highlight issues

i’d be fine if it just highlighted the macro’s form api/defendpoint rather than the entire form

you can already see that there are 0 references for this var, so maybe disable the public var linter locally as this is basically the same info

I suspect this will happen for every linter that uses macroexpand, not only unused-var

@U11BV7MTK you can disable the linter for specific namespaces or vars as well

Check the https://clojure-lsp.io/settings/#clojure-lspunused-public-var

seems like all of our api namespaces will have an issue. Its also finding some unused bindings > src/metabase/api/email.clj:68:1: warning: unused binding p1__19760#

a better way is to write an :analyze-call hook but this takes more time :)

yeah, I already wrote some hooks for metabase, so probably take that as examples :)

@ericdallo that’s an lsp feature not clj-kondo? The config you sent me is for lsp but i’m reading the warnings from clj-kondo --lint src:shared/src

:clojure-lsp/unused-public-var

this linter is only available in clojure-lsp

@U11BV7MTK :clojure-lsp/unused-public-var`` is a custom lint fn that clojure-lsp has using clj-kondo custom lint feature

oh right. clj-kondo only mentions unused private vars

yes

thank you both

should i file an issue about the macro warning line information? or is that just a user problem because i am not providing a hook?

I don't see nothing wrong on clojure-lsp side, and kondo can't know for sure the correct location, so probably this is a user problem indeed

it's a "do I want to pay the time for writing a better hook vs getting a slightly worse editor experience" problem

I'd go with writing the hook, but this is your call @U11BV7MTK 😄

@ericdallo FYI, I recently brought down the errors on metabase to 0 in one day :)

(I didn't even know this :macroexpand feature)

And I wrote that macro to get it done within a day

yeah, I saw that, really neat! 👏

:linters {:clojure-lsp/unused-public-var {:level :warning
                                           :exclude-when-defined-by #{metabase.api.common/defendpoint}}}

if that does what i think it does, exclude-when-defined-by is a very thoughtful addition.

yeah, I added that for those cases :)

that’s really thoughtful. Really nice

it is not working for me though 😞

i’ve restarted the workspace twice.

oh, the highlight issue is not related with any linter :(

it's a clojure-lsp feature called hover, that show the symbol location

it might be a clj-kondo error inside of the macro and the line information is the entire form then

since the location is wrong, there is no way to disable that unless fixing the hook

bumma

I can confirm that later tonight

the location is not wrong, it's just propagated to the top. any linter can display information at the top (first paren)

@U04V15CAJ the issue is not the linter, but the row/col on the analysis or the name-row/col

I'll try to show that later tonight

the location of every node in the macro-expansion will be the location of the outer expr

with macroexpand

yeah i think it knows there are several errors and they are all at the same place

Perhaps we'll just have to enhance this linter

:macroexpand is usually used for simple things like (declare foo bar baz) where nothing can go wrong, but this macro is a bit involved

I confirmed the behavior on metabase local @U11BV7MTK, it's indeed multiple elements at same outer position:

[{:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :ns metabase.api.util,
    :name GET_stats,
    :defined-by clojure.core/def,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :col 1,
    :name-col 1,
    :end-col 33,
    :doc "foo",
    :bucket :var-definitions,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :ns metabase.api.util,
    :name GET_stats,
    :defined-by clojure.core/def,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :col 1,
    :name-col 1,
    :end-col 33,
    :doc "foo",
    :bucket :var-definitions,
    :row 25},
   :semantic-tokens
   [{:token-type :function, :token-modifier [:definition]}]}
  {:element
   {:fixed-arities #{1},
    :end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name defendpoint*,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :macro true,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :arity 1,
    :bucket :var-usages,
    :row 25,
    :to metabase.api.common},
   :definition
   {:fixed-arities #{1},
    :end-row 257,
    :name-end-col 23,
    :name-end-row 247,
    :name-row 247,
    :ns metabase.api.common,
    :name defendpoint*,
    :defined-by clojure.core/defmacro,
    :filename "/home/greg/dev/metabase/src/metabase/api/common.clj",
    :macro true,
    :col 1,
    :name-col 11,
    :end-col 16,
    :arglist-strs
    ["[{:keys [method route fn-name docstr args body]}]"],
    :doc "Impl macro for `defendpoint`; don't use this directly.",
    :bucket :var-definitions,
    :row 247},
   :semantic-tokens [{:token-type :macro, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name do,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :var-usages,
    :row 25,
    :to clojure.core},
   :semantic-tokens [{:token-type :function, :token-modifier []}]}
  {:element
   {:fixed-arities #{0},
    :end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name check-superuser,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :alias api,
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :arity 0,
    :bucket :var-usages,
    :row 25,
    :to metabase.api.common},
   :definition
   {:fixed-arities #{0},
    :end-row 95,
    :name-end-col 22,
    :name-end-row 92,
    :name-row 92,
    :ns metabase.api.common,
    :name check-superuser,
    :defined-by clojure.core/defn,
    :filename "/home/greg/dev/metabase/src/metabase/api/common.clj",
    :col 1,
    :name-col 7,
    :end-col 31,
    :arglist-strs ["[]"],
    :doc
    "Check that `*current-user*` is a superuser or throw a 403. This doesn't require a DB call.",
    :bucket :var-definitions,
    :row 92},
   :semantic-tokens
   [{:token-type :type, :token-modifier []}
    {:token-type :event, :token-modifier []}
    {:token-type :function, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name anonymous-usage-stats,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :alias stats,
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :arity 0,
    :bucket :var-usages,
    :row 25,
    :to metabase.analytics.stats},
   :definition
   {:fixed-arities #{0},
    :end-row 389,
    :name-end-col 28,
    :name-end-row 369,
    :name-row 369,
    :ns metabase.analytics.stats,
    :name anonymous-usage-stats,
    :defined-by clojure.core/defn,
    :filename
    "/home/greg/dev/metabase/src/metabase/analytics/stats.clj",
    :col 1,
    :name-col 7,
    :end-col 53,
    :arglist-strs ["[]"],
    :doc "generate a map of the usage stats for this instance",
    :bucket :var-definitions,
    :row 369},
   :semantic-tokens
   [{:token-type :type, :token-modifier []}
    {:token-type :event, :token-modifier []}
    {:token-type :function, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name do,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :arity 2,
    :bucket :var-usages,
    :row 25,
    :to clojure.core},
   :semantic-tokens [{:token-type :function, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name GET,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :arity 6,
    :bucket :var-usages,
    :row 25,
    :to compojure.core},
   :semantic-tokens [{:token-type :function, :token-modifier []}]}
  {:element
   {:fixed-arities #{1 3 2},
    :end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name def,
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :macro true,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :arity 2,
    :bucket :var-usages,
    :row 25,
    :to clojure.core},
   :semantic-tokens [{:token-type :macro, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "line",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "line",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "column",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "column",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "doc",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "doc",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "is-endpoint?",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "is-endpoint?",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "line",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "line",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "column",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "column",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "line",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "line",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}
  {:element
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "column",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :definition
   {:end-row 30,
    :name-end-col 33,
    :name-end-row 30,
    :name-row 25,
    :name "column",
    :filename "/home/greg/dev/metabase/src/metabase/api/util.clj",
    :from metabase.api.util,
    :col 1,
    :name-col 1,
    :context {},
    :from-var GET_stats,
    :end-col 33,
    :bucket :keywords,
    :row 25},
   :semantic-tokens [{:token-type :keyword, :token-modifier []}]}]

(BTW this is a really handful tricky when debugging kondo analysis, lsp-clojure-cursor-info)

i was looking for something like that. thanks

there is a custom request called clojure/cursorInfo which brings information about the element at cursor position like kondo analysis, element definition and semantic tokens for that element!

For emacs user this is already available via lsp-clojure-cursor-info

c/c @U07M2C8TT @U02EMBDU2JU

uh nice, I’ll have to build that into Calva. Thanks!

😎

I was about to suggest exactly that @U02EMBDU2JU :)

available in coc-clojure as a CocCommand too!