Thanks @U02G8N0EX44!

@borkdude any clue of what is that exception?

It seems to be a issue when reading the clojure-lsp home config file

On the getProperty of the user dir

https://github.com/clojure-lsp/clojure-lsp/blob/master/src/clojure_lsp/config.clj#L35

Are you aware of any issues with babasha pods when accessing JVM properties?

it fails on the CI differently

This is the step where bb downloads the pods from pod registry

Maybe some network issue with GitHub or something?

Maybe a Too many requests?

> This is the step where bb downloads the pods from pod registry No, you can see the pod was already started in the 0%, 5%, etc output

I'm not sure why this happens in the pod, I don't see any reason it should behave differently, except that this is the static-compiled binary

So you might be able to repro this using the static binary as well.

(println (.exists (io/file (System/getProperty "user.home") ".config"))) ;; => true is able to run fine in the context that then blows up

@U02G8N0EX44 Could you try with the static binary? https://github.com/clojure-lsp/clojure-lsp/releases/download/2022.01.03-19.46.10/clojure-lsp-native-static-linux-amd64.zip

I'm not sure if @UKFSJSM38 compiles this using musl or ...

Ah right, it's not. https://github.com/clojure-lsp/clojure-lsp/blob/0b07c8f9a5e59ae0d432a6891e15caea4ac5cf52/graalvm/native-unix-compile.sh#L28-L32

I would either use musl or -H:+StaticExecutableWithDynamicLibC

The --static option without other options isn't recommended anymore and is likely to cause errors. https://www.graalvm.org/reference-manual/native-image/StaticImages/

https://twitter.com/borkdude/status/1475190673661906964 :)

I bet @UFDRD93RR can help you with getting the musl environment going

There is also a github action for graalvm now btw: https://github.com/marketplace/actions/github-action-for-graalvm

Musl doesn't work with datalevin

ok, then try -H:+StaticExecutableWithDynamicLibC

don't use --static without any other opts, it's buggy, they don't recommend it

Good to know

but it would be good if @U02G8N0EX44 could try to reproduce with the static binary first. I expect it would behave the same as the pod (as that is the static binary!)

I mean, invoke it as the command line tool

I downloaded that .zip and ran it on machine and it crashed too

cool, so now we know the --static binary is b0rked and it isn't pod-specific

are you using nixos @U02G8N0EX44?

archlinux

oh yeah. well, @UKFSJSM38 could you add that flag? then we can try again and see if this fixes it.

yes, I'll add to the CI and then open a branch just to compile the native one

Keep in mind that -H:+StaticExecutableWithDynamicLibC will make the binary not work in NixOS or any distro that doesn't use glibc

🙏

(Alpine for example)

yes, but it doesn't work in alpine now anyway

does it?

I think it does

the issue is that I have to select one specific binary for the pod, and I chose the static one as that is the most likely to work in most environments

--static without -H:+StaticExecutableWithDynamicLibC should work in Alpine because it links glibc statically

This is not recommended even by glibc folks, but kinda works unless you do things like DNS resolution

BTW, not really sure if NixOS support is that much interesting, because NixOS has a proper clojure-lsp package

but this binary crashes so what is the use

The only issue would be Alpine

yes, I agree

we can at least try if that flag "fixes" it

and else we'll have to make an issue with graalvm

yes, I'm on it

It's building https://github.com/clojure-lsp/clojure-lsp/runs/4729949800?check_suite_focus=true with the new flag

build finished, how can we download?

I forgot to add the upload

:)

With the new approval github actions, I think we can create a action that trigger only with manual input, so we can have a action to build graalvm from master only when we want, it'd be handy

Here you can download the static binary with that new flag: https://github.com/clojure-lsp/clojure-lsp/actions/runs/1664186105

(BTW I changed clojure-lsp native binary build on CI to build the static one always)

Just tested with your bb script + that binary and it worked to me

Actually, I tested with this one:

(ns clean-ns
  (:require [babashka.pods :as pods]))

(pods/load-pod "/tmp/clojure-lsp/clojure-lsp")

(require '[clojure-lsp.api :as api])

(defn dry []
  (api/clean-ns! {:dry? true}))

(defn fix! []
  (api/clean-ns! {}))

(boolean (dry))

@UKFSJSM38 I don't see where I can download the binary. Do you have a direct link?

https://github.com/clojure-lsp/clojure-lsp/suites/4853915376/artifacts/137934401

awesome! @U02G8N0EX44 can you try that one and see if it doesn't crash?

you can also load it as a pod by doing (pods/load-pod "./clojure-lsp") on the local binary

yes, that new binary works on the CI, thanks!

is there a good way to completely skip the analysis step when doing things like clean-ns? or does it need it to remove unused ns requires?

@UKFSJSM38 Yes, I think there should be an option to skip analysis, which isn't necessary for clean-ns and formatting I think. Or perhaps the analysis can be scoped to only the project sources (which should take only a few seconds).

Good news! I'll change the pod to use the "mostly static" binary. Is that now the default setting for the "normal" linux binary @UKFSJSM38?

Yes @borkdude, thanks!

@U02G8N0EX44 I have plans to improve that in the future 🤞

ok, we'll wait for the next release then :)

Thank you glad you like it!