Clj-kondo Sublime Text integration docs: https://github.com/clj-kondo/clj-kondo/blob/master/doc/editor-integration.md#sublime-text

linter idea: (update x :foo #(bar % a b)) -> (update x :foo bar a b)

sounds tough to discern the good case from (update x :foo #(bar a % b)) but i like that idea

or maybe i’m inventing complexity and its not that hard

probalby not hard for borkdude 🙂

I guess any such function (like swap!) where the update fn uses its argument in the second position of its singular form

This is probably doable. Up till 3 args this seems ok, but more than that it's going to use apply which in some cases would affect performance somewhat? Depends on hot path of course

(swap! atom (fn [x] (something x anything)))

oh wait

it's always a single arg function in the first case

or is it

the function will be arity (+ 1 (count trailing-args-to-swap))

but the 99% common case is that beginners don't know about the update function taking multiple args

that case: (update-in m [:foo] #(inc %))

rather than (update-in m [:foo] inc)

in fact a more generic lint would be if someone passes a function #(inc %) rather than inc

anywhere (like map), not just update-in

I didn't try that, maybe it's already linted

I’m trying to think of corner cases where it might be difficult to realize you can’t use this

(update x :foo #(bar a (merge % {:a :b}) b))
(update x :foo #(bar a (let [x %] (inc x)) b))
(update x :foo #(bar a (inc %) b))
(update x :foo #(bar a % %))

those are all fine

the rule would be: "anonymous arity-1 function of a single expression passed to swap/update, where the singular arg appears only in the second position in the form"

but I think I'd be ok with a more general rule

the hardest part would be a name for the linter

anonymous function that just forwards to a var: (fn [x] (foo x)) or #(foo %) rather than foo

unnecessary-anonymous-fn-expr

that would catch 99% of the update/swap cases too

ok, that's a good one to start with.

I wrote an issue here: https://github.com/clj-kondo/clj-kondo/issues/1526