What a fantastic project, many thanks to everyone 😄

@ericdallo Does LSP emacs support something like an interactive finding of a var? I just want to enter (part of the) name

without hovering over it in a buffer for example

Yes. the textDocument/workspaceSymbol should handle that

e.g. right now I am trying to find the var syntax-label but I forgot in which namespace this var was defined, but lsp knows all of this

in emacs there is: lsp-ivy-workspace-symbol

https://github.com/emacs-lsp/lsp-ivy

Or if you use helm : helm-lsp-workspace-symbol via the helm-lsp package

I don't use either but I'll try ivy

doesn't work though

I'll just use grep :/

It works for me:

why did you type *clj?

I don't know too much about the ivy filters

but It needs some prefix

eh, this is too hard for me on Monday ;)

can we maybe have lsp-clojure-find-var-interactively and then type some string which filters over the vars using some fuzzyness?

For some reason it seems to need a first anything param :man-shrugging:

that command should do that, we just need to fix that search, not sure it's a lsp-mode bug or related how the server is returning the data

I tested with Dart lang and it worked perfectly, so I need to investigate why clojure-lsp is returning the symbol filtered only when it has 2 params

For now you can use it with . syntax-label ,it should work

@ericdallo Confirming that works with lsp-ivy-workspace-symbol. I tried lsp-ivy-global-workspace-symbol which didn't work

the global one get symbols from all active projects, not so useful and may have performance issue I suppose

ok. so it only finds symbols from the source paths right? if I type concat it doesn't return clojure.core/concat for example

yes

But maybe we should add support for it as well

It makes sense to me

Hey guys

I’m considering using lsp and kondo for a very specific feature, but it seems like a lot of setup for something so little. I haven’t delved into lsp before. Cursive users, do you think that LSP gives you some very valuable feature that you don’t get from Cursive out of the box?

Hm, I got curious and tried the workspace-symbol from NeoVim and it doesn't seem to take the query into account -> I get all the symbols of my workspace back instead.

Sell it to me 🙂

If you can be bothered!

@reefersleep There are already people using the clj-kondo LSP plugin with Cursive, so at least diagnostics work for sure

Without clj-kondo you probably get less diagnostics from Cursive only

My favorite clojure-lsp feature is probably finding keywords, although TIL that Cursive also has this

And what you don't get with Cursive (I think) is being able to define custom (clj-kondo) hooks for your macros so the IDE "gets" them

That’s the interesting part for me. But I wonder if there are other killer features 🙂

Namespace cleanup maybe?

https://clojure-lsp.github.io/clojure-lsp/features/

not sure Cursive supports all clojure-lsp code actions

Maybe not all, but it seems to me like there’s a big overlap. That’s why it’d be cool if Cursive users could highlight the golden differences 🙂

Is there any way I can manually change the project root?

@borkdude @orestis latest release should fix the workspaceSymbols querying issue and the rename on a refer (bumping clj-kondo)

updating 🙏

I’m running into an issue where I get different diagnostics between latest version of clj-kondo and clojure-lsp with regard to clojure-lsp not finding some macro used in cljs code. kondo seems to find the definitions and doesn’t emit warnings. how to best debug what is going on?