Fork me on GitHub
#kaocha
<
2023-08-28
>
plexus08:08:07

A github issue to track this would be appreciated @nomiskatz

simonkatz08:08:52

OK; I’ll do that late today, or maybe tomorrow. Would you prefer a single GitHub issue to cover all three points, or separate issues?

plexus09:08:03

actually since you have fixes, can you go ahead and make PRs? minimal change + a changelog entry would be great. Thanks.

simonkatz09:08:04

Sure, if my changes are good enough. (But what about tests?)

simonkatz09:08:06

Oh, should I create a PR to make lambdaisland.tools.namespace.repl/remove-disabled public?

plexus10:08:06

Kaizen, lots of small improvements is what open source is built on. Don't break existing tests (obviously). If you can add tests for changes/additions then that's great, if you don't but the change seems reasonable and you've tried it out then that's fine too.