Clojurians Log v2

What would such tests look like? We could maybe wrap some known mix of succeeding/failing tests some way that would fail the tests if the result tally of these is wrong...

Just added something to my comment above, how I do this in bb

we could maybe also just check the expected stdout, or write to a log file in the tests

and then verify the output of the log file

To use the host's cljs.test (shadow) we will need to factor the joyride.sci code such that it does not rely in vscode, I think.

we don't need to use cljs.test per se, just some assertions will do

using electron/node

> we could maybe also just check the expected stdout, or write to a log file in the tests This is where I was going with my first reply above.

I think it would be good to check: • The number of tests that have been run Maybe other stuff?

right

But write some special tests for this, maybe as simple as one succeeding and one failing, just to see that we don't ”accidentally mark everything as succesful”.

yeah

or maybe do this in some tests: add something to a global state and then at the end of the test suite, we verify in the integration test runner that the global state thing is as expected

so we know at least the coverage has been as expected

I think maybe in the cljs test multimethods this would work

so we can confirm the number of assertions made, I think that's sufficient

I have trust that assertions work, so if we can just assert that "at least x assertions" have been made, it's good

Cool. I've added an issue about this now: https://github.com/BetterThanTomorrow/joyride/issues/138

We already keep a counter of successes and failures in an atom, a slight change to where we report back on the test run success of failure should do it. Like so:

(defmethod cljs.test/report [:cljs.test/default :end-run-tests] [m]
  (old-end-run-tests m)
  (let [{:keys [running pass fail error]} @db/!state
        passed-minimum-threshold 20]
    (println "Runner: tests run, results:" (select-keys  @db/!state [:pass :fail :error]))
    (if (or (> 0 (+ fail error))
            (< pass passed-minimum-threshold))
      (p/reject! running true)
      (p/resolve! running true))))

Nice