When I use the Clojure LSP in Spacemacs, there's an lsp-clojure-move-form command. There's also a CIDER plugin to do refactorings.

Calva offers some LSP refactors, but that one is currently not included. I suggest opening an Issue to request it.

@U0ETXRFEW, What is involved in adding a refactor command? My cursory look makes me think it could be as simple as adding {command: 'move-form'}, to https://github.com/BetterThanTomorrow/calva/blob/e8d68ee0541ce87368cb0b109b586100a8f1db64/src/lsp/main.ts#L200. Assuming that is true (I could of course be wildly off), is there any reason to not enable every command listed at https://github.com/clojure-emacs/clj-refactor.el/tree/master/examples?

I think mostly it is only about enumeration, like you suggest. Can’t see a reason to exclude any existing refactor. As long as it works. PR welcome. (EDITED)

I created https://github.com/BetterThanTomorrow/calva/pull/2016. @U04ERSXPHGR @U90R0EPHA If you like, you can help testing this by installing the vsix from https://output.circle-artifacts.com/output/job/3fa49235-d609-430d-b0f1-2b4375cf44e6/artifacts/0/tmp/artifacts/calva-2.0.327-pull-2016-71bf46c4.vsix. Thanks!!

> Can’t see a reason to exclude any existing refactor. As long as it works. @U0ETXRFEW What if it only partially works? Some of the refactors seems to have bugs in Spacemacs. Not sure if that's the layer or the LSP itself. Also, some of the clojure-mode refactorings in Spacemacs are through https://github.com/clojure-emacs/clj-refactor.el. Could Calva support those too, or would that only work in Emacs? Even buggy refactorings are sometimes easier than doing everything by hand, and the more people that use them, the more likely the bugs get found, reported, and fixed upstream.

Today I went through the Clojure-lsp docs and I didn’t find any other missing refactorings. Did you have anything specific in mind, other than the move-form refactoring, @U04ERSXPHGR ?

@UGNFXV1FA Compare https://github.com/clojure-emacs/clj-refactor.el/tree/master/examples to the ones enumerated in Calva source.

Are all of the Calva ones listed in its package.json? I looked in there and didn't see the following from the LSP refactor method:

add-missing-import
add-require-suggestion
cycle-coll
change-coll
destructure-keys
restructure-keys
promote-fn
demote-fn
drag-forward ; does paredit do this instead?
drag-backward ; ?
drag-param-backward
drag-param-forward
extract-to-def
get-in-more
get-in-less
get-in-none
sort-clauses
sort-map ; deprecated for sort-clauses
move-coll-entry-up ; deprecated for drag-backward
move-coll-entry-down ; deprecated for drag-forward
suppress-diagnostic
create-function
create-test
move-form ; the one we're discussing now
cycle-keyword-auto-resolve

Yes, they need to be listed in package.json. They also need to be registered as commands in the extension code. For refactors, Calva does that by walking through this dict. https://github.com/BetterThanTomorrow/calva/blob/ef533e063988fa62ca2d8feb3f1a568b1607c0a1/src/lsp/main.ts#L200

Those in Calva source are NOT the only ones, more are provided as quick fixes.

Are there quick fixes that are "refactor"s (as opposed to some other action that also happens to be provided by LSP)? If so, do they only make sense as quick fixes? Or might some users potentially want a command they can pull up in the command palette or bind a hotkey to?