@magnars @john It would be interesting to know if the spurious warnings go away if the patch in this PR is applied https://github.com/bhauman/figwheel-core/pull/2

@mfikes running into this warning as well. thanks for the pointer, will give it a try as soon as i can

Yup, I'll try this morning as well

@mfikes I wiped a bunch of things and rebuilt things from scratch and it's humming right now and I'm testing things. If it pops back up, I'll see if that patch reverses the behavior.

Okay I just hit it

How should I do this? Fork fighweel-core, then use my local repo as a :local/root dep, and then do an exclusion in the figwheel-main coordinate?

I can't recall the details. I think I ended up doing some dep override.

k np

Yeah, this seems to have worked:

com.bhauman/figwheel-core {:local/root "../figwheel-core"}
                   com.bhauman/figwheel-main {:mvn/version "0.2.0"
                                              :exclusions [com.bhauman/figwheel-core]}

and the error hasn't popped up again yet.

Is this supposed to fix the error or just move it to a more salient indicator?

@john The root problem is that, with the defect in figwheel-core, the ClojureScript compiler's internal use of cljs.analyzer/no-warn doesn't really suppress warnings that it is intending to suppress. So, it may speculatively analyze something (with warnings intentionally suppressed), and with the defect, those warnings are actually not suppressed, but emitted.

aaah, k

@mfikes as this seems to only happen with the most recent clojurescript release, do you have some change between 1.10.439 and 516 in mind which could have brought this issue forward?

@kommen The new loop / recur inference can cause an additional analysis pass to occur https://clojurescript.org/news/news#_improved_loop_recur_inference

@kommen There are other places too where new analysis is being done for type inference purposes, with warnings suppressed during that analsysis

ok, thx

The issue hasn't resurfaced since I've applied the patch