i was asking about some visualization of how figwheel/repls work. i just noticed amongst my tweets a retweet of this: https://www.reddit.com/r/Clojure/comments/6kht1e/diagramming_the_flow_of_figwheel/ (the link in the article is broken. have to change http://planttext.com to http://plantuml.com in the diagram's url)

https://www.plantuml.com/plantuml/img/RLFBRi8m4BpxArQvv4IveueYqOU4a4303pZ91fiwwoWsjVZxsedpAfKY9TwTcHsFdOsnlB7tIZ5cfLK8oOxdtvAk80cSj0Asii06E1NmAQzE8Ag4iVGYf07_S30Ux7bA4aAkgmh9ChPCsOYexihA1PiXqYLZ_Ytj0x3YkUaNoQ76XjjWuFmm5gi4k04zzkdqSTmlj_jTsw2XqPiBrT8zmyyHVniOMQET2Lipa8tw3ZFmrHziMe8ptcSm28krjm4hQ0C3Qh1M4SXqssrXiOy5Q89QU-JhyN2wh4SHwZ5G3fPzkBcw6GYYZEAilx0uXYOpXbR7ALtF6TLADrSREthEmUA95T9QWK2bD0lVFLx8YQokaOOiBS-YRjQtU5jCtpMQ0PPh8imjM3s6e9kmx78DHjvOrWevB_JrSG5XgoufVu9k626mmTI0qHNE4DcpsH1STshTTcDeyTZ-Fum1Exa3AyW5fojwYh_tvKi0JyASL2EmO1ka8lnZlm00

just came across this and it seems nice: https://timothypratley.blogspot.com/2015/07/you-should-be-using-figwheelreagent.html

It's a tetris tutorial using figwheel and reagent

@bhauman can confirm that ns auto-detection works now

also the target directory fix 💥

I'd like to be able to use the same cljs-spa.test-runner ns for cljs-test-display and from the CLI

Here's what I came up with: https://github.com/pesterhazy/cljs-spa-example/blob/64dcf126e6904f27d8e87d10fa788dbc81d63180/test/cljs_spa/test_runner.cljs#L19-L21 - a little hacky but it works

Am I right in assuming that to trigger something in the Extra Main page you need to run code at NS init time?

Oh, and I tried :auto-testing - it works great! Is it planned to support auto-testing from the command line as well?

@pesterhazy thanks for confirming all of this, I’m going to look at out your PR sometime today.

extra-mains can use the on-load hook metadata as well

but because of the nature of extra-mains its probably better to just put it at the top level

I should add this to the docs

I’m glad you like auto-testing, I think it should obviate the need for a test-runner that does both.

It hadn’t occurred to me to do autotesting from the command line. You could just change the :open-url to the testing endpoint and that would do it.

and the test runner is a source of merge conflicts all the time. really glad to see this focus

so glad to finally be getting to it

hmmm I’m going to have to put more thought into what it would take to have auto testing from the command line

but clearly its possible

I'm debugging the weirdest problem with reagent/react with figwheel main

I get a runtime exception, Cannot read property 'render' of undefined

According to the sourcemap, it's in this line https://github.com/reagent-project/reagent/blob/master/src/reagent/dom.cljs#L20

but react-dom is mapped to window.ReactDOM in foreign-libs

and window.ReactDOM.render most definitely exists (as seen from the devtools console)

I'm using a webpack bundle to provide react-dom

The compiled js looks like this

reagent.dom.node$module$react_dom.render.call()

I know what this is

@bhauman I'm on the edge of my seat

I thought it would be missing :exclusions

nope

but clojure -Stree is clean (no mention of cljsjs)

whats happening is that the goog.require('react-dom') is async right before var reagent.dom.node$module$react_dom.render = js/ReactDOM

if you look at the code in the file compiled file

the question is when is this happening to you?

the preamble looks like this

// Compiled by ClojureScript 1.10.238 {}
goog.provide('reagent.dom');
goog.require('cljs.core');
goog.require('react_dom');
goog.require('reagent.impl.util');
goog.require('reagent.impl.template');
goog.require('reagent.impl.batching');
goog.require('reagent.ratom');
goog.require('reagent.debug');
goog.require('reagent.interop');
reagent.dom.global$module$react_dom = goog.global.ReactDOM;

exactly

so if goog.global.ReactDOM is temporarily nil

then reagent.dom.global$module$react_dom will always be nil

ugh

but when is this happening?

in tests?

on first load?

no, normally in the browser on first load

but the theory rings true to me

@mfikes is aware of this problem

so the way the module reference is fixed at ns init time is in conflict with the fact that goog.require is async

thie problem is caused by figwheel taking over the loading process once its been loaded

I didn't even know that goog.require can be async

well things are supposed to be loaded ahead of time

before you get there

right, that's what I assumed

So that’s the behavior I’d look at

in fact, once the code gets to the point where the exception is thrown, react is already loaded

hmm

(defn ^:export main []
  (js/console.warn "XXX" js/reagent.dom.global$module$react_dom)
  (r/render [playground.slide/main-ui] (js/document.getElementById "app")))

that's the code that triggers the exception

but the console.warn prints out that the var is correctly set at that stage

this is tough, I really need to look at delaying taking over the loading

no wait the code that bombs out is actually

reagent.dom.node$module$react_dom.render.call

oh

looks like caching

do you have a node build?

no

then forget that

not that I know of...

I mean hmmm

I had a strange encounter before where the compiler asked me to install

npm install --save '@cljs-oss/module-deps'

well that just looks wrong if reagent.dom.global$module$react_dom = goog.global.ReactDOM; is at the top of the compiled file

oh don’t install that by hand

I was confused why module-deps was necessary - I'm not using npm integration or anything like that

you have to have :npm-deps false

maybe you missed that in a certain situation?

I didn't set that :npm-deps false manually, because I thought that would be the default

its not a compiler default

figwheel will add it if you have :npm {:bundles }

and you shouldn’t need to install @cljs-oss/module-deps by hand ever

that only means that :npm-deps is not set to false

oh wow!

that fixed it

good

it works now

when I fixed it, I did two things: I removed node_modules and package.json (which as you say aren't require), and I added a manual :npm-deps false

I don't know which of those two fixed things

its both really because

if there is a node_modules present cljs will scan it

and you really don’t want cljs to do that even if node_modules is there

yes exactly

I'll make a mental note to always explicitly set :npm-deps false from now on

man, thanks for demystifying this, I thought I was losing my mind

its in the webpack guide but its easy to miss

Added it to the example repo as well: https://github.com/pesterhazy/cljs-spa-example/commit/860656777137b258b4c39f49c2d74be9ae75e449