This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # announcements (5)
- # asami (4)
- # babashka (72)
- # beginners (241)
- # calva (15)
- # cider (2)
- # circleci (5)
- # clara (41)
- # clj-kondo (38)
- # cljsrn (4)
- # clojars (33)
- # clojure (283)
- # clojure-europe (41)
- # clojure-nl (9)
- # clojure-uk (11)
- # clojuredesign-podcast (14)
- # clojurescript (76)
- # conjure (12)
- # crux (6)
- # cryogen (42)
- # data-science (1)
- # datalog (6)
- # datomic (7)
- # depstar (10)
- # events (2)
- # figwheel-main (1)
- # fulcro (22)
- # funcool (1)
- # london-clojurians (1)
- # malli (8)
- # meander (11)
- # off-topic (12)
- # pathom (19)
- # re-frame (8)
- # reveal (34)
- # shadow-cljs (34)
- # sql (7)
- # vim (8)
My focus is on asciidoc as I believe it has more potential (although less tooling suport atm). I also the conventions and structure that https://antora.org/ has around building (documentation) websites from different git repos and modules.
thanks for the PR, just pushed out
0.3.0 version of cryogen-asciidoc with the update 🎉
@yogthos merging the multiple extensions PR broke asciidoc b/c it depends on https://github.com/cryogen-project/cryogen-core/pull/146 being merged into core and then depending on that version > Syntax error (IllegalArgumentException) compiling reify* at (cryogen_asciidoc/core.clj:22:3). > Can't define method not in interfaces: exts Here is a PR to revert it https://github.com/cryogen-project/cryogen-asciidoc/pull/10
Thanks for the merge! Can you re-release 0.3.0 to clojars? or bump the version and release? 🙏
• Sorry for the need to simultaneously update the various cryogen repos to handle the multiple-extensions PR. The list of PRs that need to be updated together are:`cryogen-asciidoc` PR number 7
cryogen-docs PR number 32
cryogen-markdown PR number 13
cryogen-flexmark PR number 6 and
cryogen-core PR number 146
As @U0522TWDA noted, the dependencies need to be updated after the PRs are applied. I did not want to put the dependency changes into the PRs since I didn't know what the new version numbers would be. I think the current states of the sub-projects of
cryogen-project are inconsistent. What is needed is to apply all the PRs in each of the sub-projects mentioned above and then to update all the dependencies.
@yogthos Just to be clear, ALL the related PRs need to be applied and then all the dependencies updated. It is not enough to apply just some of them. This is because the name of the protocol method is changed from
exts. Happy to do this if I have write access to the repos.
Does someone want to review the PRs before I merge them? I feel a bit strange merging my own PRs. But happy to do so if needed.
I have applied the changes to all the relevant repos. BUT, I have not yet updated any of the version numbers. I will update the "patchlevel" versions of all the relevant repos and change the dependencies. Then the repos should be ready to be released.
@yogthos, is the current
cryogen-core master branch the same as
0.3.2? Asking because the last tag on the repo is
0.3.1 but the README says 0.3.2.
I'll note that the circleci build of
cryogen-docs failed . Presumably because the correct versions of the dependencies are not yet on clojars. Other circleci jobs might fail too, for the same reason.
After publishing to clojars, it might be good to run the tests in
cryogen-core with all the latest versions.
One other thing ... I did not make any changes to
cryogen-core since 0.3.2 seemed to have all the necessary changes.
oh it looks like the docs wasn't building because I haven't pushed the new libraries to clojars yet
@U0AT6MBUL The advice from the Clojure philosophy would be not to change the protocol (a breaking change) but to create a new one or one in a new namespace. Then you could simply add it to core, release it, and the plugins could choose to extend it in their own time
Thanks. I agree. I did think about just adding an
exts method to the existing
Markup protocol. If I did that, it is my understanding that since the protocol itself has changed, that would still require synchronized updates. Meaning that if someone updated
cryogen-core to the version containing the new
Markup protocol, they could not continue to use the old implementations of the previous version of the
Markup protocol. Is my understanding correct?