Fork me on GitHub
#code-reviews
<
2016-12-09
>
roelofw08:12:46

@gdeer , pushed all the changes with credit to you

roelofw18:12:12

Did some changes to read-numbers so I could test it

roelofw18:12:41

I think in a few days I push a version with test with clojure.test

roelofw18:12:40

@gdeer81 : found issues or is everything well now /

gdeer8118:12:46

Sorry had a production deployment last night so I didn't get a chance to keep digging

roelofw18:12:42

work is more important

roelofw18:12:13

just like private life is more important then work is my oponion

roelofw18:12:56

@gdeer81 what do you use for testing ? spec/midje/clojure.test ?

gdeer8119:12:11

my new years resolution is to use spec and generative testing

gdeer8119:12:25

As a beginner it's important to try em all 🙂

roelofw19:12:25

I think you are not a beginner anymore

roelofw19:12:30

you know more then me

gdeer8119:12:56

I'm currently trying to get passed being an advanced beginner and avoid being an expert beginner http://daedtech.com/pics/ExpertBeginner.jpg

agile_geek19:12:00

@gdeer81 I think I may be stuck in that expert beginner cul-de-sac!

agile_geek19:12:53

P.S. not sure many ppl ever get to expert...been a Java dev for 19 years and I'd only count myself as proficient!

gdeer8119:12:23

@agile_geek that is why I think it is really important for everyone at every level to have a mentor. guiding someone helps reinforce what you know and working with someone that knows more than you will help you learn new things

agile_geek19:12:03

I would agree and add that working with someone with less experience helps me learn as I'm often forced to rethink assumptions or build a different mental model in order to explain something.

roelofw19:12:58

I think im still a novice

roelofw19:12:25

still a lot to learn

roelofw19:12:01

and right now learning gets in a very low pace

roelofw19:12:16

it costed me a whole afternoon to make one test

roelofw19:12:02

I think it will cost me a few months to go to the next level

roelofw20:12:46

maybe do some more work on my project and maybe continue with 4 clojure or another practice site

roelofw20:12:31

@agile_geek @gdeer81 Sounds like a good plan ?

agile_geek20:12:22

Yeah, I think learning in different ways is useful.

roelofw20:12:56

I can make a detail page where the painting is shown and some data under it

gdeer8120:12:12

let your project rest if there aren't any show-stopping defects, do another project or do some problems and then come back to your project later with a new set of eyes

roelofw20:12:15

I can make more tests with first clojure.test and maybe later spec

gdeer8120:12:30

adding tests are good as well

roelofw20:12:25

Another project I have to think well, My ultimate project is making a sort of accounting site but that is too far away for now

gdeer8120:12:16

here is one that is a little more involved than 4clojure problems but it won't be too involved that you couldn't finish it: https://stanfordclojure.com/#/assignments/pset1

roelofw20:12:56

oke, one problem did I see earlier

roelofw20:12:15

I think I cannot email the solutions like the page said @gdeer81 ?

gdeer8120:12:50

no, just do the solution and then you can post your repo in this channel

roelofw20:12:26

oke, that I can also do

roelofw20:12:39

the first is the same as a challenge for 4clojure

roelofw20:12:51

@gdeer81 I do not know how many time it costs to solve all the challenges

gdeer8120:12:14

yeah I'm still not finished with the 4clojure problems. I like to mix it up , so I go back and forth between puzzles and projects

roelofw21:12:58

I m was "leaving" 4 clojure on the same problem as the first one of the stanford challenges

roelofw21:12:12

So it will be hard for me, but that is allright

roelofw21:12:13

@gdeer81 I think I can solve it with some but I have to think about the predicate

roelofw21:12:40

I think I can use something like true?

gdeer8121:12:42

post the question and your proposed solution in refheap https://www.refheap.com/

roelofw21:12:06

because this is giving the wrong answer

(some true? [true true true]) 

gdeer8121:12:09

that way someone that doesn't have the context of our conversation can review it as well

roelofw21:12:29

it gives true where it must be false

roelofw21:12:26

and this one ` (some true? [false false false]) ;;=> nil ` gives nil where it schould be true

roelofw21:12:15

the exercise is this

Problem 1
Write a function which takes a variable number of booleans. Your function should return true if some of the parameters are true, but not all of the parameters are true. Otherwise your function should return false. For example:
(= true (half-truth true false))
(= false (half-truth true true))  

roelofw21:12:27

next time I will use refheap

roelofw21:12:14

I will sleep about it . it's almost 11 hour in the evening

gdeer8121:12:01

think about what some does and what the problem is asking

roelofw21:12:14

I will do that

roelofw21:12:28

Good night from a cold Netherlands