Why is this:

app:filippos.translations=> (keyword "unit" "4g")
:unit/4g
app:filippos.translations=> :unit/4g
clojure.lang.ExceptionInfo: NO_SOURCE_FILE [line 1, col 9] Invalid keyword: :unit/4g. {:type :reader-exception, :ex-kind :reader-error, :file "NO_SOURCE_FILE", :line 1, :col 9}
...

;; A keyword string, like a symbol, begins with a non-numeric
;; character and can contain alphanumeric characters and *, +, !, -,
;; _, and ?.  (see  for details).

The problem (that can really be circumvented in many ways is that I have a fixed set of constants (defined by a standard) and I’d hoped to just make them keys to translation maps that are stored as EDN. They are keyword-mapped and prefixed by their use (ie. unit/ for unit-like keys)

can anybody answer this https://groups.google.com/forum/?fromgroups#!topic/clojurescript/RHD05R77B7c ?

how is clojurescript releases built?

@sonnyto I guess this script file will generate cljs.jar. https://github.com/clojure/clojurescript/blob/master/script/uberjar This script is used from travis-ci. See https://github.com/clojure/clojurescript/blob/b23c77e230137840241a1ee3da45733813e647ac/.travis.yml#L20 .

Ah!

;; keyword does not validate input strings for ns and name, and may
;; return improper keywords with undefined behavior for non-conformant
;; ns and name.

That explains it.

Did not read that far below 😄

@blackawa cool...thanks!

I will write same answer to your google group, so some other people can find later.

people should ask questions on the google groups instead of slack so that there is a searchable record. slack wouldnt let you search unless you pay

@mikko the keyword function is kind of counterintuitive (keyword "(+ foo bar baz)") - no validation or sanity

a distribution question - does anyone have experience using yarn to publish cljs CLI scripts? Any gotchas?

@raymcdermott I have experience. no gotchas.

@thheller excellent - which toolchain did you use to create the scripts?

shadow-cljs of course which is also the package on npm I made the experiences with 😉

yeah, I was looking at that and it does look excellent for this purpose

thanks

@thheller [ I understand that you’re biased but still, it does look right ]

based on this conversation https://github.com/kkinnear/zprint/issues/45 I made a little toy example of how I'd structure things https://github.com/thheller/zprint-npm

oh that’s great - thanks very much

basics is simple. the package directory is what gets published to npm. the build config writes package/main.js

cd package; npm publish would publish the thing

been meaning to write a guide for this but didn't get around to it yet

I’ll fork it and give it a spin

this might sound like a silly question, but whenever I create an app using clojurescript (re-frame + reagent to be more specific), to deploy the app, I usually upload contents in my resources/public to the server. is this not the way I should be deploying it?

@bravilogy depends on what is in your resources/public 😉

well.. some images, css, index.html and compiled cljs->js

in general uploading the files is perfectly fine. I do that.

you should however ensure that only optimized builds are used

ie. :advanced compiled not :none development builds

i was reading a tutorial on how to deploy a clojure application to digitalocean, and every single tutorial I’ve seen, they just talk about lein uberjar command, but none of them mention the folder structure and clojurescript part

yeah I have those in my project.clj

yeah many people just bundle an uberjar and use a clj webserver to serve the files out of that jar

but you don't have to if you don't have a clj server part

and what’s the folder structure for that?

I keep the js separate even though I have a clj server

for example, I have a chestnut template application here

the resources directory gets added to the uberjar

oh so is the end result just 1 file?

yes

hmm.. I didn’t know that 😄

how about the images?

everything in resources

but what I mean is, if I have an image upload script and users can upload their images

yeah, then you have to start doing server management since you have a static OS dependent thing specific to that server

(unless you use a bucket API like s3)

@bravilogy it depends on the server you use. ring can serve files from a directory just fine.

yeah I use ring. so a pseudo structure of the application would be

my-app
\
 application.jar
 uploads/

use ring.middleware.file to serve the uploads directory under whichever path you want

it’s so strange that everything is packaged in 1 file 😄

it's handy - in the end using a file system is the weird / inflexible thing

it's nice when I know putting my one uberjar on a server that can run java is all I need

I don't like using uberjars for .cljs since you have to restart the java process in order to update the cljs

I’m still into the PHP folder structure mindset

complexity comes when I start trying to use resources tied to that server

so my cljs output just gets copied to the server with an nginx in front of it

yeah that’s exactly what I’ve done so far @thheller

@thheller: sure but at that point you are taking on the complexity of managing the server as a stateful resource, in exchange for the optimization of new cljs without restarts

copying the cljs output

it works, just be aware of the tradeoffs you are making complexity wise

@noisesmith given that I do CLJS updates with a frequency of like 10:1 compared to CLJ updates

I happily accept that tradeoff since I can do restartless deploys of CLJS

right, sounds like that is worth it for you - for the app I've been working on for the last few years, there are rarely cljs updates that are not tied to new clj code, so it's simpler to just treat the whole app as a single uberjar package

yeah uberjars are a great option as well

and I’m guessing there’s no threat for end users to ‘read’ the BE code somehow, even though everything is served from 1 file right?

@bravilogy depends on how you expose those jar contents but typically no

@bravilogy in theory no more risk than it is to serve files from a file system that also include secrets

I mean, if you are serving from the fs, a misconfiguration means you could serve up the whole app as source code for download, right?

at least with serving inside a jar, the simple failure case is limited to things inside that jar :P

(in past ring versions there have been file system path traversal exploits btw, there's been no jar traversal exploits that I know of)

yeah I get that, but what I mean is for example in typical LEMP, you have a public or public_html folder which has index.php file that loads the application that lives at the upper level of that public folder

sure, and someone asks for ../../ and gets all your other files :P

that hasn't been an issue for ages

I know what you mean, but in practice the management of resource paths inside a jar is actually simpler than managing them on the os level

@thheler ring had that bug very recently on file systems, but not serving from a jar

I know php has been fine, they got abused so much they had to fix it

if security matters to you at all, consider using nginx as a reverse proxy for actual access to things on disk though

@bravilogy but to your original point, I haven't heard of bugs serving unintended resources from jars - the classpath is managed relatively strictly. I have heard of bugs on the file system though.

yeah, that’s what I was trying to understand. I guess that standalone jar sort of ‘knows’ to only serve stuff from resources/public

I’ve never worked with java before and not entirely sure how jar files work 😄

specifically the wrap-resource ring handler is configured to look at a specific subpath

@bravilogy jars are basically zip files. nothing more.

interesting

I guess I need to actually deploy an application to fully understand how things work 😄

a key thing here is that the java concept of classpath abstracts over things inside zip files as well as things on disk

I usually use travisCI to trigger my cljs compilations and then it automatically deploys whatever is in resources/public

so the same code can access things from either place, depending on what's visible at runtime (the classpath argument to the vm)

Anyone had any issues with jdk9 + advanced optimisations + externs?

@olical Yes; fixed in 1.10.x https://dev.clojure.org/jira/browse/CLJS-2529

Interesting! Thanks a lot!

I'm guessing there will be another release before it's marked as stable. The current latest jar gives us errors around MapEntry in the schema lib, it looks like a fix for that went onto master a little while ago.

So we can't upgrade just yet, we're just going to drop our JDK version down until then.

@olical Right. The 1.10.126 is just a pre-release, a "beta" if you will

@olical Having said that, if your toolchain is using deps.edn ClojureScript can itself now be used as a git dep, so you can depend on the latest :sha in the interim

Did think of that, I'm afraid we're on lein 😄 we can deploy a fork no problem though.

(if we need to)

I want that sweet, sweet, 1.10 caching so bad.

Yeah, if you want the caching behavior, you need to depend on a built dep anyway (not a git dep)

Hi folks, have a rookie-level question: In the context of a CLJS web app, when we make network call from the client-side, an obvious idea is to execute it when the client triggers an event (ex: onClick). Are there other places/stages that can be good fit for network calls? Executing it within component lifecycle doesn't seem to be a great idea. What has been your experience?

depends on what kind of call, I work on an app where a websocket connection is initiated by the client (or else fail-over to long polling) and async callbacks are set up so the rest of the system doesn't start up until that facility is available

@mfikes clojurescript 1.10 has know issue with cyclic deps? I'm having problems trying to load my user.cljs namespace.

@souenzzo No new regressions AFAIK. There is an older issue https://dev.clojure.org/jira/browse/CLJS-2055 where it fails to indicate cyclic deps and locks up. If you see a lock up do a jps and then a jstack on the compiler process to get the stack trace.

@noisesmith One common use-case is similar to the one you described - say, I want to render a component that shows the data for an user. But, before I render the component, I need to have this data (for certain user-id).

sure, I think a common thing (certainly what we do) is to start with the data parts empty and fill them in when the data comes back

It's on #figwheel repl. my hotreload isn't working anymore cos it cant load user.cljs. I'm deploying some patches, I will debug this problem soon.

@noisesmith hmm, yeah, this can work

How do I call await on a js promise?

(.await p ...)

wow how does that work? await is a keyword not a method

@lee.justin.m oh, I thought it was a method, if it's a syntax I don't know

and in that case .await ... might not even work

I’d be interested if there was actually a way to do that without a library. You can’t call await outside of a function that has been declared async

oh, right, that is special

the simple solution is to call then on the promise instead of trying to await it

thanks for the correction

but promisa has a macro to let you do this: http://funcool.github.io/promesa/latest/#async-await-syntax

i’ve never used it, so i can’t promise it will work

hm

i'm really just trying to simulate a long-running function call

(sleep x) doesn't exist

can you just use js/setTimeout?

oh wait, by long running, do you mean blocking and long running or async and long running

i'll be simulating an ajax call, so async. js/setTimeout should work

it’s a slight pain because the scoping rules are different but a straight setTimeout or the combination of a Promise + timeout will almost always serve

thanks