2022-09-20 clojure-spec | Clojure Slack Archive

clojure-spec

phronmophobic 2022-09-20T18:30:13.165549Z

I'm trying to use spec to build a generator for valid destructure bindings. I'm starting with the specs in clojure.core.specs.alpha.

(s/def ::seq-binding-form
  (s/and vector?
         (s/cat :forms (s/* ::binding-form)
                :rest-forms (s/? (s/cat :ampersand #{'&} :form ::binding-form))
                :as-form (s/? (s/cat :as #{:as} :as-sym ::local-name)))))

Generating ::seq-binding-form values struggles because it's just generating random vectors that hopefully satisfy the s/cat. This seems to get fixed with (gen/fmap vec ...):

(s/def ::seq-binding-form
  (s/with-gen
    (s/and vector?
           (s/cat :forms (s/* ::binding-form)
                  :rest-forms (s/? (s/cat :ampersand #{'&} :form ::binding-form))
                  :as-form (s/? (s/cat :as #{:as} :as-sym ::local-name))))
    #(gen/fmap
      vec
      (s/gen
       (s/cat :forms (s/* ::binding-form)
              :rest-forms (s/? (s/cat :ampersand #{'&} :form ::binding-form))
              :as-form (s/? (s/cat :as #{:as} :as-sym ::local-name)))))))

Unfortunately, the version using gen/fmap now usually throws a stackoverflow exception. However, I noticed that if I ignore the vector requirement for ::seq-binding-form, then the stack overflow exception goes away.

(s/def ::seq-binding-form
  (s/cat :forms (s/* ::binding-form)
         :rest-forms (s/? (s/cat :ampersand #{'&} :form ::binding-form))
         :as-form (s/? (s/cat :as #{:as} :as-sym ::local-name))))

Is there a way to prevent and stackoverflow exceptions and have it generate a vector?

phronmophobic 2022-09-20T18:37:06.697129Z

It looks like spec2 might have better support for this. I don't have any real reason to stick with spec1, so I'll see if I can get this working with spec2.

Ben Sless 2022-09-20T18:37:37.201399Z

What if instead of fmap you use and conforming?

👀 1

phronmophobic 2022-09-20T18:38:07.174609Z

I don't know about conforming, but I'll take a look

Ben Sless 2022-09-20T18:38:37.570969Z

Maybe it's called conform, lemme check

phronmophobic 2022-09-20T18:39:08.767979Z

I was checking out spec2 based off this previous thread, https://clojurians.slack.com/archives/C1B1BB2Q3/p1650425212914829?thread_ts=1650424802.839689&cid=C1B1BB2Q3

Ben Sless 2022-09-20T18:39:33.195909Z

https://clojuredocs.org/clojure.spec.alpha/conformer

phronmophobic 2022-09-20T18:40:23.647679Z

giving it a try!

phronmophobic 2022-09-20T18:51:24.492439Z

I don't think that solves this use case. It still doesn't generate ::seq-binding-form as a vector. It does convert it if I conform the value, but I think it's worth trying spec2

Ben Sless 2022-09-20T18:53:44.865589Z

Gen doesn't emit conformed values?

phronmophobic 2022-09-20T18:59:30.560499Z

It's totally possible I'm doing it wrong. My attempt was:

(s/def ::seq-binding-form
  (s/and
   (s/cat :forms (s/* ::binding-form)
          :rest-forms (s/? (s/cat :ampersand #{'&} :form ::binding-form))
          :as-form (s/? (s/cat :as #{:as} :as-sym ::local-name)))
   (s/conformer vec)))

Alex Miller (Clojure team) 2022-09-20T19:01:58.671419Z

the specs need to be updated to have this work with spec 2

Alex Miller (Clojure team) 2022-09-20T19:03:48.781389Z

to use catv instead of cat etc

👍 1

phronmophobic 2022-09-20T19:38:06.213419Z

It works!

phronmophobic 2022-09-21T17:04:09.131719Z

Just to follow up, test.check is magic. For the right problems, it finds tricky use cases that I would never think of.

> (let [[ & [ & [& [& [& [& hi]]]]]] [42]]
    hi)
(42)
> (let [[& {:as m}] [:a 42]]
    m)
{:a 42}

Alex Miller (Clojure team) 2022-09-21T17:09:27.325719Z

generation isn't magic, but I'm pretty sure shrinking is

👆 1

Clojurians Log v2

clojure-spec