Fork me on GitHub
#clj-commons
<
2022-09-20
>
lread12:09:23

@slipset interesting tidbit: those auto invites to code owners to review PRs are uninteresting noise, at least to @borkdude and me. https://github.com/clj-commons/clj-yaml/commit/62c0895ddf74de56efa08f9d65c7b3391f78c36f. I've applied this change to all clj-commons projects where I am a code owner.

slipset13:09:14

Cool. I want to be on the ones which are not that actively maintained by others.

borkdude13:09:36

If you just watch the repo you will still get to see everything you need right? So I don't really get the use of this codeowner stuff

borkdude13:09:43

beyond stating who are the maintainers

lread13:09:26

It feels like it should have been named CODEREVIEWERS. Maybe for larger projects where you want to assign reviews to particular people for particular modules/paths it might be useful.

lread13:09:15

But not for anything I am working on.

lread13:09:22

But yeah, it is maybe not a bad standard way to list maintainers... if review spamming is also turned off.

Noah Bogart13:09:58

it's nice when there are sub-projects in a given repo. for example, i'm a "code owner" for the vim plugin sub-directory of a rust library, but not for the rest of the repo. for clj-commons, where every project has its own repo, i don't see much need for it