Clojurians Log v2
Clojure programming
Channels
Apps
clj-commons
lread 2022-09-20T12:52:23.485019Z
@slipset interesting tidbit: those auto invites to code owners to review PRs are uninteresting noise, at least to @borkdude and me. https://github.com/clj-commons/clj-yaml/commit/62c0895ddf74de56efa08f9d65c7b3391f78c36f. I've applied this change to all clj-commons projects where I am a code owner.
slipset 2022-09-20T13:07:14.240159Z
Cool. I want to be on the ones which are not that actively maintained by others.
borkdude 2022-09-20T13:08:36.568379Z
If you just watch the repo you will still get to see everything you need right? So I don't really get the use of this codeowner stuff
borkdude 2022-09-20T13:08:43.872209Z
beyond stating who are the maintainers
lread 2022-09-20T13:14:26.573349Z
It feels like it should have been named CODEREVIEWERS. Maybe for larger projects where you want to assign reviews to particular people for particular modules/paths it might be useful.
lread 2022-09-20T13:15:15.636369Z
But not for anything I am working on.
lread 2022-09-20T13:16:22.476569Z
But yeah, it is maybe not a bad standard way to list maintainers... if review spamming is also turned off.
2022-09-20T13:20:58.967379Z
it's nice when there are sub-projects in a given repo. for example, i'm a "code owner" for the vim plugin sub-directory of a rust library, but not for the rest of the repo. for clj-commons, where every project has its own repo, i don't see much need for it