Is there a workaround to http://dev.clojure.org/jira/browse/CLJ-2033 for un-namespaced keys ?

I just hit this too

it makes s/merge a bit useless tbh, not sure why it's not considered a bug

I guess a workaround would be to do the composition at a higher level, and not rely on spec/merge for merging specs like this, which is... odd

and the fact that it's macros all the way down makes this workaround also a bit hairy

Is it possible to spec protocols in any way?

Or objects that satisfy them?

I think it's encouraged to wrap protocol fn invocation, so you can instrument/spec the wrapper fn. otherwise if you mean spec predicate it's just #(satisfies? %), possibly with (s/spec pred :gen ... ) if you want to have the gen part

Anyone used spec with DataScript? Need tips on how to deal with the fact that entities are not maps, and specifically how to get the same functionality as clojure.spec/keys but for Datascript entities

@odinodin what do you mean by "not maps"? pull pretty much returns maps.

what exactly do you want to cover with spec?

I have a function that takes DataScript entities

I'd rather avoid creating maps from entities, and just use entities directly

oh, you mean thing returned by d/entity? no idea : )

🙂

Is it possible to define a spec that references itself in the definition - like in Context-Free Grammars?

Sure, via it's registered keyword

Recursive and mutually recursive specs are fine

Could you share an example?

There are several in clojure.core.specs - destructuring is recursive

Some of the ns stuff with prefix lists , etc

::prefix-list there is self-recursive

::binding-form can be ::seq-binding-form or ::map-binding-form, which can both include ::binding-form

thx

I’m looking at it

A really good example to try is just a simple tree of leaf and branch

Where branches can contain either leaf or branch

What's the best way to trigger clojure.spec tests with lein test? I.e. I have a namesapce with (stest/check (stest/enumerate-namespace 'wwai.common.util.instant)), I want it run those checks when I do lein test. I'm really using expectations, but if I see how to make it work with standard test, I should be able to adapt from their.

@mlimotte clojure.test.check’s defscpec worked for me

@ag i’d love to see an example of that on github if you have one, np if not, just figured i’d check 🙂

I came up with this hack, which kind of works, although the output in the error case, isn't very friendly:

(defmacro is-result-ok?
  [result]
  `(is (not (:failure (first ~result)))))

(deftest auto
  (doseq [spec-fn-sym (stest/enumerate-namespace 'wwai.common.util.instant)]
    (is-result-ok? (stest/check spec-fn-sym))))

I looked at defspec, but didn't see how to make it work with stest/check.

me neither!

what's the idiomatic way to express lack of arguments for a function with fdef?

just empty? should do I guess

@luxbock (s/cat)

what's the benefit over just using empty?

nothing afaik, it's just that s/cat is the normal way to start specifying :args

alright

I would've expected this to throw: https://gist.github.com/luxbock/532a19f75553ae938c0a998e3be47851

instrument does not check return values

I see

you're probably looking for clojure.spec.test/check

it runs the function a bunch of times with generated args (in this case always nothing) and checks the result conforms to :ret and that any supplied :fn relationship between :args and :ret is true

boot.user=> (s/def ::number int?)
:boot.user/number
boot.user=> (s/def ::number-list (s/coll-of ::number :min-count 1))
:boot.user/number-list
boot.user=> (s/fdef foobar
       #_=>         :args (s/cat)
       #_=>         :ret ::number-list)
boot.user/foobar
boot.user=> (defn foobar [] [])
#'boot.user/foobar
boot.user=> (clojure.spec.test/check `foobar)
({:spec #object[clojure.spec$fspec_impl$reify__13891 0x222df61e "clojure.spec$fspec_impl$reify__13891@222df61e"], :clojure.spec.test.check/ret {:result #error {
 :cause "Specification-based check failed"
 :data {:clojure.spec/problems [{:path [:ret], :pred (clojure.core/<= 1 (clojure.core/count %) Integer/MAX_VALUE), :val [], :via [], :in []}], :clojure.spec.test/args (), :clojure.spec.test/val [], :clojure.spec/failure :check-failed}
 :via
 [{:type clojure.lang.ExceptionInfo
   :message "Specification-based check failed"

thanks, yeah the function which I simplified here probably won't need a spec at all, but it's good to know this for the future

how do I specify that ::start_date must start before ::end_date in a map

so far I have (s/keys :req-un [::start-date ::end-date]) but I need to add in a predicate

the relationship between these two

perhaps you could write a constructor function rather than making instances of that map by hand, and it’s got an (s/fdef) that encodes that information?

doesn’t 100% solve the problem though

maybe you could use s/and and a predicate, something like: (s/and (s/keys :req-un [::start-date ::end-date]) #( date-before? (:start-date %) (:end-date %)))

oh interesting

i like that better

cool thanks, testing now

what is the use case of the optional argument unf to conformer?

@luxbock I'm guessing it's for a custom unformer

ah right, yeah I get it now

boot.user=> (s/def ::thing (s/conformer {1 "foo"}))
:boot.user/thing
boot.user=> (s/unform ::thing (s/conform ::thing 1))

java.lang.IllegalStateException: no unform fn for conformer
boot.user=> (s/def ::thing (s/conformer {1 "foo"} {"foo" 1}))
:boot.user/thing
boot.user=> (s/unform ::thing (s/conform ::thing 1))
1

is there a way to include doc string with the spec?

e.g. (s/and (s/keys :req-un [::start-date ::end-date]) "start date must come before end date" #( date-before? (:start-date %) (:end-date %)))

(and retrieve the doc string in explain-data)

has anyone else had trouble doing eg

(stest/instrument (stest/enumerate-namespace ‘my.ns))

i see a stacktrace with error messages like java.lang.RuntimeException: No such namespace: stest, compiling:(/private/var/folders/zl/bh7pbyz95rg7pmcvcc_f_kdm0000gn/T/form-init2230077429322923281.clj:6:19); gonna dig into it a bit, just curious if this is known / expected / if anyone else has dealt with this

if i do eg

(let [syms (stest/enumerate-namespace 'voke.events)]
    (stest/instrument syms))

Caused by: clojure.lang.ExceptionInfo: java.lang.RuntimeException: Unable to resolve symbol: syms in this context

perhaps related to the (eval) call in https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/spec/test.cljc#L110 ?

@dnolen am i doing something wrong / is this known/expected?

@jrheard yes won’t work, not intended to work

cool, good to know

should i just instrument vars by hand, naming one at a time, or is there some better way?

instrument is a macro - must take symbols that reference vars directly

just skip the locals stuff

i don’t follow

remove the let binding and it will work

i.e. do this inline

when i do (stest/instrument (stest/enumerate-namespace 'my.ns)), i get an error message complaining that stest doesn’t exist

is that what you mean by doing this inline, or am i misunderstanding?

so that’s a bug, file an issue in JIRA

gotcha, will do! thanks!

thanks, to be clear, do this in the CLJS JIRA

you got it

( CLJS-1811 )

Today's random spec experiment: Can you define an SQL schema from a clojure.spec definition?

Here's what I came up with: https://gist.github.com/olivergeorge/27e9fced404f5ddef371ea3376456f2f

(do
  (s/def ::name string?)
  (s/def ::address (varchar 256))
  (s/def ::age integer?)
  (s/def ::gender #{"M" "F"})
  (s/def ::example-table (s/keys :req-un [::name ::age ::gender]
                                 :opt-un [::address]))

  (spec->sql-table ::example-table))

oooh I should bookmark this. I'm definitely going to need spec->avro schema at some point

Produces

[["name" "varchar2(4000)" "not null"]
  ["age" "int" "not null"]
  ["gender" "varchar2(1)" "not null"]
  ["address" "varchar2(256)"]]