Fork me on GitHub
#clojure-dev
<
2019-09-17
>
alexmiller01:09:01

contrib builds poll hourly btw

andy.fingerhut01:09:58

Hey, only my wife is allowed to read my mind! 🙂

alexmiller01:09:54

I can sense your thoughts

alexmiller01:09:15

but I can poke it for you if you like

andy.fingerhut01:09:59

thanks. I can see already I have broken some tests -- will fix soon

alexmiller02:09:25

seems like something to do with running the cljs tests?

alexmiller02:09:01

let me know if you end up needing to change the minimum clojure version or whatever, that's in the build infrastructure

andy.fingerhut04:09:41

most likely a missing file.

andy.fingerhut05:09:48

There is nothing urgent about this, but it appears that contrib builds are not triggered each hour by commits. I do not know why, but wonder whether the error message on the "Git Polling Log" link is relevant: https://build.clojure.org/job/core.rrb-vector/scmPollLog/

alexmiller12:09:11

Definitely relevant, will take a look

alexmiller18:09:34

yeah, that has been broken for a while apparently. made a whole bunch of job template updates and pollers are working now (which means everything has decided to rebuild)

andy.fingerhut18:09:03

Yep, and thanks for the fix. I can try rerunning core.rrb-vector tests when those get run through.

alexmiller18:09:41

might be a while

alexmiller18:09:12

which seemed like a pretty weird error

alexmiller18:09:56

looks like the cljs tests are using clojure 1.5.1 though which seems wrong?

andy.fingerhut19:09:04

The pom.xml and project.clj files both depend upon Clojure 1.5.1 as the minimum Clojure version supported. Michal expressed a preference to keep working with that version of Clojure if possible, but perhaps I can at least disable running cljs tests with Clojure versions older than 1.8.0 or so.

andy.fingerhut19:09:41

I'm still pretty new to the various ways of running ClojureScript tests, so will be hacking and experimenting for a bit.

alexmiller19:09:06

fyi, the build box will no longer test anything older than Clojure 1.6.0, just no reason to do so based on usage in the Clojure survey (and many now require at least 1.7.0)

alexmiller20:09:43

as of the last survey, only 3% were using 1.7 or earlier

andy.fingerhut20:09:29

I know. I'm not the one with the preference for preserving working with the older Clojure versions 🙂

andy.fingerhut20:09:02

I will try bumping up Clojure version in pom.xml to 1.6.0 and see what happens. I don't see failures like that with similar mvn command run on my Linux machine, so not sure why that happens.

alexmiller20:09:23

do you have any cljc? that didn't exist until 1.7

alexmiller20:09:02

if you need my help debugging anything, let me know. I can actually ssh into the box and do a lot more

andy.fingerhut20:09:16

There are no cljc files in that project. It has supported Clojure 1.5.1 since it was created, and I have added no cljc files to it yet.

andy.fingerhut20:09:50

Bumping clojure dependency in core.rrb-vector's pom.xml up to 1.6.0 instead of former 1.5.1 seemed to help build go better on http://build.clojure.org just a few mins ago, which is good. Cool.

andy.fingerhut21:09:22

And now the whole core.rrb-vector test matrix is good on http://build.clojure.org, with running the built-in clj and also cljs tests on the build box. (it actually throws and catches an expected exception for the cljs tests for clj < 1.8 or jdk < 1.8, which matches what data.xml library does there, too).

andy.fingerhut21:09:39

Thanks for the help, Alex! I will go break some things now.

alexmiller21:09:20

sounds good :)

alexmiller21:09:36

if you need help with a release eventually, let me know

andy.fingerhut21:09:58

Will do. Probably a week or so.