This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-09-15
Channels
- # aleph (14)
- # aws (5)
- # beginners (144)
- # bitcoin (1)
- # boot (14)
- # chestnut (13)
- # cljs-dev (58)
- # cljs-experience (1)
- # cljsrn (47)
- # clojure (107)
- # clojure-dev (9)
- # clojure-finland (12)
- # clojure-gamedev (4)
- # clojure-russia (2)
- # clojure-sanfrancisco (1)
- # clojure-spec (5)
- # clojure-uk (28)
- # clojurescript (34)
- # cursive (9)
- # datomic (3)
- # emacs (11)
- # garden (16)
- # graphql (9)
- # hoplon (3)
- # jobs (2)
- # juxt (6)
- # off-topic (32)
- # om (10)
- # onyx (1)
- # pedestal (4)
- # proton (1)
- # re-frame (14)
- # reagent (8)
- # ring (1)
- # ring-swagger (34)
- # shadow-cljs (19)
- # sioux-falls (1)
- # spacemacs (16)
- # testing (14)
@lxsameer we don’t want that try/catch in there - I just don’t understand what that’s accomplishing
that's true but the point of a predicate is to either return true of false, and not to throw an exception
@dnolen I'm writing down my experience about contributing to cljs so i can make an article from them later for http://clojurescript.org, so
can you please point out the main problems about that try/catch
? i want to add them for later reference
what's the ups-extern
in here https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L309
deps.cljs
is a special EDN file that can be contained in JAR which define foreign libs, externs, etc.
Try/catch is because 22 instanceof goog.Uri
throws TypeError (which surprised me). Would need a typeof 22 === "object"
guard
@ambrosebs your AST :const
patch needs a rebase
@dnolen you may have missed this one https://dev.clojure.org/jira/browse/CLJS-2355
but I accidentally pasted *warn-on-reflection*
in CLJS tests
that fixes it
@anmonteiro on master I keep getting a weird warning now while installing Node.js deps
Installing Node.js dependencies events.js:160 throw er; // Unhandled ‘error’ event ^ Error: Can’t resolve ‘./calculator_amd’ in ‘/Users/davidnolen/development/clojure/clojurescript’
expected
safe to ignore
let me dig the reason
@dnolen here: https://github.com/clojure/clojurescript/commit/79041d10ce11e9e2f15c261a9a4174c6a7066834
we now feed foreign libs to module-deps
as well
to gather their dependencies
but it doesn’t handle the AMD case
(or rather, that’s the case where ES6 imports AMD)
we don’t feed AMD modules to module_deps
@anmonteiro can we close this one?
@dnolen I think we can close 2289
even though my PRs didn’t make it to this Closure release
but it fixes some other bugs. I’ll put together a patch to bump Closure later